mirror/kopia
1
0
Fork 0
mirror of https://github.com/kopia/kopia.git synced 2026-03-30 20:13:46 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor(general): remove dry run option for blob retention ext (#4962)

Browse Source
This commit is contained in:
Julio Lopez
2025-11-06 11:12:46 -08:00
committed by GitHub
parent 3b7f193c29
commit b0f99ccb7f
1 changed files with 19 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
repo/maintenance/blob_retain.go
View File

@@ -26,7 +26,6 @@
// ExtendBlobRetentionTimeOptions provides options for extending blob retention algorithm.
type ExtendBlobRetentionTimeOptions struct {
Parallel int
DryRun bool
}
// extendBlobRetentionTime extends the retention time of all relevant blobs managed by storage engine with Object Locking enabled.
@@ -64,39 +63,35 @@ func extendBlobRetentionTime(ctx context.Context, rep repo.DirectRepositoryWrite
opt.Parallel = runtime.NumCPU() * parallelBlobRetainCPUMultiplier
}
if !opt.DryRun {
// start goroutines to extend blob retention as they come.
for range opt.Parallel {
wg.Go(func() error {
for bm := range extend {
if err1 := rep.BlobStorage().ExtendBlobRetention(ctx, bm.BlobID, extendOpts); err1 != nil {
contentlog.Log2(ctx, log,
"Failed to extend blob",
blobparam.BlobID("blobID", bm.BlobID),
logparam.Error("error", err1))
// start goroutines to extend blob retention as they come.
for range opt.Parallel {
wg.Go(func() error {
for bm := range extend {
if err1 := rep.BlobStorage().ExtendBlobRetention(ctx, bm.BlobID, extendOpts); err1 != nil {
contentlog.Log2(ctx, log,
"Failed to extend blob",
blobparam.BlobID("blobID", bm.BlobID),
logparam.Error("error", err1))
failedCount.Add(1)
failedCount.Add(1)
continue
}
if currentCount := extendedCount.Add(1); currentCount%100 == 0 {
contentlog.Log1(ctx, log, "extended blobs", logparam.UInt32("count", currentCount))
}
continue
}
return nil
})
}
if currentCount := extendedCount.Add(1); currentCount%100 == 0 {
contentlog.Log1(ctx, log, "extended blobs", logparam.UInt32("count", currentCount))
}
}
return nil
})
}
// iterate all relevant (active, extendable) blobs and count them + optionally send to the channel to be extended
contentlog.Log(ctx, log, "Extending retention time for blobs...")
err = blob.IterateAllPrefixesInParallel(ctx, opt.Parallel, rep.BlobStorage(), repo.GetLockingStoragePrefixes(), func(bm blob.Metadata) error {
if !opt.DryRun {
extend <- bm
}
extend <- bm
toExtend.Add(1)