fix(snapshots): Fixup for #3624. Shadow copy seems to extend time for snapshots. (#3625)

* fixup for ticket #3624

* skip, now broken, test

* lint fixup.  how did this get into the repository in the first place?!

* elide shadow copy tests until fixup.  do not allow release

* fixup for shadow copy mode from @small

* Update cli/command_policy_set_os_snapshot_test.go

* restore old tests

* fixup typo

---------

Co-authored-by: Shikhar Mall <mall.shikhar.in@gmail.com>

cli/command_policy_set_os_snapshot_test.go

@@ -17,6 +17,13 @@ func TestSetOSSnapshotPolicy(t *testing.T) {
 
 	lines := e.RunAndExpectSuccess(t, "policy", "show", "--global")
 	lines = compressSpaces(lines)
+	require.Contains(t, lines, " Volume Shadow Copy: never (defined for this target)")
+
+	e.RunAndExpectSuccess(t, "policy", "set", "--global", "--enable-volume-shadow-copy=when-available")
+
+	lines = e.RunAndExpectSuccess(t, "policy", "show", "--global")
+	lines = compressSpaces(lines)
+
 	require.Contains(t, lines, " Volume Shadow Copy: when-available (defined for this target)")
 
 	// make some directory we'll be setting policy on

snapshot/policy/policy_tree.go

@@ -55,7 +55,7 @@ var (
 
 	defaultOSSnapshotPolicy = OSSnapshotPolicy{
 		VolumeShadowCopy: VolumeShadowCopyPolicy{
-			Enable: NewOSSnapshotMode(OSSnapshotWhenAvailable),
+			Enable: NewOSSnapshotMode(OSSnapshotNever),
 		},
 	}