deprecated inline object IDs, which cause significant slowdowns to the backup process, will be much more efficient with pack files

This commit is contained in:
Jarek Kowalski
2017-08-07 15:11:01 +02:00
parent 8d714b48da
commit dbeabbb1ef
3 changed files with 5 additions and 2 deletions

View File

@@ -22,7 +22,7 @@
createAvgBlockSize = createCommand.Flag("avg-block-size", "Average size of a data block.").PlaceHolder("KB").Default("10240").Int()
createMaxBlockSize = createCommand.Flag("max-block-size", "Maximum size of a data block.").PlaceHolder("KB").Default("20480").Int()
createInlineBlobSize = createCommand.Flag("inline-blob-size", "Maximum size of an inline data object.").PlaceHolder("KB").Default("32").Int()
createInlineBlobSize = createCommand.Flag("inline-blob-size", "Maximum size of an inline data object.").PlaceHolder("KB").Default("0").Int()
createOverwrite = createCommand.Flag("overwrite", "Overwrite existing data (DANGEROUS).").Bool()
createOnly = createCommand.Flag("create-only", "Create repository, but don't connect to it.").Short('c').Bool()
)

View File

@@ -55,6 +55,7 @@ func runStatusCommand(context *kingpin.ParseContext) error {
fmt.Printf("Object manager: v%v\n", s.ObjectManagerVersion)
fmt.Printf("Object format: %v\n", s.ObjectFormat)
fmt.Printf("Splitter: %v%v\n", s.Splitter, splitterExtraInfo)
fmt.Printf("Inline content len: %v\n", s.MaxInlineContentLength)
if s.MaxPackFileLength > 0 {
fmt.Printf("Max pack file size: %v (max object %v)\n", units.BytesStringBase2(int64(s.MaxPackFileLength)), units.BytesStringBase2(int64(s.MaxPackedContentLength)))
}

View File

@@ -94,12 +94,14 @@ func repositoryObjectFormatFromOptions(opt *NewRepositoryOptions) config.Reposit
ObjectFormat: applyDefaultString(opt.ObjectFormat, DefaultObjectFormat),
HMACSecret: applyDefaultRandomBytes(opt.ObjectHMACSecret, 32),
MasterKey: applyDefaultRandomBytes(opt.ObjectEncryptionKey, 32),
MaxInlineContentLength: applyDefaultInt(opt.MaxInlineContentLength, 32<<10), // 32KiB
MaxBlockSize: applyDefaultInt(opt.MaxBlockSize, 20<<20), // 20MiB
MinBlockSize: applyDefaultInt(opt.MinBlockSize, 10<<20), // 10MiB
AvgBlockSize: applyDefaultInt(opt.AvgBlockSize, 16<<20), // 16MiB
MaxPackedContentLength: applyDefaultInt(opt.MaxPackedContentLength, 1<<20), // 1 MB
MaxPackFileLength: applyDefaultInt(opt.MaxPackedContentLength, 20<<20), // 20 MB
// deprecated, will be removed soon
MaxInlineContentLength: opt.MaxInlineContentLength,
}
if opt.noHMAC {