mirror of
https://github.com/kopia/kopia.git
synced 2026-01-24 06:18:02 -05:00
9bf9cac7fb
* refactor(repository): ensure we always parse content.ID and object.ID
This changes the types to be incompatible with string to prevent direct
conversion to and from string.
This has the additional benefit of reducing number of memory allocations
and bytes for all IDs.
content.ID went from 2 allocations to 1:
typical case 32 characters + 16 bytes per-string overhead
worst-case 65 characters + 16 bytes per-string overhead
now: 34 bytes
object.ID went from 2 allocations to 1:
typical case 32 characters + 16 bytes per-string overhead
worst-case 65 characters + 16 bytes per-string overhead
now: 36 bytes
* move index.{ID,IDRange} methods to separate files
* replaced index.IDFromHash with content.IDFromHash externally
* minor tweaks and additional tests
* Update repo/content/index/id_test.go
Co-authored-by: Julio Lopez <1953782+julio-lopez@users.noreply.github.com>
* Update repo/content/index/id_test.go
Co-authored-by: Julio Lopez <1953782+julio-lopez@users.noreply.github.com>
* pr feedback
* post-merge fixes
* pr feedback
* pr feedback
* fixed subtle regression in sortedContents()
This was actually not producing invalid results because of how base36
works, just not sorting as efficiently as it could.
Co-authored-by: Julio Lopez <1953782+julio-lopez@users.noreply.github.com>
52 lines
1.5 KiB
Go
52 lines
1.5 KiB
Go
package cli
|
|
|
|
import (
|
|
"context"
|
|
"time"
|
|
|
|
"github.com/kopia/kopia/repo"
|
|
"github.com/kopia/kopia/repo/content"
|
|
)
|
|
|
|
type commandIndexOptimize struct {
|
|
optimizeMaxSmallBlobs int
|
|
optimizeDropDeletedOlderThan time.Duration
|
|
optimizeDropContents []string
|
|
optimizeAllIndexes bool
|
|
|
|
svc appServices
|
|
}
|
|
|
|
func (c *commandIndexOptimize) setup(svc appServices, parent commandParent) {
|
|
cmd := parent.Command("optimize", "Optimize indexes blobs.")
|
|
cmd.Flag("max-small-blobs", "Maximum number of small index blobs that can be left after compaction.").Default("1").IntVar(&c.optimizeMaxSmallBlobs)
|
|
cmd.Flag("drop-deleted-older-than", "Drop deleted contents above given age").DurationVar(&c.optimizeDropDeletedOlderThan)
|
|
cmd.Flag("drop-contents", "Drop contents with given IDs").StringsVar(&c.optimizeDropContents)
|
|
cmd.Flag("all", "Optimize all indexes, even those above maximum size.").BoolVar(&c.optimizeAllIndexes)
|
|
cmd.Action(svc.directRepositoryWriteAction(c.runOptimizeCommand))
|
|
|
|
c.svc = svc
|
|
}
|
|
|
|
func (c *commandIndexOptimize) runOptimizeCommand(ctx context.Context, rep repo.DirectRepositoryWriter) error {
|
|
c.svc.advancedCommand(ctx)
|
|
|
|
contentIDs, err := toContentIDs(c.optimizeDropContents)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
opt := content.CompactOptions{
|
|
MaxSmallBlobs: c.optimizeMaxSmallBlobs,
|
|
AllIndexes: c.optimizeAllIndexes,
|
|
DropContents: contentIDs,
|
|
}
|
|
|
|
if age := c.optimizeDropDeletedOlderThan; age > 0 {
|
|
opt.DropDeletedBefore = rep.Time().Add(-age)
|
|
}
|
|
|
|
// nolint:wrapcheck
|
|
return rep.ContentManager().CompactIndexes(ctx, opt)
|
|
}
|