ZynAddSubFX: fixed various CLANG compiler warnings

plugins/zynaddsubfx/src/DSP/AnalogFilter.h

@@ -71,7 +71,6 @@ class AnalogFilter:public Filter_
 
         REALTYPE oldc[3], oldd[3]; //old coefficients(used only if some filter paremeters changes very fast, and it needs interpolation)
 
-        REALTYPE xd[3], yd[3]; //used if the filter is applied more times
         int      needsinterpolation, firsttime; /**\todo see if bool works for these*/
         int      abovenq; //this is 1 if the frequency is above the nyquist
         int      oldabovenq; //if the last time was above nyquist (used to see if it needs interpolation)

plugins/zynaddsubfx/src/Effects/EffectLFO.h

@@ -43,7 +43,6 @@ class EffectLFO
         REALTYPE xl, xr;
         REALTYPE incx;
         REALTYPE ampl1, ampl2, ampr1, ampr2; //necessary for "randomness"
-        REALTYPE lfointensity;
         REALTYPE lfornd;
         char     lfotype; /**\todo GET RID OF CHAR (replace with short or enum)*/
 };

plugins/zynaddsubfx/src/Effects/Reverb.h

@@ -102,10 +102,10 @@ class Reverb:public Effect
         void setroomsize(unsigned char Proomsize);
         void setbandwidth(unsigned char Pbandwidth);
 
-        REALTYPE pan, erbalance;
+        REALTYPE pan;
         //Parameters
         int      lohidamptype; /**<0=disable,1=highdamp(lowpass),2=lowdamp(highpass)*/
-        int      idelaylen, rdelaylen;
+        int      idelaylen;
         int      idelayk;
         REALTYPE lohifb, idelayfb, roomsize, rs; //rs is used to "normalise" the volume according to the roomsize
         int      comblen[REV_COMBS * 2];

plugins/zynaddsubfx/src/UI/EffUI.fl

@@ -148,7 +148,7 @@ return(20.0*pow((REALTYPE)1000.0,x));} {}
     code {if (freq<0.00001) freq=0.00001;
 return(log(freq/20.0)/log(1000.0));} {}
   }
-  decl {int oldx,oldy;} {}
+  decl {int oldx;} {}
   decl {REALTYPE khzval;} {public
   }
   decl {EffectMgr *eff;} {}

plugins/zynaddsubfx/src/UI/EffUI.h

@@ -24,7 +24,7 @@ public:
   REALTYPE getfreqx(REALTYPE x);
   REALTYPE getfreqpos(REALTYPE freq);
 private:
-  int oldx,oldy; 
+  int oldx; 
 public:
   REALTYPE khzval; 
 private:

plugins/zynaddsubfx/src/UI/EnvelopeUI.fl

@@ -189,7 +189,7 @@ return(1);} {}
   }
   decl {Fl_Box *pair;} {}
   decl {EnvelopeParams *env;} {}
-  decl {int oldx,oldy;} {}
+  decl {int oldx;} {}
   decl {int currentpoint,cpx,cpdt;} {}
   decl {int lastpoint;} {public
   }

plugins/zynaddsubfx/src/UI/EnvelopeUI.h

@@ -29,7 +29,7 @@ public:
 private:
   Fl_Box *pair; 
   EnvelopeParams *env; 
-  int oldx,oldy; 
+  int oldx; 
   int currentpoint,cpx,cpdt; 
 public:
   int lastpoint; 

plugins/zynaddsubfx/src/UI/FilterUI.fl

@@ -144,7 +144,7 @@ for (i=1;i<lx;i++){
     code {delete [] graphpoints;} {}
   }
   decl {FilterParams *pars;} {}
-  decl {int oldx,oldy;} {}
+  decl {int oldx;} {}
   decl {int *nvowel,*nformant;} {}
   decl {REALTYPE *graphpoints;} {}
 } 

plugins/zynaddsubfx/src/UI/FilterUI.h

@@ -23,7 +23,7 @@ public:
   ~FormantFilterGraph();
 private:
   FilterParams *pars; 
-  int oldx,oldy; 
+  int oldx; 
   int *nvowel,*nformant; 
   REALTYPE *graphpoints; 
 };

plugins/zynaddsubfx/src/UI/PartUI.cc

@@ -1814,7 +1814,7 @@ void PartUI::init(Part *part_,Master *master_,int npart_,BankUI *bankui_) {
   while (klimits[k]!=0){
   	sprintf(tmp,"%d",klimits[k]);
   	keylimitlist->add(tmp);
-  	if ((val==-1)){
+  	if (val==-1){
   		if (klimits[k]>part->Pkeylimit) val=k;
   	};
   	k++;