mirror of
https://github.com/LMMS/lmms.git
synced 2025-12-23 22:58:33 -05:00
* Replace knobFModel with std::vector * Create QPixmap's on the stack * Assign parent for QGraphicsScene A call to QGraphicsView::setScene does not make the view take ownership of the scene. * Do not allocate QList on the heap * Use static QPixmap's The QPixmap's need to be created within the constructor, and not outside where they are defined, since it can't find them otherwise. I'm not too sure why. * Clear m_vi2->knobFModel in destructor * Use local static QPixmap's * Do not allocate QPixmap with new in AudioFileProcessor * Do not allocate QPixmap with new in Nes * Do not allocate QPixmap with new in Organic * Do not allocate QPixmap with new in SaControlsDialog * Do not allocate QPixmap with new in Vestige * Do not allocate QPixmap with new for FileBrowser * Do not allocate QPixmap with new in MixerLine * Do not allocate QPixmap with new in SendButtonIndicator * Do not allocate QPixmap with new in AutomationClipView * Do not allocate QPixmap with new in MidiClipView * Do not allocate QPixmap with new in AutomationEditor * Do not allocate QPixmap with new in PianoRoll * Do not allocate QPixmap with new in TimeLineWidget * Do not allocate QPixmap with new in EnvelopeAndLfoView * Do not allocate QPixmap with new in PianoView * Do not allocate QPixmap with new in ComboBox * Do not allocate QPixmap with new in Fader * Do not allocate QPixmap with new for LcdWidget * Do not allocate QPixmap with new for LedCheckbox * Use m_ as prefix for members * Use uniform initialization I already started using uniform initialization for the QPixmap changes for some reason, so I'm finishing that up. * Uniform initiaization * And then he realized he was making copies... * Do not call QPixmap copy constructor * Do not call QPixmap copy constructor in SaControlsDialog * Do not make pixmap's static for Lcd's and Led's * Initialize pixmaps in-class * Fix few mistakes and formatting
86 lines
2.1 KiB
C++
86 lines
2.1 KiB
C++
/*
|
|
* ComboBox.h - class ComboBox, a combo box view for models
|
|
*
|
|
* Copyright (c) 2006-2014 Tobias Doerffel <tobydox/at/users.sourceforge.net>
|
|
*
|
|
* This file is part of LMMS - https://lmms.io
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public
|
|
* License along with this program (see COPYING); if not, write to the
|
|
* Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
|
|
* Boston, MA 02110-1301 USA.
|
|
*
|
|
*/
|
|
|
|
#ifndef LMMS_GUI_COMBOBOX_H
|
|
#define LMMS_GUI_COMBOBOX_H
|
|
|
|
#include <QMenu>
|
|
#include <QWidget>
|
|
|
|
#include "ComboBoxModel.h"
|
|
#include "AutomatableModelView.h"
|
|
|
|
namespace lmms::gui
|
|
{
|
|
|
|
class LMMS_EXPORT ComboBox : public QWidget, public IntModelView
|
|
{
|
|
Q_OBJECT
|
|
public:
|
|
ComboBox( QWidget* parent = nullptr, const QString& name = QString() );
|
|
~ComboBox() override = default;
|
|
|
|
ComboBoxModel* model()
|
|
{
|
|
return castModel<ComboBoxModel>();
|
|
}
|
|
|
|
const ComboBoxModel* model() const
|
|
{
|
|
return castModel<ComboBoxModel>();
|
|
}
|
|
|
|
static constexpr int DEFAULT_HEIGHT = 22;
|
|
|
|
public slots:
|
|
void selectNext();
|
|
void selectPrevious();
|
|
|
|
|
|
protected:
|
|
void contextMenuEvent( QContextMenuEvent* event ) override;
|
|
void mousePressEvent( QMouseEvent* event ) override;
|
|
void paintEvent( QPaintEvent* event ) override;
|
|
void wheelEvent( QWheelEvent* event ) override;
|
|
|
|
|
|
private:
|
|
QPixmap m_background = embed::getIconPixmap("combobox_bg");
|
|
QPixmap m_arrow = embed::getIconPixmap("combobox_arrow");
|
|
QPixmap m_arrowSelected = embed::getIconPixmap("combobox_arrow_selected");
|
|
|
|
QMenu m_menu;
|
|
|
|
bool m_pressed;
|
|
|
|
|
|
private slots:
|
|
void setItem( QAction* item );
|
|
|
|
} ;
|
|
|
|
} // namespace lmms::gui
|
|
|
|
#endif // LMMS_GUI_COMBOBOX_H
|