mirror of
https://github.com/LMMS/lmms.git
synced 2025-12-23 22:58:33 -05:00
8821d88c09
* Accessors for volume, cutoff, resonance Add private accessors for the volume, cutoff and resonance parameters (envelope and LFO). This makes the code less technical and more readable as it for example removes lots of static casts. The casts are now done in a special helper method that returns the parameters for a given target. * Remove EnvelopeAndLfoParameters array Remove the `EnvelopeAndLfoParameters` array and use explicit instances for volume, cutoff, resonance. This simplifies construction and initialization of the instances. Besides the array this also removes the `Target` enum and the `NumTargets` value. To simplify storage and retrieval of the parameters three private methods have been added which provide the node names of the volume, cutoff and resonance parameters. Adjust `InstrumentSoundShapingView` to the removed `NumTargets` property. * Use references instead of pointers Use references to the volume, cutoff and resonance parameters instead of pointers. * Remove friend relationship Remove the friend relationship between `InstrumentSoundShaping` and its related view by providing the models via getters. * Get rid of targetNames Get rid of `InstrumentSoundShaping::targetNames` by using translations and strings directly. Move the remaining stuff into `InstrumentSoundShapingView` until it is removed there as well. * Explicit EnvelopeAndLfoViews Remove the array of EnvelopeAndLfoViews and use dedicated instances instead. This also enables the final removal of the remaining `targetNames`. * Move the code of some getters Move the code of some getters into the header file. * Several code review changes Apply some code review proposals. Co-authored-by: Sotonye Atemie <sakertooth@gmail.com> --------- Co-authored-by: Sotonye Atemie <sakertooth@gmail.com>
104 lines
3.1 KiB
C++
104 lines
3.1 KiB
C++
/*
|
|
* InstrumentSoundShaping.h - declaration of class InstrumentSoundShaping
|
|
*
|
|
* Copyright (c) 2004-2009 Tobias Doerffel <tobydox/at/users.sourceforge.net>
|
|
*
|
|
* This file is part of LMMS - https://lmms.io
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public
|
|
* License along with this program (see COPYING); if not, write to the
|
|
* Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
|
|
* Boston, MA 02110-1301 USA.
|
|
*
|
|
*/
|
|
|
|
#ifndef LMMS_INSTRUMENT_SOUND_SHAPING_H
|
|
#define LMMS_INSTRUMENT_SOUND_SHAPING_H
|
|
|
|
#include "ComboBoxModel.h"
|
|
#include "EnvelopeAndLfoParameters.h"
|
|
|
|
namespace lmms
|
|
{
|
|
|
|
|
|
class InstrumentTrack;
|
|
class NotePlayHandle;
|
|
class SampleFrame;
|
|
|
|
namespace gui
|
|
{
|
|
class InstrumentSoundShapingView;
|
|
}
|
|
|
|
|
|
class InstrumentSoundShaping : public Model, public JournallingObject
|
|
{
|
|
Q_OBJECT
|
|
public:
|
|
InstrumentSoundShaping( InstrumentTrack * _instrument_track );
|
|
~InstrumentSoundShaping() override = default;
|
|
|
|
void processAudioBuffer( SampleFrame* _ab, const fpp_t _frames,
|
|
NotePlayHandle * _n );
|
|
|
|
const EnvelopeAndLfoParameters& getVolumeParameters() const { return m_volumeParameters; }
|
|
EnvelopeAndLfoParameters& getVolumeParameters() { return m_volumeParameters; }
|
|
|
|
const EnvelopeAndLfoParameters& getCutoffParameters() const { return m_cutoffParameters; }
|
|
EnvelopeAndLfoParameters& getCutoffParameters() { return m_cutoffParameters; }
|
|
|
|
const EnvelopeAndLfoParameters& getResonanceParameters() const { return m_resonanceParameters; }
|
|
EnvelopeAndLfoParameters& getResonanceParameters() { return m_resonanceParameters; }
|
|
|
|
BoolModel& getFilterEnabledModel() { return m_filterEnabledModel; }
|
|
ComboBoxModel& getFilterModel() { return m_filterModel; }
|
|
FloatModel& getFilterCutModel() { return m_filterCutModel; }
|
|
FloatModel& getFilterResModel() { return m_filterResModel; }
|
|
|
|
f_cnt_t envFrames( const bool _only_vol = false ) const;
|
|
f_cnt_t releaseFrames() const;
|
|
|
|
float volumeLevel( NotePlayHandle * _n, const f_cnt_t _frame );
|
|
|
|
|
|
void saveSettings( QDomDocument & _doc, QDomElement & _parent ) override;
|
|
void loadSettings( const QDomElement & _this ) override;
|
|
inline QString nodeName() const override
|
|
{
|
|
return "eldata";
|
|
}
|
|
|
|
private:
|
|
QString getVolumeNodeName() const;
|
|
QString getCutoffNodeName() const;
|
|
QString getResonanceNodeName() const;
|
|
|
|
private:
|
|
InstrumentTrack * m_instrumentTrack;
|
|
|
|
EnvelopeAndLfoParameters m_volumeParameters;
|
|
EnvelopeAndLfoParameters m_cutoffParameters;
|
|
EnvelopeAndLfoParameters m_resonanceParameters;
|
|
|
|
BoolModel m_filterEnabledModel;
|
|
ComboBoxModel m_filterModel;
|
|
FloatModel m_filterCutModel;
|
|
FloatModel m_filterResModel;
|
|
};
|
|
|
|
|
|
} // namespace lmms
|
|
|
|
#endif // LMMS_INSTRUMENT_SOUND_SHAPING_H
|