mirror of
https://github.com/LMMS/lmms.git
synced 2025-12-23 22:58:33 -05:00
71ce49d7ba
Follow-Up of 7db3fa94a1 .
This was done by setting `CMAKE_C_INCLUDE_WHAT_YOU_USE` and
`CMAKE_CXX_INCLUDE_WHAT_YOU_USE` to (broken down into multiple lines here,
note, all below `FL/x.h` is not required for C):
```
include-what-you-use;
-Xiwyu;--mapping_file=/usr/share/include-what-you-use/qt5_11.imp;
-Xiwyu;--keep=*/xmmintrin.h;
-Xiwyu;--keep=*/lmmsconfig.h;
-Xiwyu;--keep=*/weak_libjack.h;
-Xiwyu;--keep=*/sys/*;
-Xiwyu;--keep=*/debug.h;
-Xiwyu;--keep=*/SDL/*;
-Xiwyu;--keep=*/alsa/*;
-Xiwyu;--keep=*/FL/x.h;
-Xiwyu;--keep=*/MidiApple.h;
-Xiwyu;--keep=*/MidiWinMM.h;
-Xiwyu;--keep=*/AudioSoundIo.h;
-Xiwyu;--keep=*/OpulenZ/adplug/*;
-Xiwyu;--keep=QPainterPath;
-Xiwyu;--keep=QtTest
```
FAQ:
* Q: Does this speed-up a completely fresh compile?
* A: No, I measured it.
* Q: Does it speed up anything else?
* A: Yes. If you change one header, it can reduce the number of CPP files
that your compiler needs to recompile, or your IDE has to re-scan.
* Q: What other reasons are for this PR?
* A: It's idiomatic to only include headers if you need them. Also, it will
reduce output for those who want to use IWYU for new PRs.
Background:
This is just a remainder PR of what I planned. My original idea was to setup
a CI which warns you of useless includes (but not of all issues that IWYU
complains about). However, I could not see that this was favored on Discord.
A full IWYU CI also has the problem that it (possibly??) needs to compile
with `make -j 1`, which would make CI really slow.
However, for that plan, I had to fix the whole code base to be IWYU
compliant - which it now is.
122 lines
3.1 KiB
C++
122 lines
3.1 KiB
C++
/*
|
|
* LinkedModelGroupViews.h - view for groups of linkable models
|
|
*
|
|
* Copyright (c) 2019-2019 Johannes Lorenz <j.git$$$lorenz-ho.me, $$$=@>
|
|
*
|
|
* This file is part of LMMS - https://lmms.io
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public
|
|
* License along with this program (see COPYING); if not, write to the
|
|
* Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
|
|
* Boston, MA 02110-1301 USA.
|
|
*
|
|
*/
|
|
|
|
#ifndef LMMS_GUI_LINKED_MODEL_GROUP_VIEWS_H
|
|
#define LMMS_GUI_LINKED_MODEL_GROUP_VIEWS_H
|
|
|
|
#include <cstddef>
|
|
#include <memory>
|
|
#include <QWidget>
|
|
|
|
namespace lmms
|
|
{
|
|
|
|
|
|
class LinkedModelGroup;
|
|
class LinkedModelGroups;
|
|
|
|
|
|
namespace gui
|
|
{
|
|
|
|
class Control; // IWYU pragma: keep
|
|
|
|
/**
|
|
@file LinkedModelGroupViews.h
|
|
See Lv2ViewBase.h for example usage
|
|
*/
|
|
|
|
|
|
/**
|
|
View for a representative processor
|
|
|
|
Features:
|
|
* Remove button for removable models
|
|
* Simple handling of adding, removing and model changing
|
|
|
|
@note Neither this class, nor any inheriting classes, shall inherit
|
|
ModelView. The "view" in the name is just for consistency
|
|
with LinkedModelGroupsView.
|
|
*/
|
|
class LinkedModelGroupView : public QWidget
|
|
{
|
|
public:
|
|
/**
|
|
@param colNum numbers of columns for the controls
|
|
(link LEDs not counted)
|
|
*/
|
|
LinkedModelGroupView(QWidget* parent, LinkedModelGroup* model,
|
|
std::size_t colNum);
|
|
~LinkedModelGroupView() override = default;
|
|
|
|
//! Reconnect models if model changed
|
|
void modelChanged(LinkedModelGroup* linkedModelGroup);
|
|
|
|
protected:
|
|
//! Add a control to this widget
|
|
//! @warning This widget will own this control, do not free it
|
|
void addControl(Control* ctrl, const std::string &id,
|
|
const std::string& display, bool removable);
|
|
|
|
void removeControl(const QString &key);
|
|
|
|
void removeFocusFromSearchBar();
|
|
|
|
private:
|
|
class LinkedModelGroup* m_model;
|
|
|
|
//! column number in surrounding grid in LinkedModelGroupsView
|
|
std::size_t m_colNum;
|
|
class ControlLayout* m_layout;
|
|
std::map<std::string, std::unique_ptr<class Control>> m_widgets;
|
|
};
|
|
|
|
|
|
/**
|
|
Container class for one LinkedModelGroupView
|
|
|
|
@note It's intended this class does not inherit from ModelView.
|
|
Inheriting classes need to do that, see e.g. Lv2Instrument.h
|
|
*/
|
|
class LinkedModelGroupsView
|
|
{
|
|
protected:
|
|
~LinkedModelGroupsView() = default;
|
|
|
|
//! Reconnect models if model changed; to be called by child virtuals
|
|
void modelChanged(LinkedModelGroups* ctrlBase);
|
|
|
|
private:
|
|
//! The base class must return the addressed group view,
|
|
//! which has the same value as "this"
|
|
virtual LinkedModelGroupView* getGroupView() = 0;
|
|
};
|
|
|
|
|
|
} // namespace gui
|
|
|
|
} // namespace lmms
|
|
|
|
#endif // LMMS_GUI_LINKED_MODEL_GROUP_VIEWS_H
|