mirror of
https://github.com/LMMS/lmms.git
synced 2026-01-05 13:08:08 -05:00
71ce49d7ba
Follow-Up of 7db3fa94a1 .
This was done by setting `CMAKE_C_INCLUDE_WHAT_YOU_USE` and
`CMAKE_CXX_INCLUDE_WHAT_YOU_USE` to (broken down into multiple lines here,
note, all below `FL/x.h` is not required for C):
```
include-what-you-use;
-Xiwyu;--mapping_file=/usr/share/include-what-you-use/qt5_11.imp;
-Xiwyu;--keep=*/xmmintrin.h;
-Xiwyu;--keep=*/lmmsconfig.h;
-Xiwyu;--keep=*/weak_libjack.h;
-Xiwyu;--keep=*/sys/*;
-Xiwyu;--keep=*/debug.h;
-Xiwyu;--keep=*/SDL/*;
-Xiwyu;--keep=*/alsa/*;
-Xiwyu;--keep=*/FL/x.h;
-Xiwyu;--keep=*/MidiApple.h;
-Xiwyu;--keep=*/MidiWinMM.h;
-Xiwyu;--keep=*/AudioSoundIo.h;
-Xiwyu;--keep=*/OpulenZ/adplug/*;
-Xiwyu;--keep=QPainterPath;
-Xiwyu;--keep=QtTest
```
FAQ:
* Q: Does this speed-up a completely fresh compile?
* A: No, I measured it.
* Q: Does it speed up anything else?
* A: Yes. If you change one header, it can reduce the number of CPP files
that your compiler needs to recompile, or your IDE has to re-scan.
* Q: What other reasons are for this PR?
* A: It's idiomatic to only include headers if you need them. Also, it will
reduce output for those who want to use IWYU for new PRs.
Background:
This is just a remainder PR of what I planned. My original idea was to setup
a CI which warns you of useless includes (but not of all issues that IWYU
complains about). However, I could not see that this was favored on Discord.
A full IWYU CI also has the problem that it (possibly??) needs to compile
with `make -j 1`, which would make CI really slow.
However, for that plan, I had to fix the whole code base to be IWYU
compliant - which it now is.
91 lines
2.4 KiB
C++
91 lines
2.4 KiB
C++
/*
|
|
* Lv2Features.h - Lv2Features class
|
|
*
|
|
* Copyright (c) 2020-2020 Johannes Lorenz <jlsf2013$users.sourceforge.net, $=@>
|
|
*
|
|
* This file is part of LMMS - https://lmms.io
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public
|
|
* License along with this program (see COPYING); if not, write to the
|
|
* Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
|
|
* Boston, MA 02110-1301 USA.
|
|
*
|
|
*/
|
|
|
|
#ifndef LMMS_LV2_FEATURES_H
|
|
#define LMMS_LV2_FEATURES_H
|
|
|
|
#include "lmmsconfig.h"
|
|
|
|
#ifdef LMMS_HAVE_LV2
|
|
|
|
#include <map>
|
|
#include <string_view>
|
|
#include <vector>
|
|
|
|
#include <lv2/core/lv2.h>
|
|
|
|
namespace lmms
|
|
{
|
|
|
|
/**
|
|
Feature container
|
|
|
|
References all available features for a plugin and maps them to their URIs.
|
|
|
|
The public member functions should be called in descending order:
|
|
|
|
1. initCommon: map plugin-common features
|
|
2. operator[]: map plugin-specific features
|
|
3. createFeatureVectors: create the feature vectors required for
|
|
lilv_plugin_instantiate
|
|
4. access the latter
|
|
*/
|
|
class Lv2Features
|
|
{
|
|
public:
|
|
//! Return if a feature is supported by LMMS
|
|
static bool isFeatureSupported(const char *featName);
|
|
|
|
Lv2Features();
|
|
|
|
//! Register only plugin-common features
|
|
void initCommon();
|
|
//! Return reference to feature data with given URI featName
|
|
void*& operator[](const char* featName);
|
|
//! Fill m_features and m_featurePointers with all features
|
|
void createFeatureVectors();
|
|
//! Return LV2_Feature pointer vector, suited for lilv_plugin_instantiate
|
|
const LV2_Feature* const* featurePointers() const
|
|
{
|
|
return m_featurePointers.data();
|
|
}
|
|
//! Clear everything
|
|
void clear();
|
|
|
|
private:
|
|
//! feature storage
|
|
std::vector<LV2_Feature> m_features;
|
|
//! pointers to m_features, required for lilv_plugin_instantiate
|
|
std::vector<const LV2_Feature*> m_featurePointers;
|
|
//! features + data, ordered by URI
|
|
std::map<std::string_view, void*> m_featureByUri;
|
|
};
|
|
|
|
|
|
} // namespace lmms
|
|
|
|
#endif // LMMS_HAVE_LV2
|
|
|
|
#endif // LMMS_LV2_FEATURES_H
|