mirror of
https://github.com/LMMS/lmms.git
synced 2026-01-20 04:18:18 -05:00
71ce49d7ba
Follow-Up of 7db3fa94a1 .
This was done by setting `CMAKE_C_INCLUDE_WHAT_YOU_USE` and
`CMAKE_CXX_INCLUDE_WHAT_YOU_USE` to (broken down into multiple lines here,
note, all below `FL/x.h` is not required for C):
```
include-what-you-use;
-Xiwyu;--mapping_file=/usr/share/include-what-you-use/qt5_11.imp;
-Xiwyu;--keep=*/xmmintrin.h;
-Xiwyu;--keep=*/lmmsconfig.h;
-Xiwyu;--keep=*/weak_libjack.h;
-Xiwyu;--keep=*/sys/*;
-Xiwyu;--keep=*/debug.h;
-Xiwyu;--keep=*/SDL/*;
-Xiwyu;--keep=*/alsa/*;
-Xiwyu;--keep=*/FL/x.h;
-Xiwyu;--keep=*/MidiApple.h;
-Xiwyu;--keep=*/MidiWinMM.h;
-Xiwyu;--keep=*/AudioSoundIo.h;
-Xiwyu;--keep=*/OpulenZ/adplug/*;
-Xiwyu;--keep=QPainterPath;
-Xiwyu;--keep=QtTest
```
FAQ:
* Q: Does this speed-up a completely fresh compile?
* A: No, I measured it.
* Q: Does it speed up anything else?
* A: Yes. If you change one header, it can reduce the number of CPP files
that your compiler needs to recompile, or your IDE has to re-scan.
* Q: What other reasons are for this PR?
* A: It's idiomatic to only include headers if you need them. Also, it will
reduce output for those who want to use IWYU for new PRs.
Background:
This is just a remainder PR of what I planned. My original idea was to setup
a CI which warns you of useless includes (but not of all issues that IWYU
complains about). However, I could not see that this was favored on Discord.
A full IWYU CI also has the problem that it (possibly??) needs to compile
with `make -j 1`, which would make CI really slow.
However, for that plan, I had to fix the whole code base to be IWYU
compliant - which it now is.
136 lines
3.4 KiB
C++
136 lines
3.4 KiB
C++
/*
|
|
* MixerView.h - effect-mixer-view for LMMS
|
|
*
|
|
* Copyright (c) 2008-2014 Tobias Doerffel <tobydox/at/users.sourceforge.net>
|
|
*
|
|
* This file is part of LMMS - https://lmms.io
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public
|
|
* License along with this program (see COPYING); if not, write to the
|
|
* Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
|
|
* Boston, MA 02110-1301 USA.
|
|
*
|
|
*/
|
|
|
|
#ifndef LMMS_GUI_MIXER_VIEW_H
|
|
#define LMMS_GUI_MIXER_VIEW_H
|
|
|
|
#include <QWidget>
|
|
|
|
#include "MixerChannelView.h"
|
|
#include "ModelView.h"
|
|
#include "SerializingObject.h"
|
|
|
|
class QDomDocument; // IWYU pragma: keep
|
|
class QDomElement; // IWYU pragma: keep
|
|
class QHBoxLayout;
|
|
class QStackedLayout;
|
|
class QScrollArea;
|
|
|
|
namespace lmms
|
|
{
|
|
class Mixer;
|
|
}
|
|
|
|
namespace lmms::gui
|
|
{
|
|
class LMMS_EXPORT MixerView : public QWidget, public ModelView,
|
|
public SerializingObjectHook
|
|
{
|
|
Q_OBJECT
|
|
public:
|
|
MixerView(Mixer* mixer);
|
|
void keyPressEvent(QKeyEvent* e) override;
|
|
|
|
void saveSettings(QDomDocument& doc, QDomElement& domElement) override;
|
|
void loadSettings(const QDomElement& domElement) override;
|
|
|
|
inline MixerChannelView* currentMixerChannel()
|
|
{
|
|
return m_currentMixerChannel;
|
|
}
|
|
|
|
inline MixerChannelView* channelView(int index)
|
|
{
|
|
return m_mixerChannelViews[index];
|
|
}
|
|
|
|
|
|
void setCurrentMixerChannel(MixerChannelView* channel);
|
|
void setCurrentMixerChannel(int channel);
|
|
|
|
void clear();
|
|
|
|
|
|
// display the send button and knob correctly
|
|
void updateMixerChannel(int index);
|
|
|
|
// notify the view that a mixer channel was deleted
|
|
void deleteChannel(int index);
|
|
|
|
// delete all unused channels
|
|
void deleteUnusedChannels();
|
|
|
|
// move the channel to the left or right
|
|
void moveChannelLeft(int index);
|
|
void moveChannelLeft(int index, int focusIndex);
|
|
void moveChannelRight(int index);
|
|
|
|
void renameChannel(int index);
|
|
|
|
// make sure the display syncs up with the mixer.
|
|
// useful for loading projects
|
|
void refreshDisplay();
|
|
|
|
public slots:
|
|
int addNewChannel();
|
|
|
|
protected:
|
|
void closeEvent(QCloseEvent* ce) override;
|
|
|
|
private slots:
|
|
void updateFaders();
|
|
// TODO This should be improved. Currently the solo and mute models are connected via
|
|
// the MixerChannelView's constructor with the MixerView. It would already be an improvement
|
|
// if the MixerView connected itself to each new MixerChannel that it creates/handles.
|
|
void toggledSolo();
|
|
void toggledMute();
|
|
|
|
private:
|
|
Mixer* getMixer() const;
|
|
void updateAllMixerChannels();
|
|
void connectToSoloAndMute(int channelIndex);
|
|
void disconnectFromSoloAndMute(int channelIndex);
|
|
|
|
private:
|
|
QVector<MixerChannelView*> m_mixerChannelViews;
|
|
|
|
MixerChannelView* m_currentMixerChannel;
|
|
|
|
QScrollArea* channelArea;
|
|
QHBoxLayout* chLayout;
|
|
QWidget* m_channelAreaWidget;
|
|
QStackedLayout* m_racksLayout;
|
|
QWidget* m_racksWidget;
|
|
Mixer* m_mixer;
|
|
|
|
void updateMaxChannelSelector();
|
|
|
|
friend class MixerChannelView;
|
|
} ;
|
|
|
|
|
|
} // namespace lmms::gui
|
|
|
|
#endif // LMMS_GUI_MIXER_VIEW_H
|