mirror of
https://github.com/LMMS/lmms.git
synced 2025-12-23 22:58:33 -05:00
41093efcbe
Prior to commitb5de1d50e, audible zipper artifacts were present when using the PeakController on a bus to control the volume of another bus for sidechain compression. The bus that had its volume reduced was the one which produced audible artifacts. Commitb5de1d50eintroduced LERP to PeakController to smooth out its signal, which eliminated the zipper artifacts. However, this had the side effect of increased latency even when both attack and decay settings were set to zero. Until a more robust solution is implemented, reverting this change eliminates the latency by eliminating the lerp, but reintroduces audible zipper artifacts.
111 lines
2.6 KiB
C++
111 lines
2.6 KiB
C++
/*
|
|
* PeakController.h - peak-controller class
|
|
*
|
|
* Copyright (c) 2008-2009 Paul Giblock <drfaygo/at/gmail.com>
|
|
*
|
|
* This file is part of LMMS - https://lmms.io
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public
|
|
* License along with this program (see COPYING); if not, write to the
|
|
* Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
|
|
* Boston, MA 02110-1301 USA.
|
|
*
|
|
*/
|
|
|
|
#ifndef LMMS_PEAK_CONTROLLER_H
|
|
#define LMMS_PEAK_CONTROLLER_H
|
|
|
|
#include "Controller.h"
|
|
#include "ControllerDialog.h"
|
|
|
|
class QWidget;
|
|
|
|
namespace lmms
|
|
{
|
|
|
|
|
|
class PeakControllerEffect;
|
|
|
|
using PeakControllerEffectVector = std::vector<PeakControllerEffect*>;
|
|
|
|
class LMMS_EXPORT PeakController : public Controller
|
|
{
|
|
Q_OBJECT
|
|
public:
|
|
PeakController( Model * _parent,
|
|
PeakControllerEffect *_peak_effect = nullptr );
|
|
|
|
|
|
~PeakController() override;
|
|
|
|
void saveSettings( QDomDocument & _doc, QDomElement & _this ) override;
|
|
void loadSettings( const QDomElement & _this ) override;
|
|
QString nodeName() const override;
|
|
|
|
static void initGetControllerBySetting();
|
|
static PeakController * getControllerBySetting( const QDomElement & _this );
|
|
|
|
static PeakControllerEffectVector s_effects;
|
|
|
|
|
|
public slots:
|
|
gui::ControllerDialog * createDialog( QWidget * _parent ) override;
|
|
void handleDestroyedEffect();
|
|
void updateCoeffs();
|
|
|
|
protected:
|
|
// The internal per-controller get-value function
|
|
void updateValueBuffer() override;
|
|
|
|
PeakControllerEffect * m_peakEffect;
|
|
|
|
friend class PeakControllerDialog;
|
|
|
|
private:
|
|
float m_currentSample;
|
|
//backward compatibility for <= 0.4.15
|
|
static int m_getCount;
|
|
static int m_loadCount;
|
|
static bool m_buggedFile;
|
|
|
|
float m_attackCoeff;
|
|
float m_decayCoeff;
|
|
bool m_coeffNeedsUpdate;
|
|
} ;
|
|
|
|
namespace gui
|
|
{
|
|
|
|
class PeakControllerDialog : public ControllerDialog
|
|
{
|
|
Q_OBJECT
|
|
public:
|
|
PeakControllerDialog( Controller * _controller, QWidget * _parent );
|
|
~PeakControllerDialog() override = default;
|
|
|
|
protected:
|
|
void contextMenuEvent( QContextMenuEvent * _me ) override;
|
|
void paintEvent( QPaintEvent * _pe ) override;
|
|
void modelChanged() override;
|
|
|
|
PeakController * m_peakController;
|
|
|
|
};
|
|
|
|
|
|
} // namespace gui
|
|
|
|
} // namespace lmms
|
|
|
|
#endif // LMMS_PEAK_CONTROLLER_H
|