mirror of
https://github.com/LMMS/lmms.git
synced 2026-01-16 18:38:15 -05:00
4a089a19dc
* use c++ std::* math functions This updates usages of sin, cos, tan, pow, exp, log, log10, sqrt, fmod, fabs, and fabsf, excluding any usages that look like they might be part of a submodule or 3rd-party code. There's probably some std math functions not listed here that haven't been updated yet. * fix std::sqrt typo lmao one always sneaks by * Apply code review suggestions - std::pow(2, x) -> std::exp2(x) - std::pow(10, x) -> lmms::fastPow10f(x) - std::pow(x, 2) -> x * x, std::pow(x, 3) -> x * x * x, etc. - Resolve TODOs, fix typos, and so forth Co-authored-by: Rossmaxx <74815851+Rossmaxx@users.noreply.github.com> * Fix double -> float truncation, DrumSynth fix I mistakenly introduced a bug in my recent PR regarding template constants, in which a -1 that was supposed to appear outside of an abs() instead was moved inside it, screwing up the generated waveform. I fixed that and also simplified the function by factoring out the phase domain wrapping using the new `ediv()` function from this PR. It should behave how it's supposed to now... assuming all my parentheses are in the right place lol * Annotate magic numbers with TODOs for C++20 * On second thought, why wait? What else is lmms::numbers for? * begone inline Co-authored-by: Rossmaxx <74815851+Rossmaxx@users.noreply.github.com> * begone other inline Co-authored-by: Rossmaxx <74815851+Rossmaxx@users.noreply.github.com> * Re-inline function in lmms_math.h For functions, constexpr implies inline so this just re-adds inline to the one that isn't constexpr yet * Formatting fixes, readability improvements Co-authored-by: Dalton Messmer <messmer.dalton@gmail.com> * Fix previously missed pow() calls, cleanup Co-authored-by: Dalton Messmer <messmer.dalton@gmail.com> * Just delete ediv() entirely lmao No ediv(), no std::fmod(), no std::remainder(), just std::floor(). It should all work for negative phase inputs as well. If I end up needing ediv() in the future, I can add it then. * Simplify DrumSynth triangle waveform This reuses more work and is also a lot more easy to visualize. It's probably a meaningless micro-optimization, but it might be worth changing it back to a switch-case and just calculating ph_tau and saw01 at the beginning of the function in all code paths, even if it goes unused for the first two cases. Guess I'll see if anybody has strong opinions about it. * Move multiplication inside abs() * Clean up a few more pow(x, 2) -> x * x * Remove numbers::inv_pi, numbers::inv_tau * delete spooky leading 0 Co-authored-by: Dalton Messmer <messmer.dalton@gmail.com> --------- Co-authored-by: Rossmaxx <74815851+Rossmaxx@users.noreply.github.com> Co-authored-by: Dalton Messmer <messmer.dalton@gmail.com>
102 lines
2.0 KiB
C++
102 lines
2.0 KiB
C++
/*
|
|
* RmsHelper.h - helper class for calculating RMS
|
|
*
|
|
* Copyright (c) 2014 Vesa Kivimäki <contact/dot/diizy/at/nbl/dot/fi>
|
|
* Copyright (c) 2008 Tobias Doerffel <tobydox/at/users.sourceforge.net>
|
|
*
|
|
* This file is part of LMMS - https://lmms.io
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public
|
|
* License along with this program (see COPYING); if not, write to the
|
|
* Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
|
|
* Boston, MA 02110-1301 USA.
|
|
*
|
|
*/
|
|
|
|
#ifndef LMMS_RMS_HELPER_H
|
|
#define LMMS_RMS_HELPER_H
|
|
|
|
#include "lmms_math.h"
|
|
|
|
|
|
namespace lmms
|
|
{
|
|
|
|
|
|
class RmsHelper
|
|
{
|
|
public:
|
|
RmsHelper(std::size_t size) :
|
|
m_buffer( nullptr )
|
|
{
|
|
setSize( size );
|
|
}
|
|
virtual ~RmsHelper()
|
|
{
|
|
if( m_buffer ) delete[] m_buffer;
|
|
}
|
|
|
|
void setSize(std::size_t size)
|
|
{
|
|
if( m_buffer )
|
|
{
|
|
if( m_size < size )
|
|
{
|
|
delete m_buffer;
|
|
m_buffer = new float[ size ];
|
|
m_size = size;
|
|
reset();
|
|
}
|
|
else
|
|
{
|
|
m_size = size;
|
|
reset();
|
|
}
|
|
}
|
|
else
|
|
{
|
|
m_buffer = new float[ size ];
|
|
m_size = size;
|
|
reset();
|
|
}
|
|
}
|
|
|
|
inline void reset()
|
|
{
|
|
m_sizef = 1.0f / (float) m_size;
|
|
m_pos = 0;
|
|
m_sum = 0.0f;
|
|
memset( m_buffer, 0, m_size * sizeof( float ) );
|
|
}
|
|
|
|
inline float update( const float in )
|
|
{
|
|
m_sum -= m_buffer[ m_pos ];
|
|
m_sum += m_buffer[ m_pos ] = in * in;
|
|
++m_pos %= m_size;
|
|
return std::sqrt(m_sum * m_sizef);
|
|
}
|
|
|
|
private:
|
|
float * m_buffer;
|
|
float m_sum;
|
|
std::size_t m_pos;
|
|
std::size_t m_size;
|
|
float m_sizef;
|
|
};
|
|
|
|
|
|
} // namespace lmms
|
|
|
|
#endif // LMMS_RMS_HELPER_H
|