mirror of
https://github.com/LMMS/lmms.git
synced 2026-06-08 14:16:07 -04:00
Fixes bugs where during project loading (observed with VST effects), empty widgets and sub-windows would be left floating around. These were caused by inconsistencies between the way VST UIs were created when loading a project and when adding an effect in an existing project. In some situations, this caused createUI to be called twice, leaving over multiple empty widgets. This commit refactors some code in order to avoid creating unnecessary sub- windows, which aren't needed with VST effects, but were still created, usually being invisible. All sub-window related code was moved out of VstPlugin into vestige.cpp, which is the only place where sub-window VSTs are actually used. A new sub-class of VstPlugin, VstInstrumentPlugin, now handles VST sub-windows and is used by vestigeInstrument. "guivisible" attribute loading was moved out of VstPlugin as well and is now done in VstEffectControls' and vestigeInstrument's loadSettings method respectively. This causes some minor code duplication unfortunately. Closes #4110
546 lines
13 KiB
C++
546 lines
13 KiB
C++
/*
|
|
* VstEffectControls.cpp - controls for VST effect plugins
|
|
*
|
|
* Copyright (c) 2008-2014 Tobias Doerffel <tobydox/at/users.sourceforge.net>
|
|
*
|
|
* This file is part of LMMS - https://lmms.io
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public
|
|
* License along with this program (see COPYING); if not, write to the
|
|
* Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
|
|
* Boston, MA 02110-1301 USA.
|
|
*
|
|
*/
|
|
|
|
#include <QDomElement>
|
|
|
|
#include "VstEffectControls.h"
|
|
#include "VstEffect.h"
|
|
|
|
#include "MainWindow.h"
|
|
#include "GuiApplication.h"
|
|
#include <QMdiArea>
|
|
#include <QApplication>
|
|
|
|
|
|
|
|
VstEffectControls::VstEffectControls( VstEffect * _eff ) :
|
|
EffectControls( _eff ),
|
|
m_effect( _eff ),
|
|
m_subWindow( NULL ),
|
|
knobFModel( NULL ),
|
|
ctrHandle( NULL ),
|
|
lastPosInMenu (0),
|
|
m_vstGuiVisible ( true )
|
|
// m_presetLabel ( NULL )
|
|
{
|
|
}
|
|
|
|
|
|
|
|
|
|
VstEffectControls::~VstEffectControls()
|
|
{
|
|
delete ctrHandle;
|
|
ctrHandle = NULL;
|
|
}
|
|
|
|
|
|
|
|
|
|
void VstEffectControls::loadSettings( const QDomElement & _this )
|
|
{
|
|
//m_effect->closePlugin();
|
|
//m_effect->openPlugin( _this.attribute( "plugin" ) );
|
|
m_effect->m_pluginMutex.lock();
|
|
if( m_effect->m_plugin != NULL )
|
|
{
|
|
m_vstGuiVisible = _this.attribute( "guivisible" ).toInt();
|
|
|
|
m_effect->m_plugin->loadSettings( _this );
|
|
|
|
const QMap<QString, QString> & dump = m_effect->m_plugin->parameterDump();
|
|
paramCount = dump.size();
|
|
char paramStr[35];
|
|
knobFModel = new FloatModel *[ paramCount ];
|
|
QStringList s_dumpValues;
|
|
for( int i = 0; i < paramCount; i++ )
|
|
{
|
|
sprintf( paramStr, "param%d", i );
|
|
s_dumpValues = dump[ paramStr ].split( ":" );
|
|
|
|
knobFModel[i] = new FloatModel( 0.0f, 0.0f, 1.0f, 0.01f, this, QString::number(i) );
|
|
knobFModel[i]->loadSettings( _this, paramStr );
|
|
|
|
if( !( knobFModel[ i ]->isAutomated() ||
|
|
knobFModel[ i ]->controllerConnection() ) )
|
|
{
|
|
knobFModel[ i ]->setValue( (s_dumpValues.at( 2 ) ).toFloat() );
|
|
knobFModel[ i ]->setInitValue( (s_dumpValues.at( 2 ) ).toFloat() );
|
|
}
|
|
|
|
connect( knobFModel[i], SIGNAL( dataChanged() ), this, SLOT( setParameter() ) );
|
|
}
|
|
|
|
}
|
|
m_effect->m_pluginMutex.unlock();
|
|
}
|
|
|
|
|
|
|
|
|
|
void VstEffectControls::setParameter( void )
|
|
{
|
|
|
|
Model *action = qobject_cast<Model *>(sender());
|
|
int knobUNID = action->displayName().toInt();
|
|
|
|
if ( m_effect->m_plugin != NULL ) {
|
|
m_effect->m_plugin->setParam( knobUNID, knobFModel[knobUNID]->value() );
|
|
}
|
|
}
|
|
|
|
|
|
|
|
|
|
void VstEffectControls::saveSettings( QDomDocument & _doc, QDomElement & _this )
|
|
{
|
|
_this.setAttribute( "plugin", m_effect->m_key.attributes["file"] );
|
|
m_effect->m_pluginMutex.lock();
|
|
if( m_effect->m_plugin != NULL )
|
|
{
|
|
m_effect->m_plugin->saveSettings( _doc, _this );
|
|
if (knobFModel != NULL) {
|
|
const QMap<QString, QString> & dump = m_effect->m_plugin->parameterDump();
|
|
paramCount = dump.size();
|
|
char paramStr[35];
|
|
for( int i = 0; i < paramCount; i++ )
|
|
{
|
|
if (knobFModel[i]->isAutomated() || knobFModel[i]->controllerConnection()) {
|
|
sprintf( paramStr, "param%d", i);
|
|
knobFModel[i]->saveSettings( _doc, _this, paramStr );
|
|
}
|
|
}
|
|
}
|
|
}
|
|
m_effect->m_pluginMutex.unlock();
|
|
}
|
|
|
|
|
|
|
|
|
|
int VstEffectControls::controlCount()
|
|
{
|
|
return m_effect->m_plugin != NULL &&
|
|
m_effect->m_plugin->hasEditor() ? 1 : 0;
|
|
}
|
|
|
|
|
|
|
|
EffectControlDialog *VstEffectControls::createView()
|
|
{
|
|
auto dialog = new VstEffectControlDialog( this );
|
|
dialog->togglePluginUI( m_vstGuiVisible );
|
|
return dialog;
|
|
}
|
|
|
|
|
|
|
|
|
|
void VstEffectControls::managePlugin( void )
|
|
{
|
|
if ( m_effect->m_plugin != NULL && m_subWindow == NULL ) {
|
|
manageVSTEffectView * tt = new manageVSTEffectView( m_effect, this);
|
|
ctrHandle = (QObject *)tt;
|
|
} else if (m_subWindow != NULL) {
|
|
if (m_subWindow->widget()->isVisible() == false ) {
|
|
m_scrollArea->show();
|
|
m_subWindow->show();
|
|
} else {
|
|
m_scrollArea->hide();
|
|
m_subWindow->hide();
|
|
}
|
|
}
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
void VstEffectControls::savePreset( void )
|
|
{
|
|
|
|
if ( m_effect->m_plugin != NULL ) {
|
|
m_effect->m_plugin->savePreset( );
|
|
/* bool converted;
|
|
QString str = m_vi->m_plugin->currentProgramName().section("/", 0, 0);
|
|
if (str != "")
|
|
lastPosInMenu = str.toInt(&converted, 10) - 1;
|
|
QWidget::update();*/
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void VstEffectControls::updateMenu( void )
|
|
{
|
|
|
|
// get all presets -
|
|
if ( m_effect->m_plugin != NULL )
|
|
{
|
|
m_effect->m_plugin->loadProgramNames();
|
|
///QWidget::update();
|
|
|
|
QString str = m_effect->m_plugin->allProgramNames();
|
|
|
|
QStringList list1 = str.split("|");
|
|
|
|
QMenu * to_menu = m_selPresetButton->menu();
|
|
to_menu->clear();
|
|
|
|
QAction *presetActions[list1.size()];
|
|
|
|
for (int i = 0; i < list1.size(); i++) {
|
|
presetActions[i] = new QAction(this);
|
|
connect(presetActions[i], SIGNAL(triggered()), this, SLOT(selPreset()));
|
|
|
|
presetActions[i]->setText(QString("%1. %2").arg(QString::number(i+1), list1.at(i)));
|
|
presetActions[i]->setData(i);
|
|
if (i == lastPosInMenu) {
|
|
presetActions[i]->setIcon(embed::getIconPixmap( "sample_file", 16, 16 ));
|
|
} else presetActions[i]->setIcon(embed::getIconPixmap( "edit_copy", 16, 16 ));
|
|
to_menu->addAction( presetActions[i] );
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void VstEffectControls::openPreset( void )
|
|
{
|
|
|
|
if ( m_effect->m_plugin != NULL ) {
|
|
m_effect->m_plugin->openPreset( );
|
|
bool converted;
|
|
QString str = m_effect->m_plugin->currentProgramName().section("/", 0, 0);
|
|
if (str != "")
|
|
lastPosInMenu = str.toInt(&converted, 10) - 1;
|
|
//QWidget::update();
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void VstEffectControls::rollPreset( void )
|
|
{
|
|
|
|
if ( m_effect->m_plugin != NULL ) {
|
|
m_effect->m_plugin->rotateProgram( 1 );
|
|
bool converted;
|
|
QString str = m_effect->m_plugin->currentProgramName().section("/", 0, 0);
|
|
if (str != "")
|
|
lastPosInMenu = str.toInt(&converted, 10) - 1;
|
|
//QWidget::update();
|
|
}
|
|
}
|
|
|
|
|
|
|
|
|
|
void VstEffectControls::rolrPreset( void )
|
|
{
|
|
|
|
if ( m_effect->m_plugin != NULL ) {
|
|
m_effect->m_plugin->rotateProgram( -1 );
|
|
bool converted;
|
|
QString str = m_effect->m_plugin->currentProgramName().section("/", 0, 0);
|
|
if (str != "")
|
|
lastPosInMenu = str.toInt(&converted, 10) - 1;
|
|
//QWidget::update();
|
|
}
|
|
}
|
|
|
|
|
|
|
|
|
|
void VstEffectControls::selPreset( void )
|
|
{
|
|
|
|
QAction *action = qobject_cast<QAction *>(sender());
|
|
if (action)
|
|
if ( m_effect->m_plugin != NULL ) {
|
|
lastPosInMenu = action->data().toInt();
|
|
m_effect->m_plugin->setProgram( lastPosInMenu );
|
|
//QWidget::update();
|
|
}
|
|
}
|
|
|
|
|
|
|
|
|
|
void VstEffectControls::paintEvent( QPaintEvent * )
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
manageVSTEffectView::manageVSTEffectView( VstEffect * _eff, VstEffectControls * m_vi ) :
|
|
m_effect( _eff )
|
|
{
|
|
m_vi2 = m_vi;
|
|
widget = new QWidget();
|
|
m_vi->m_scrollArea = new QScrollArea( widget );
|
|
l = new QGridLayout( widget );
|
|
|
|
m_vi->m_subWindow = gui->mainWindow()->addWindowedWidget(NULL, Qt::SubWindow |
|
|
Qt::CustomizeWindowHint | Qt::WindowTitleHint | Qt::WindowSystemMenuHint);
|
|
m_vi->m_subWindow->setSizePolicy( QSizePolicy::Fixed, QSizePolicy::Fixed );
|
|
m_vi->m_subWindow->setFixedSize( 960, 300);
|
|
m_vi->m_subWindow->setWidget(m_vi->m_scrollArea);
|
|
m_vi->m_subWindow->setWindowTitle( _eff->m_plugin->name() + tr( " - VST parameter control" ) );
|
|
m_vi->m_subWindow->setWindowIcon( PLUGIN_NAME::getIconPixmap( "logo" ) );
|
|
//m_vi->m_subWindow->setAttribute(Qt::WA_DeleteOnClose);
|
|
|
|
|
|
l->setContentsMargins( 20, 10, 10, 10 );
|
|
l->setVerticalSpacing( 10 );
|
|
l->setHorizontalSpacing( 23 );
|
|
|
|
m_syncButton = new QPushButton( tr( "VST Sync" ), widget );
|
|
connect( m_syncButton, SIGNAL( clicked() ), this,
|
|
SLOT( syncPlugin() ) );
|
|
m_syncButton->setWhatsThis(
|
|
tr( "Click here if you want to synchronize all parameters with VST plugin." ) );
|
|
|
|
l->addWidget( m_syncButton, 0, 0, 1, 2, Qt::AlignLeft );
|
|
|
|
m_displayAutomatedOnly = new QPushButton( tr( "Automated" ), widget );
|
|
connect( m_displayAutomatedOnly, SIGNAL( clicked() ), this,
|
|
SLOT( displayAutomatedOnly() ) );
|
|
m_displayAutomatedOnly->setWhatsThis(
|
|
tr( "Click here if you want to display automated parameters only." ) );
|
|
|
|
l->addWidget( m_displayAutomatedOnly, 0, 1, 1, 2, Qt::AlignLeft );
|
|
|
|
|
|
m_closeButton = new QPushButton( tr( " Close " ), widget );
|
|
connect( m_closeButton, SIGNAL( clicked() ), this,
|
|
SLOT( closeWindow() ) );
|
|
m_closeButton->setWhatsThis(
|
|
tr( "Close VST effect knob-controller window." ) );
|
|
|
|
l->addWidget( m_closeButton, 0, 2, 1, 7, Qt::AlignLeft );
|
|
|
|
|
|
for( int i = 0; i < 10; i++ )
|
|
{
|
|
l->addItem( new QSpacerItem( 68, 45, QSizePolicy::Fixed, QSizePolicy::Fixed ), 0, i );
|
|
}
|
|
|
|
const QMap<QString, QString> & dump = m_effect->m_plugin->parameterDump();
|
|
m_vi->paramCount = dump.size();
|
|
|
|
vstKnobs = new Knob *[ m_vi->paramCount ];
|
|
|
|
bool hasKnobModel = true;
|
|
if (m_vi->knobFModel == NULL) {
|
|
m_vi->knobFModel = new FloatModel *[ m_vi->paramCount ];
|
|
hasKnobModel = false;
|
|
}
|
|
|
|
char paramStr[35];
|
|
QStringList s_dumpValues;
|
|
|
|
for( int i = 0; i < m_vi->paramCount; i++ )
|
|
{
|
|
sprintf( paramStr, "param%d", i);
|
|
s_dumpValues = dump[ paramStr ].split( ":" );
|
|
|
|
vstKnobs[ i ] = new Knob( knobBright_26, widget, s_dumpValues.at( 1 ) );
|
|
vstKnobs[ i ]->setHintText( s_dumpValues.at( 1 ) + ":", "" );
|
|
vstKnobs[ i ]->setLabel( s_dumpValues.at( 1 ).left( 15 ) );
|
|
|
|
if( !hasKnobModel )
|
|
{
|
|
sprintf( paramStr, "%d", i);
|
|
m_vi->knobFModel[ i ] = new FloatModel( ( s_dumpValues.at( 2 ) ).toFloat(),
|
|
0.0f, 1.0f, 0.01f, _eff, tr( paramStr ) );
|
|
}
|
|
connect( m_vi->knobFModel[ i ], SIGNAL( dataChanged() ), this,
|
|
SLOT( setParameter() ) );
|
|
vstKnobs[ i ] ->setModel( m_vi->knobFModel[ i ] );
|
|
}
|
|
|
|
int i = 0;
|
|
for( int lrow = 1; lrow < ( int( m_vi->paramCount / 10 ) + 1 ) + 1; lrow++ )
|
|
{
|
|
for( int lcolumn = 0; lcolumn < 10; lcolumn++ )
|
|
{
|
|
if( i < m_vi->paramCount )
|
|
{
|
|
l->addWidget( vstKnobs[i], lrow, lcolumn, Qt::AlignCenter );
|
|
}
|
|
i++;
|
|
}
|
|
}
|
|
|
|
l->setRowStretch( ( int( m_vi->paramCount / 10 ) + 1 ), 1 );
|
|
l->setColumnStretch( 10, 1 );
|
|
|
|
widget->setLayout(l);
|
|
widget->setAutoFillBackground(true);
|
|
|
|
m_vi->m_scrollArea->setVerticalScrollBarPolicy( Qt::ScrollBarAlwaysOn );
|
|
m_vi->m_scrollArea->setHorizontalScrollBarPolicy( Qt::ScrollBarAlwaysOff );
|
|
m_vi->m_scrollArea->setPalette( QApplication::palette( m_vi->m_scrollArea ) );
|
|
m_vi->m_scrollArea->setMinimumHeight( 64 );
|
|
|
|
m_vi->m_scrollArea->setWidget( widget );
|
|
|
|
m_vi->m_subWindow->show();
|
|
}
|
|
|
|
|
|
|
|
|
|
void manageVSTEffectView::closeWindow()
|
|
{
|
|
m_vi2->m_subWindow->hide();
|
|
}
|
|
|
|
|
|
|
|
|
|
void manageVSTEffectView::syncPlugin( void )
|
|
{
|
|
char paramStr[35];
|
|
QStringList s_dumpValues;
|
|
const QMap<QString, QString> & dump = m_effect->m_plugin->parameterDump();
|
|
float f_value;
|
|
|
|
for( int i = 0; i < m_vi2->paramCount; i++ )
|
|
{
|
|
// only not automated knobs are synced from VST
|
|
// those auto-setted values are not jurnaled, tracked for undo / redo
|
|
if( !( m_vi2->knobFModel[ i ]->isAutomated() ||
|
|
m_vi2->knobFModel[ i ]->controllerConnection() ) )
|
|
{
|
|
sprintf( paramStr, "param%d", i );
|
|
s_dumpValues = dump[ paramStr ].split( ":" );
|
|
f_value = ( s_dumpValues.at( 2 ) ).toFloat();
|
|
m_vi2->knobFModel[ i ]->setAutomatedValue( f_value );
|
|
m_vi2->knobFModel[ i ]->setInitValue( f_value );
|
|
}
|
|
}
|
|
}
|
|
|
|
|
|
|
|
void manageVSTEffectView::displayAutomatedOnly( void )
|
|
{
|
|
bool isAuto = QString::compare( m_displayAutomatedOnly->text(), tr( "Automated" ) ) == 0;
|
|
|
|
for( int i = 0; i< m_vi2->paramCount; i++ )
|
|
{
|
|
|
|
if( !( m_vi2->knobFModel[ i ]->isAutomated() ||
|
|
m_vi2->knobFModel[ i ]->controllerConnection() ) )
|
|
{
|
|
if( vstKnobs[ i ]->isVisible() == true && isAuto )
|
|
{
|
|
vstKnobs[ i ]->hide();
|
|
m_displayAutomatedOnly->setText( "All" );
|
|
} else {
|
|
vstKnobs[ i ]->show();
|
|
m_displayAutomatedOnly->setText( "Automated" );
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
|
|
|
|
|
|
void manageVSTEffectView::setParameter( void )
|
|
{
|
|
|
|
Model *action = qobject_cast<Model *>(sender());
|
|
int knobUNID = action->displayName().toInt();
|
|
|
|
if ( m_effect->m_plugin != NULL ) {
|
|
m_effect->m_plugin->setParam( knobUNID, m_vi2->knobFModel[knobUNID]->value() );
|
|
}
|
|
}
|
|
|
|
|
|
|
|
|
|
manageVSTEffectView::~manageVSTEffectView()
|
|
{
|
|
if( m_vi2->knobFModel != NULL )
|
|
{
|
|
for( int i = 0; i < m_vi2->paramCount; i++ )
|
|
{
|
|
delete m_vi2->knobFModel[ i ];
|
|
delete vstKnobs[ i ];
|
|
}
|
|
}
|
|
|
|
if( vstKnobs != NULL )
|
|
{
|
|
delete [] vstKnobs;
|
|
vstKnobs = NULL;
|
|
}
|
|
|
|
if( m_vi2->knobFModel != NULL )
|
|
{
|
|
delete [] m_vi2->knobFModel;
|
|
m_vi2->knobFModel = NULL;
|
|
}
|
|
|
|
if( m_vi2->m_scrollArea != NULL )
|
|
{
|
|
delete m_vi2->m_scrollArea;
|
|
m_vi2->m_scrollArea = NULL;
|
|
}
|
|
|
|
if( m_vi2->m_subWindow != NULL )
|
|
{
|
|
m_vi2->m_subWindow->setAttribute( Qt::WA_DeleteOnClose );
|
|
m_vi2->m_subWindow->close();
|
|
|
|
if( m_vi2->m_subWindow != NULL )
|
|
{
|
|
delete m_vi2->m_subWindow;
|
|
}
|
|
m_vi2->m_subWindow = NULL;
|
|
}
|
|
//delete m_vi2->m_subWindow;
|
|
//m_vi2->m_subWindow = NULL;
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
|