mirror of
https://github.com/LMMS/lmms.git
synced 2026-06-02 03:06:48 -04:00
98bc0d60e8
Bugs fixed: 1. Doubled tooltips on some Knobs (see #8358) 2. No dynamic floating text when dragging a Fader (regression from #8253) 3. Volume knobs displaying their units as "dBFS%" rather than just "dBFS" (regression from #8253) 4. Incorrect dBFS value in the dynamic floating text for volume knobs of the Delay and Flanger plugins 5. Incorrect dBFS values in the "Set value" dialog box for volume knobs of the Delay, Dynamics Processor, Flanger, and Wave Shaper plugins 6. Missing "%" unit in the context menu for Vibed's volume knobs 7. Incorrect handling of volume knobs for models that support negative amplitudes (currently only Flanger's feedback amount knob) For (1), I reworked how static tooltips work in FloatModelEditorBase. Rather than use QWidget's tooltips, it shadows the tooltip methods from QWidget and redirects them to the existing SimpleTextFloat-based system. Supporting both "static" and "dynamic" tooltips required some improvements to keep better track of user interactions with the Knobs. There was an existing m_buttonPressed boolean, but this was insufficient, so I converted it into a new InteractionType enum for keeping track of the user interaction state. See the "Expected Behaviour" section of the bug report (#8358) for an explanation of how it works now from the user's perspective.
154 lines
6.2 KiB
C++
154 lines
6.2 KiB
C++
/*
|
|
* DynamicsProcessorControlDialog.cpp - control-dialog for DynamicsProcessor-effect
|
|
*
|
|
* Copyright (c) 2014 Vesa Kivimäki <contact/dot/diizy/at/nbl/dot/fi>
|
|
* Copyright (c) 2006-2008 Tobias Doerffel <tobydox/at/users.sourceforge.net>
|
|
*
|
|
* This file is part of LMMS - https://lmms.io
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public
|
|
* License along with this program (see COPYING); if not, write to the
|
|
* Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
|
|
* Boston, MA 02110-1301 USA.
|
|
*
|
|
*/
|
|
|
|
|
|
|
|
#include "DynamicsProcessorControlDialog.h"
|
|
#include "DynamicsProcessorControls.h"
|
|
#include "embed.h"
|
|
#include "FontHelper.h"
|
|
#include "Graph.h"
|
|
#include "Knob.h"
|
|
#include "PixmapButton.h"
|
|
|
|
namespace lmms::gui
|
|
{
|
|
|
|
|
|
DynProcControlDialog::DynProcControlDialog(
|
|
DynProcControls * _controls ) :
|
|
EffectControlDialog( _controls )
|
|
{
|
|
setAutoFillBackground( true );
|
|
QPalette pal;
|
|
pal.setBrush( backgroundRole(),
|
|
PLUGIN_NAME::getIconPixmap( "artwork" ) );
|
|
setPalette( pal );
|
|
setFixedSize( 224, 319 );
|
|
|
|
auto waveGraph = new Graph(this, Graph::Style::LinearNonCyclic, 204, 205);
|
|
waveGraph -> move( 10, 6 );
|
|
waveGraph -> setModel( &_controls -> m_wavegraphModel );
|
|
waveGraph -> setAutoFillBackground( true );
|
|
pal = QPalette();
|
|
pal.setBrush( backgroundRole(),
|
|
PLUGIN_NAME::getIconPixmap("wavegraph") );
|
|
waveGraph->setPalette( pal );
|
|
waveGraph->setGraphColor( QColor( 85, 204, 145 ) );
|
|
waveGraph -> setMaximumSize( 204, 205 );
|
|
|
|
auto inputKnob = new VolumeKnob(KnobType::Bright26, tr("INPUT"), SMALL_FONT_SIZE, this);
|
|
inputKnob->setZeroDbfsPoint(1.f);
|
|
inputKnob -> move( 26, 223 );
|
|
inputKnob->setModel( &_controls->m_inputModel );
|
|
inputKnob->setHintText( tr( "Input gain:" ) , "" );
|
|
|
|
auto outputKnob = new VolumeKnob(KnobType::Bright26, tr("OUTPUT"), SMALL_FONT_SIZE, this);
|
|
outputKnob->setZeroDbfsPoint(1.f);
|
|
outputKnob -> move( 76, 223 );
|
|
outputKnob->setModel( &_controls->m_outputModel );
|
|
outputKnob->setHintText( tr( "Output gain:" ) , "" );
|
|
|
|
auto attackKnob = new Knob(KnobType::Bright26, tr("ATTACK"), SMALL_FONT_SIZE, this);
|
|
attackKnob -> move( 24, 268 );
|
|
attackKnob->setModel( &_controls->m_attackModel );
|
|
attackKnob->setHintText( tr( "Peak attack time:" ) , "ms" );
|
|
|
|
auto releaseKnob = new Knob(KnobType::Bright26, tr("RELEASE"), SMALL_FONT_SIZE, this);
|
|
releaseKnob -> move( 74, 268 );
|
|
releaseKnob->setModel( &_controls->m_releaseModel );
|
|
releaseKnob->setHintText( tr( "Peak release time:" ) , "ms" );
|
|
|
|
//wavegraph control buttons
|
|
|
|
auto resetButton = new PixmapButton(this, tr("Reset wavegraph"));
|
|
resetButton -> move( 162, 223 );
|
|
resetButton -> resize( 13, 48 );
|
|
resetButton -> setActiveGraphic( PLUGIN_NAME::getIconPixmap( "reset_active" ) );
|
|
resetButton -> setInactiveGraphic( PLUGIN_NAME::getIconPixmap( "reset_inactive" ) );
|
|
resetButton->setToolTip(tr("Reset wavegraph"));
|
|
|
|
auto smoothButton = new PixmapButton(this, tr("Smooth wavegraph"));
|
|
smoothButton -> move( 162, 239 );
|
|
smoothButton -> resize( 13, 48 );
|
|
smoothButton -> setActiveGraphic( PLUGIN_NAME::getIconPixmap( "smooth_active" ) );
|
|
smoothButton -> setInactiveGraphic( PLUGIN_NAME::getIconPixmap( "smooth_inactive" ) );
|
|
smoothButton->setToolTip(tr("Smooth wavegraph"));
|
|
|
|
auto addOneButton = new PixmapButton(this, tr("Increase wavegraph amplitude by 1 dB"));
|
|
addOneButton -> move( 131, 223 );
|
|
addOneButton -> resize( 13, 29 );
|
|
addOneButton -> setActiveGraphic( PLUGIN_NAME::getIconPixmap( "add1_active" ) );
|
|
addOneButton -> setInactiveGraphic( PLUGIN_NAME::getIconPixmap( "add1_inactive" ) );
|
|
addOneButton->setToolTip(tr("Increase wavegraph amplitude by 1 dB"));
|
|
|
|
auto subOneButton = new PixmapButton(this, tr("Decrease wavegraph amplitude by 1 dB"));
|
|
subOneButton -> move( 131, 239 );
|
|
subOneButton -> resize( 13, 29 );
|
|
subOneButton -> setActiveGraphic( PLUGIN_NAME::getIconPixmap( "sub1_active" ) );
|
|
subOneButton -> setInactiveGraphic( PLUGIN_NAME::getIconPixmap( "sub1_inactive" ) );
|
|
subOneButton->setToolTip(tr("Decrease wavegraph amplitude by 1 dB"));
|
|
|
|
//stereomode switches
|
|
auto smMaxButton = new PixmapButton(this, tr("Stereo mode: maximum"));
|
|
smMaxButton -> move( 131, 257 );
|
|
smMaxButton -> resize( 78, 17 );
|
|
smMaxButton -> setActiveGraphic( PLUGIN_NAME::getIconPixmap( "max_active" ) );
|
|
smMaxButton -> setInactiveGraphic( PLUGIN_NAME::getIconPixmap( "max_inactive" ) );
|
|
smMaxButton->setToolTip(tr("Process based on the maximum of both stereo channels"));
|
|
|
|
auto smAvgButton = new PixmapButton(this, tr("Stereo mode: average"));
|
|
smAvgButton -> move( 131, 274 );
|
|
smAvgButton -> resize( 78, 16 );
|
|
smAvgButton -> setActiveGraphic( PLUGIN_NAME::getIconPixmap( "avg_active" ) );
|
|
smAvgButton -> setInactiveGraphic( PLUGIN_NAME::getIconPixmap( "avg_inactive" ) );
|
|
smAvgButton->setToolTip(tr("Process based on the average of both stereo channels"));
|
|
|
|
auto smUnlButton = new PixmapButton(this, tr("Stereo mode: unlinked"));
|
|
smUnlButton -> move( 131, 290 );
|
|
smUnlButton -> resize( 78, 17 );
|
|
smUnlButton -> setActiveGraphic( PLUGIN_NAME::getIconPixmap( "unl_active" ) );
|
|
smUnlButton -> setInactiveGraphic( PLUGIN_NAME::getIconPixmap( "unl_inactive" ) );
|
|
smUnlButton->setToolTip(tr("Process each stereo channel independently"));
|
|
|
|
auto smGroup = new AutomatableButtonGroup(this);
|
|
smGroup -> addButton( smMaxButton );
|
|
smGroup -> addButton( smAvgButton );
|
|
smGroup -> addButton( smUnlButton );
|
|
smGroup -> setModel( &_controls -> m_stereomodeModel );
|
|
|
|
connect( resetButton, SIGNAL (clicked () ),
|
|
_controls, SLOT ( resetClicked() ) );
|
|
connect( smoothButton, SIGNAL (clicked () ),
|
|
_controls, SLOT ( smoothClicked() ) );
|
|
connect( addOneButton, SIGNAL( clicked() ),
|
|
_controls, SLOT( addOneClicked() ) );
|
|
connect( subOneButton, SIGNAL( clicked() ),
|
|
_controls, SLOT( subOneClicked() ) );
|
|
}
|
|
|
|
|
|
} // namespace lmms::gui
|