Fastigium 3c7bfbac64 Replace every use of the foreach macro with a C++11 range-based for loop ...

This prevents a race condition with Qt5. A foreach loop makes a copy of its
Qt container, increasing the reference count to the container's internal
data. Qt5 often asserts isDetached(), which requires the reference count to
be <= 1. This assertion fails when the foreach loop increases the reference
count at exactly the wrong moment. Using a range-based for loop prevents an
unnecessary copy from being made and ensures this race condition isn't
triggered.

2016-03-13 16:09:50 +01:00

4.4 KiB

Raw Blame History

View Raw