Commit Graph

11171 Commits

Author SHA1 Message Date
Mathieu Comandon
ec0421f10a Initial attempt at fix 2026-01-20 23:09:17 -08:00
Mathieu Comandon
fdf62dc8b7 Fix spinner visibility for library sync in sidebar
Add visible=False and no_show_all=True to SidebarRow spinner so that
show_all() calls don't interfere with its visibility control during
library sync operations.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-20 22:24:31 -08:00
Mathieu Comandon
3dba7043a8 Fix KeyError when installing games from disabled services
Use SERVICES instead of get_enabled_services() in Delegate.get_service()
so games can use their associated service regardless of whether it's
enabled in the UI. This fixes a crash when trying to install a game
linked to a service (e.g. humblebundle) that isn't enabled in settings.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-20 22:20:53 -08:00
Daniel Johnson
accbbfc66e Conservatively assume that with no working-dir, Wine will use the prefix (or so it seems) so we'll assume that for the exe-warning.
Resolves #6347 again!
2026-01-19 16:03:52 -05:00
Daniel Johnson
21b6ee7f76 Merge pull request #6350 from ItsAllAboutTheCode/fix-update-advanced-switch-visibility-toggle
Fix typo for update_advanced_switch_visibility
2026-01-19 06:13:42 -05:00
Daniel Johnson
9a6e4bd252 Rework exe-missing warning to cope with ~ paths as well as working-directories.
Even more resolves #6347
2026-01-19 06:11:44 -05:00
Daniel Johnson
ac3cd0d61d Merge pull request #6349 from Zebra2711/fix-9
fix warning `executable file does not exist`
2026-01-19 05:56:49 -05:00
ItsAllAboutTheCode
05664745ca Fix typo for update_advanced_switch_visibility
The `update_advanced_switch_visibility` call in game_common.py:build_header_bar would fail if it was ever called with a non-None `self.notebook` member (currently self.notebook just happens to be `None`) so it no exceptions occur.
2026-01-19 03:25:03 -06:00
Zebra2711
3a0863c795 fix warning executable file does not exist
Resolves #6347
2026-01-19 12:58:38 +07:00
Daniel Johnson
464b17dace Guard against Exherbo specific nonsense better.
Resolves #6346
2026-01-18 17:09:37 -05:00
Daniel Johnson
b5c2101ae4 Let's quote those types so they won't need to be looked up at runtime.
Resolves #6345
2026-01-18 14:14:04 -05:00
Daniel Johnson
23c74afabb Further changelog updates for those PR merges. Spelling not guaranteed. 2026-01-18 10:42:14 -05:00
Daniel Johnson
2c1d122deb Fix more type errors, more cyclical dependencies. 2026-01-18 10:15:05 -05:00
Daniel Johnson
4db73cfede Fix incorrect type annotation that creates a cyclical import error. 2026-01-18 10:09:42 -05:00
Mathieu Comandon
f099b82110 Merge PR #6074: Add more type hints to lutris/game.py
Includes mypy fixes for type errors.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-18 06:39:40 -08:00
Mathieu Comandon
d973e8b6c9 Fix mypy errors in type hints PR
- Add config_path variable to avoid Optional[str] issue
- Add explicit dict type annotation for save_config
- Use intermediate variable for section_data to fix indexing

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-18 06:39:35 -08:00
Eikeno
922b772224 fix formatting 2026-01-18 06:37:59 -08:00
Eikeno
c995945ca8 modified to work kwith python3.8 2026-01-18 06:37:59 -08:00
Eikeno
f60ca5f444 Add moretype hints to lutris/game.py
... and a partially for a few other files, to pass checks.

Please let me know if this useful at all, or if there is no need to continue further this task gradually ?
2026-01-18 06:37:59 -08:00
Mathieu Comandon
4b3c1e0744 Fix formatting in wine.py
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-18 06:35:58 -08:00
Vasiliy Stelmachenok
9306070a60 Add option to change the Wine graphics driver (#6084)
* Add option to change the Wine graphics driver

Signed-off-by: Vasiliy Stelmachenok <ventureo@cachyos.org>

* Add options to enable the Wayland and HDR support provided in Proton-GE 10-1.

* Adjust the labels and 'help' texts according to GitHub suggestions.

---------

Signed-off-by: Vasiliy Stelmachenok <ventureo@cachyos.org>
Co-authored-by: Daniel Johnson <danieljohnson2@fastmail.com>
2026-01-18 06:35:33 -08:00
Eikeno
d56ef6c703 fix: change duckstation to reflect upstream (#6098)
new versions (flatpak, appimage) do not accept CLI arguments.
Instead a setup wizzard is run at first launch.

fixes: #6096
2026-01-18 06:34:25 -08:00
Mathieu Comandon
84f155b836 Add type ignore for ssl context lambda
Suppress mypy misc error for ssl._create_default_https_context assignment.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-18 06:30:22 -08:00
Eikeno
b9dd8f8f33 raise error if wine prefix is a broken symlink or unusable (#6029)
* raise error if wine prefix is broken symlink or unusable

currently, in that case, this is not detected and regular startup is attempted; causing
timeout message and lack of feedback via GUI.

This intentionally doesn't try to perform checks regarding the link target itself - could be subject to
separate PR if really needed, but I think just the basic check done here would cover already
enough situationx where it would be actually useful.

For example in my case I use shared wine prefix, and it sometimes happen the link is broken,
because i created it wrongly, or external device it points to is not mounted - and notice that only
due to abnormal startup time and message in console.

With this, the error is reported via GUI with no wait time nor risky attempts to start the game
anyway.

* check moved to prelaunch()

* remove now unneeded code and import

* Revert "remove now unneeded code and import"

This reverts commit 04a0e5fccf.

* remove now unneeded code and import
2026-01-18 06:29:57 -08:00
erri120
1a2c05772a Add download image button to game config screen (#6052)
* Add download image button

* Download and add custom image
2026-01-18 06:22:54 -08:00
Zebra2711
b6c188834f wine: warning when executable file path is invalid (#6103)
When user paste a file path in the Executable field it might contain leading
or trailing whitespace, or be missing the correct path /path/to/___.ex,...

This warning can help new users easily debug and fix such issues

Co-authored-by: Zebra2711 <zebra2711@users.noreply.github.com>
2026-01-18 06:22:45 -08:00
Mathieu Comandon
756d5f0224 Fix linting issues from merged PRs
- Use pop() instead of del for dict key removal (RUF051)
- Sort imports in zoom.py (I001)
- Remove whitespace from blank line in gpu.py (W293)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-18 05:41:19 -08:00
Mathieu Comandon
8ec4f6cff0 Default to GE-Proton when using UMU without explicit PROTONPATH
When UMU is used directly as the wine executable and PROTONPATH isn't
already set, default to "GE-Proton" instead of letting UMU use its own
default. This ensures GE-Proton is used consistently when it's the
configured or fallback wine version.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-18 05:40:53 -08:00
Eikeno
0429ebde29 update version and modify runner to adapt to upstream (#6113)
- make options use '--' to adapt upstream change
- removed surf option as no longer supported
- added option to enable software rendering
- added option to enable fullscreen
- adapated "no sound" option to new syntax
- removed standalone binary URL because:
  - it is very outdated, causing compatibility issues with recent cartridges
  - upstream no longer provides tar.gz linux binary asset, only source code and .deb archives
  - flatpak version is updated and allow keeping most of configurations options we used before

For reference, new supported options are:

    -h, --help        show this help message and exit
    --skip            skip startup animation
    --volume=<int>    global volume value [0-15]
    --cli             console only output
    --fullscreen      enable fullscreen mode
    --vsync           enable VSYNC
    --soft            use software rendering
    --fs=<str>        path to the file system folder
    --scale=<int>     main window scale
    --cmd=<str>       run commands in the console
2026-01-18 05:38:59 -08:00
Zebra2711
259cea078f gamemode: avoid executing gamemoderun when gamemode is not installed (#6025)
from lutris 0.5.8
    * The old versions of gamemode are no longer supported.
    Make sure you have the one that ships with a `gamemoderun` executable.

Co-authored-by: Zebra2711 <zebra2711@users.noreply.github.com>
2026-01-18 05:38:56 -08:00
Eikeno
8972091264 fix : handle escaped double quote in steam account name (#6028)
* handle escape double quote in steam account name

Simply remove the escaped double quotes if found in AccountName or
PersonaName.

Trying to maintain the double quote in final display would need much
more modification in different places, for very little added value.
At least the name is displayed with this changed, instead of '\' as
before.

fixes issue: #5988

* reformatting

ruff now ok

* remove ref to unused AcccountName
2026-01-18 05:38:52 -08:00
Ridai Govinda Pombo
59ceb1888f Exherbo support (#6039)
Co-authored-by: Ridai Govinda Pombo <beholders.eye@disroot.org>
2026-01-18 05:38:49 -08:00
Eikeno
c0b5a08f19 add Azahar runner (#6043)
* add Azahar runner

fixes: #5854

* better handling of version strings

* remove unneeded json file

* updated to release 2120.3

* add flatpak_id to offer running from flatpak if installed

* bump to v2121 and simplify runner to adjust upstream changes in providing appImage file (ural and not zipped anymore).

* Bump appimage version to 2121.2

* bump azahar to version 2122

* bump version to 2122.1

* bump version to 2123

* bump version to 2123.1

* bump version to 2123.2
2026-01-18 05:38:45 -08:00
Eikeno
9b7763019d easyrpg: bump version to 0.8.1 (#6111)
* bump version to 0.8.1

* bump version to 0.8.1.1
2026-01-18 05:38:33 -08:00
Eikeno
829f69298d bump version to 0.10.5 (#6112) 2026-01-18 05:38:27 -08:00
Eikeno
3461e82f5b rmg: bump version to 0.7.9 (#6114)
* bump version to 0.8.8

* bump to latest available version

* Revert "bump to latest available version"

This reverts commit 1cc921cbd5.

* bump version to 0.7.9
2026-01-18 05:38:14 -08:00
Eikeno
8dbe8c7f2e bump to latest available version (#6115)
since current one is ~= 1 y.o this seems required
2026-01-18 05:38:10 -08:00
Eikeno
d959e90ad2 bump version to new stable v5.0 2026-01-18 05:35:10 -08:00
Eikeno
0792697f90 bump version to 4.2.1 2026-01-18 05:35:10 -08:00
blackPanther OS
235a0c2004 Update gpu.py
Error handling resulting from unnecessary imports. 
Referer:
https://github.com/lutris/lutris/issues/5544#issuecomment-2878724077
2026-01-18 05:34:51 -08:00
neuromancer
dfa1173092 lower -> casefold 2026-01-18 05:33:20 -08:00
neuromancer
22dc0345ef small fixes 2026-01-18 05:33:20 -08:00
neuromancer
563b9b9dde applied ruff format 2026-01-18 05:33:20 -08:00
neuromancer
0daa841d7f applied ruff format 2026-01-18 05:33:20 -08:00
neuromancer
4a9aafe141 adapt for the new api 2026-01-18 05:33:20 -08:00
neuromancer
06ebf6ef82 more fixes 2026-01-18 05:33:20 -08:00
neuromancer
bf9ba49b52 make sure size string is lowercase before converting 2026-01-18 05:33:20 -08:00
neuromancer
f853180f86 reverted some zoom specific changes in autosetup_gog_game 2026-01-18 05:33:20 -08:00
neuromancer
1d2b5db4ac refactored and isolated the code used to extract zoom games 2026-01-18 05:33:20 -08:00
neuromancer
8ee83817ae addressed some feedback from the team 2026-01-18 05:33:20 -08:00