mirror/matrix-rust-sdk
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-rust-sdk.git synced 2026-05-18 13:40:55 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor(ui): Rename ObservableItems::clone to clone_items.

Browse Source
This commit is contained in:
Ivan Enderlin
2024-12-09 16:37:07 +01:00
parent 0d17ea353f
commit 0f2ada0958
2 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
crates/matrix-sdk-ui/src/timeline/controller/mod.rs
View File

@@ -467,7 +467,7 @@ impl<P: RoomDataProvider> TimelineController<P> {
///
/// Cheap because `im::Vector` is cheap to clone.
pub(super) async fn items(&self) -> Vector<Arc<TimelineItem>> {
self.state.read().await.items.clone()
self.state.read().await.items.clone_items()
}
pub(super) async fn subscribe(
@@ -475,7 +475,7 @@ impl<P: RoomDataProvider> TimelineController<P> {
) -> (Vector<Arc<TimelineItem>>, impl Stream<Item = VectorDiff<Arc<TimelineItem>>> + Send) {
trace!("Creating timeline items signal");
let state = self.state.read().await;
(state.items.clone(), state.items.subscribe().into_stream())
(state.items.clone_items(), state.items.subscribe().into_stream())
}
pub(super) async fn subscribe_batched(
@@ -483,7 +483,7 @@ impl<P: RoomDataProvider> TimelineController<P> {
) -> (Vector<Arc<TimelineItem>>, impl Stream<Item = Vec<VectorDiff<Arc<TimelineItem>>>>) {
trace!("Creating timeline items signal");
let state = self.state.read().await;
(state.items.clone(), state.items.subscribe().into_batched_stream())
(state.items.clone_items(), state.items.subscribe().into_batched_stream())
}
pub(super) async fn subscribe_filter_map<U, F>(

18
crates/matrix-sdk-ui/src/timeline/controller/observable_items.rs
View File

@@ -82,7 +82,7 @@ impl ObservableItems {
/// Get a clone of all timeline items.
///
/// Note that it doesn't clone `Self`, only the inner timeline items.
pub fn clone(&self) -> Vector<Arc<TimelineItem>> {
pub fn clone_items(&self) -> Vector<Arc<TimelineItem>> {
self.items.clone()
}
@@ -498,7 +498,7 @@ mod observable_items_tests {
}
#[test]
fn test_clone() {
fn test_clone_items() {
let mut items = ObservableItems::new();
let mut transaction = items.transaction();
@@ -506,10 +506,10 @@ mod observable_items_tests {
transaction.push_back(item("$ev1"), Some(1));
transaction.commit();
let events = items.clone();
assert_eq!(events.len(), 2);
assert_event_id!(events[0], "$ev0");
assert_event_id!(events[1], "$ev1");
let items = items.clone_items();
assert_eq!(items.len(), 2);
assert_event_id!(items[0], "$ev0");
assert_event_id!(items[1], "$ev1");
}
#[test]
@@ -524,9 +524,9 @@ mod observable_items_tests {
// That's time to replace it!
items.replace(0, item("$ev1"));
let events = items.clone();
assert_eq!(events.len(), 1);
assert_event_id!(events[0], "$ev1");
let items = items.clone_items();
assert_eq!(items.len(), 1);
assert_event_id!(items[0], "$ev1");
}
#[test]