mirror/matrix-rust-sdk
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-rust-sdk.git synced 2026-05-13 10:35:41 -04:00
Code Issues Packages Projects Releases Wiki Activity

Revert "doc(timeline): tweak comments when inserting a new item"

Browse Source 
This reverts commit 197da2c585.
This commit is contained in:
Damir Jelić
2024-12-04 13:36:28 +01:00
parent a4434d79c9
commit 136522c694
1 changed files with 14 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
crates/matrix-sdk-ui/src/timeline/event_handler.rs
View File

@@ -1158,6 +1158,17 @@ impl<'a, 'o> TimelineEventHandler<'a, 'o> {
None => self.meta.new_timeline_item(item),
};
trace!("Adding new remote timeline item after all non-local events");
// We are about to insert the `new_item`, great! Though, we try to keep
// precise insertion semantics here, in this exact order:
//
// * _push back_ when the new item is inserted after all items,
// * _push front_ when the new item is inserted at index 0,
// * _insert_ otherwise.
//
// It means that the first inserted item will generate a _push back_ for
// example.
match position {
TimelineItemPosition::Start { .. } => {
trace!("Adding new remote timeline item at the front");
@@ -1176,15 +1187,9 @@ impl<'a, 'o> TimelineEventHandler<'a, 'o> {
// local echo, or at the start if there is no such item.
let insert_idx = latest_event_idx.map_or(0, |idx| idx + 1);
// Try to keep precise insertion semantics here, in this exact order:
//
// * _push back_ when the new item is inserted after all items (the
// assumption
// being that this is the hot path, because most of the time new events
// come from the sync),
// * _push front_ when the new item is inserted at index 0,
// * _insert_ otherwise.
// Let's prioritize push backs because it's the hot path. Events are more
// generally added at the back because they come from the sync most of the
// time.
if insert_idx == self.items.len() {
trace!("Adding new remote timeline item at the back");
self.items.push_back(new_item);