mirror/matrix-rust-sdk
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-rust-sdk.git synced 2026-05-07 23:44:53 -04:00
Code Issues Packages Projects Releases Wiki Activity

chore: exclude the room id / event id from the data to be sent to sentry

Browse Source 
These are not included in Element's main privacy policy, and may
constitute PII (because the homeserver may include the name of some
user). We keep the information as separate log lines, so that
rageshakes/manual reports still include those.
This commit is contained in:
Benjamin Bouvier
2025-07-03 15:32:25 +02:00
parent 3d1d1c8f6d
commit 39d1ed9bc6
1 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
crates/matrix-sdk-sqlite/src/state_store.rs
View File

@@ -395,13 +395,6 @@ impl SqliteStateStore {
serde_path_to_error::deserialize(json_deserializer).map_err(|err| {
let raw_json: Option<Raw<serde_json::Value>> = serde_json::from_slice(&decoded).ok();
let (room_id, event_id) = if let Some(raw) = raw_json {
let room_id = raw.get_field::<OwnedRoomId>("room_id").ok().flatten();
let event_id = raw.get_field::<OwnedEventId>("event_id").ok().flatten();
(room_id, event_id)
} else {
(None, None)
};
let target_type = std::any::type_name::<T>();
let serde_path = err.path().to_string();
@@ -409,11 +402,18 @@ impl SqliteStateStore {
error!(
sentry = true,
%err,
maybe_room_id = ?room_id,
maybe_event_id = ?event_id,
"Failed to deserialize {target_type} in the state state: {serde_path}",
);
if let Some(raw) = raw_json {
if let Some(room_id) = raw.get_field::<OwnedRoomId>("room_id").ok().flatten() {
warn!("Found a room id in the source data to deserialize: {room_id}");
}
if let Some(event_id) = raw.get_field::<OwnedEventId>("event_id").ok().flatten() {
warn!("Found an event id in the source data to deserialize: {event_id}");
}
}
err.into_inner().into()
})
}