mirror/matrix-rust-sdk
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-rust-sdk.git synced 2026-05-19 06:04:31 -04:00
Code Issues Packages Projects Releases Wiki Activity

timeline: inline find_read_marker that's used only once

Browse Source
This commit is contained in:
Benjamin Bouvier
2024-01-22 15:48:52 +01:00
parent ff89315b6e
commit 68c9e5e98d
2 changed files with 2 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
crates/matrix-sdk-ui/src/timeline/inner/state.rs
View File

@@ -52,10 +52,7 @@ use crate::{
reactions::{ReactionToggleResult, Reactions},
read_receipts::ReadReceipts,
traits::RoomDataProvider,
util::{
find_read_marker, rfind_event_by_id, rfind_event_item, timestamp_to_date,
RelativePosition,
},
util::{rfind_event_by_id, rfind_event_item, timestamp_to_date, RelativePosition},
AnnotationKey, Error as TimelineError, Profile, ReactionSenderData, TimelineItem,
TimelineItemKind, VirtualTimelineItem,
},
@@ -891,7 +888,7 @@ impl TimelineInnerMetadata {
let Some(fully_read_event) = &self.fully_read_event else { return };
trace!(?fully_read_event, "Updating read marker");
let read_marker_idx = find_read_marker(items);
let read_marker_idx = items.iter().rposition(|item| item.is_read_marker());
let fully_read_event_idx = rfind_event_by_id(items, fully_read_event).map(|(idx, _)| idx);
match (read_marker_idx, fully_read_event_idx) {

4
crates/matrix-sdk-ui/src/timeline/util.rs
View File

@@ -67,10 +67,6 @@ pub(super) fn rfind_event_by_id<'a>(
rfind_event_item(items, |it| it.event_id() == Some(event_id))
}
pub(super) fn find_read_marker(items: &Vector<Arc<TimelineItem>>) -> Option<usize> {
items.iter().rposition(|item| item.is_read_marker())
}
/// Result of comparing events position in the timeline.
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub(super) enum RelativePosition {