mirror/matrix-rust-sdk
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-rust-sdk.git synced 2026-04-27 18:51:13 -04:00
Code Issues Packages Projects Releases Wiki Activity

ui: Forward server failures to toggle reaction to user

Browse Source 
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
This commit is contained in:
Kévin Commaille
2024-01-11 15:52:53 +01:00
committed by Jonas Platte
parent cfe3bb7cef
commit 8d0867a1a8
2 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
crates/matrix-sdk-ui/src/timeline/inner/mod.rs
View File

@@ -622,6 +622,13 @@ impl<P: RoomDataProvider> TimelineInner<P> {
}
};
if matches!(
result,
ReactionToggleResult::AddFailure { .. } | ReactionToggleResult::RedactFailure { .. }
) {
return Err(super::Error::FailedToToggleReaction);
}
Ok(follow_up_action)
}

6
crates/matrix-sdk-ui/src/timeline/tests/reactions.rs
View File

@@ -51,7 +51,7 @@ async fn add_reaction_failed() {
timeline
.handle_reaction_response(&reaction, &ReactionToggleResult::AddFailure { txn_id })
.await
.unwrap();
.unwrap_err();
assert_reactions_are_removed(&mut stream, &msg_id, msg_pos).await;
assert_no_more_updates(&mut stream).await;
@@ -135,7 +135,7 @@ async fn redact_reaction_failure() {
&ReactionToggleResult::RedactFailure { event_id: event_id.clone() },
)
.await
.unwrap();
.unwrap_err();
assert_reaction_is_updated(&mut stream, &msg_id, msg_pos, Some(&event_id), None).await;
assert_no_more_updates(&mut stream).await;
@@ -229,7 +229,7 @@ async fn reactions_store_timestamp() {
&ReactionToggleResult::RedactFailure { event_id: msg_id.clone() },
)
.await
.unwrap();
.unwrap_err();
// Restores an event with a valid timestamp.
let event = assert_event_is_updated(&mut stream, &msg_id, msg_pos).await;