mirror/matrix-rust-sdk
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-rust-sdk.git synced 2026-05-14 19:16:02 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(sdk): Only retry requests on M_LIMIT_EXCEEDED or HTTP 5xx

Browse Source
This commit is contained in:
Jonas Platte
2022-11-25 14:13:17 +01:00
committed by Jonas Platte
parent d7e6dd22e6
commit afda63f9e2
1 changed files with 31 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
crates/matrix-sdk/src/http_client.rs
View File

@@ -170,7 +170,11 @@ impl HttpClient {
use std::sync::atomic::{AtomicU64, Ordering};
use backoff::{future::retry, Error as RetryError, ExponentialBackoff};
use ruma::api::client::error::ErrorKind as ClientApiErrorKind;
use ruma::api::client::error::{
ErrorBody as ClientApiErrorBody, ErrorKind as ClientApiErrorKind,
};
use crate::RumaApiError;
let backoff =
ExponentialBackoff { max_elapsed_time: config.retry_timeout, ..Default::default() };
@@ -188,11 +192,32 @@ impl HttpClient {
RetryError::Permanent
} else {
|err: HttpError| {
let retry_after = err.client_api_error_kind().and_then(|kind| match kind {
ClientApiErrorKind::LimitExceeded { retry_after_ms } => *retry_after_ms,
_ => None,
});
RetryError::Transient { err, retry_after }
if let Some(api_error) = err.as_ruma_api_error() {
let status_code = match api_error {
RumaApiError::ClientApi(e) => match e.body {
ClientApiErrorBody::Standard {
kind: ClientApiErrorKind::LimitExceeded { retry_after_ms },
..
} => {
return RetryError::Transient {
err,
retry_after: retry_after_ms,
};
}
_ => Some(e.status_code),
},
RumaApiError::Uiaa(_) => None,
RumaApiError::Other(e) => Some(e.status_code),
};
if let Some(status_code) = status_code {
if status_code.is_server_error() {
return RetryError::Transient { err, retry_after: None };
}
}
}
RetryError::Permanent(err)
}
};