mirror/matrix-rust-sdk
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-rust-sdk.git synced 2026-05-18 13:40:55 -04:00
Code Issues Packages Projects Releases Wiki Activity

Clarify the comment about creating a Olm session twice

Browse Source 
Co-authored-by: Denis Kasak <dkasak@termina.org.uk>
This commit is contained in:
Damir Jelić
2023-06-16 16:32:46 +02:00
parent aab3d00246
commit bddc88472a
2 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
crates/matrix-sdk-crypto/src/olm/account.rs
View File

@@ -278,14 +278,13 @@ impl Account {
// The message was intended for this session, but we weren't able to decrypt it.
//
// We're going to return early here since no other session will be able to
// decrypt this message, nor should we try to create a new one since we already
// created a `Session` with such a pre-key message.
// decrypt this message, nor should we try to create a new one since we had
// already previously created a `Session` with such a pre-key message.
//
// Creating a new session will likely fail since the one-time key that should be
// used to establish the session will be used up.
//
// The one exception where creating a new session won't fail is if a fallback
// key was used for this `Session`.
// Creating this session would have likely failed anyway since the corresponding
// one-time key would've been already used up in the previous session creation
// operation. The one exception where this would not be so is if the fallback
// key was used for creating the session in lieu of an OTK.
return Err(OlmError::SessionWedged(
session.user_id.to_owned(),
session.sender_key(),

2
crates/matrix-sdk-crypto/src/session_manager/sessions.rs
View File

@@ -344,7 +344,7 @@ impl SessionManager {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
write!(
f,
"session_id: {}, algorithm: {}, fallback_key_used {}",
"session_id: {}, algorithm: {}, fallback_key_used: {}",
self.session_id, self.algorithm, self.fallback_key_used
)
}