mirror of
https://github.com/matrix-org/matrix-rust-sdk.git
synced 2026-05-15 03:25:46 -04:00
b029519248
If an event cannot be decrypted after a grace period, it is reported to the application (and thence Posthog) as a UTD event. Currently, if it is then successfully decrypted, the event is then re-reported as a "late decryption". This does not match the expected behaviour in Posthog - an event is *either* a UTD, or a late decryption; it makes no sense for it to be both. This PR fixes the problem. I've attempted to make the commits sensible, but I'm not entirely sure I've succeeded. The tests do pass after each commit, though. The interesting change itself is somewhere in the middle; there is non-functional groundwork before and cleanup afterwards. --- * ui: Factor out UTD report code to a closure For now, this doesn't help much, but in future there will be more logic here, and it helps reduce the repetition between the delay and no-delay cases. * ui: Convert UtdHookManager::pending_delayed to a HashMap * ui: Store decryption time in `UtdHookManager::pending_delayed` This is a step on getting rid of `known_utds` * ui: Fix re-reporting of late decryptions This fixes the problem where a message that was previously reported as a UTD, and was then subsequently successfully decrypted, is then re-reported as a late decryption. This artificially inflated the UTD metrics. We do this by checking the `pending_delayed` list in `on_late_decrypt`, instead of the `known_utds` list. There is some associated reordering of code to get the locking right. * ui: Remove unused "utd report time" from `UtdHookManager::known_utds` * ui: Replace `UtdHookManager::known_utds` with `reported_utds` Keep a list of the UTDs we've actually reported, rather than the union of those we've reported together with those we might report in a while. I find this much easier to reason about. * Address minor review comments * Reinstate assertion in UTD hook tests * Reinstate `known_utds`
matrix-rust-sdk
matrix-rust-sdk is an implementation of a Matrix client-server library in Rust.
Project structure
The rust-sdk consists of multiple crates that can be picked at your convenience:
- matrix-sdk - High level client library, with batteries included, you're most likely interested in this.
- matrix-sdk-base - No (network) IO client state machine that can be used to embed a Matrix client in your project or build a full fledged network enabled client lib on top of it.
- matrix-sdk-crypto - No (network) IO encryption state machine that can be used to add Matrix E2EE support to your client or client library.
Minimum Supported Rust Version (MSRV)
These crates are built with the Rust language version 2021 and require a minimum compiler version of 1.70.
Status
The library is in an alpha state, things that are implemented generally work but the API will change in breaking ways.
If you are interested in using the matrix-sdk now is the time to try it out and provide feedback.
Bindings
Some crates of the matrix-rust-sdk can be embedded inside other
environments, like Swift, Kotlin, JavaScript, Node.js etc. Please,
explore the bindings/ directory to learn more.