feature: disable bugsnag network requests breadcrumbs

This commit is contained in:
Radek Czemerys
2020-09-10 17:13:04 +02:00
parent 441905d5ec
commit 451eb45d2b
4 changed files with 26 additions and 6 deletions

View File

@@ -3,6 +3,9 @@ package com.standardnotes;
import android.app.Application;
import android.app.Activity;
import android.content.Context;
import com.bugsnag.android.BreadcrumbType;
import com.bugsnag.android.Configuration;
import com.facebook.react.PackageList;
import com.facebook.react.ReactApplication;
import com.facebook.react.ReactInstanceManager;
@@ -10,6 +13,7 @@ import com.facebook.react.ReactNativeHost;
import com.facebook.react.ReactPackage;
import com.facebook.soloader.SoLoader;
import java.lang.reflect.InvocationTargetException;
import java.util.HashSet;
import java.util.List;
import com.bugsnag.android.Bugsnag;
@@ -59,7 +63,18 @@ public class MainApplication extends Application implements ReactApplication {
rebuildOkHtttp();
Bugsnag.start(this /* app context */);
Configuration config = Configuration.load(this);
config.setEnabledBreadcrumbTypes(new HashSet<BreadcrumbType>() {{
add(BreadcrumbType.NAVIGATION);
add(BreadcrumbType.STATE);
add(BreadcrumbType.PROCESS);
add(BreadcrumbType.MANUAL);
add(BreadcrumbType.USER);
add(BreadcrumbType.LOG);
add(BreadcrumbType.ERROR);
}});
Bugsnag.start(this, config);
SoLoader.init(this, /* native exopackage */ false);

View File

@@ -23,8 +23,12 @@
- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
{
[self initializeFlipper:application];
BugsnagConfiguration *config = [BugsnagConfiguration loadConfig];
config.enabledBreadcrumbTypes = BSGEnabledBreadcrumbTypeNavigation | BSGEnabledBreadcrumbTypeLog
| BSGEnabledBreadcrumbTypeUser | BSGEnabledBreadcrumbTypeState | BSGEnabledBreadcrumbTypeNavigation | BSGEnabledBreadcrumbTypeProcess;
[Bugsnag start];
[Bugsnag startWithConfiguration:config];
[self configurePinning];

View File

@@ -135,8 +135,8 @@ export class SNReactNativeCrypto implements SNPureCrypto {
/**
* Not implemented in SNReactNativeCrypto
*/
public generateUUIDSync() {
return '';
public generateUUIDSync(): never {
throw new Error('generateUUIDSync not implemented on mobile');
}
public async generateUUID() {

View File

@@ -557,10 +557,11 @@ export const NoteSideMenu = (props: Props) => {
note,
changeNote,
leaveEditor,
application,
deleteNote,
editor?.isTemplateNote,
props.drawerRef,
navigation,
application,
deleteNote,
]);
const onTagSelect = useCallback(