mirror/motion
1
0
Fork 0
mirror of https://github.com/Motion-Project/motion.git synced 2026-02-06 13:01:38 -05:00
Code Issues Packages Projects Releases Wiki Activity

Revise acceptable movie_quality values

Browse Source
This commit is contained in:
Mr-Dave
2024-04-29 16:21:11 -06:00
parent c584731c73
commit 16ccee8d23
1 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/conf.cpp
View File

@@ -1902,8 +1902,22 @@ static void conf_edit_movie_quality(ctx_config *conf, std::string &parm, enum PA
conf->movie_quality = 60;
} else if (pact == PARM_ACT_SET) {
parm_in = atoi(parm.c_str());
if ((parm_in < 0) || (parm_in > 100)) {
if ((parm_in <= 0) || (parm_in > 100)) {
MOTPLS_LOG(NTC, TYPE_ALL, NO_ERRNO, _("Invalid movie_quality %d"),parm_in);
} else if (parm_in > 90) {
/*
Many movie players can not handle the 100% quality
setting from ffmpeg. It sets baseline and x265 to high, etc.
As a result, we limit it to an arbritrary number less
than 100 (i.e. 90)
*/
MOTPLS_LOG(NTC, TYPE_ALL, NO_ERRNO
, _("Movie quality settings greater than 90 are not permitted."));
conf->movie_quality = 90;
} else if (parm_in < 5) {
MOTPLS_LOG(NTC, TYPE_ALL, NO_ERRNO
, _("Movie quality settings less then 5 are not permitted."));
conf->movie_quality = 5;
} else {
conf->movie_quality = parm_in;
}