mirror/obs-studio
1
0
Fork 0
mirror of https://github.com/obsproject/obs-studio.git synced 2026-03-27 02:42:26 -04:00
Code Issues Packages Projects Releases Wiki Activity

media-playback: Fix possible crash if frame width or height is zero

Browse Source 
If a frame has a width or height of zero, this value will make it into
libobs/media-io/video-frame.c:video_frame_init and cause linesizes or
heights to be zero, which will result in a bmalloc(0) call and OBS will
crash.

Instead of letting the call stack get that far, check the frame width
and height here at the source, log an error, and return early if the
frame width or height are zero.
This commit is contained in:
Ryan Foster
2025-04-01 14:58:06 -04:00
parent 343ae6015a
commit 7cae57d3b7
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
shared/media-playback/media-playback/media.c
View File

@@ -382,6 +382,12 @@ void mp_media_next_video(mp_media_t *m, bool preload)
enum video_range_type new_range;
AVFrame *f = d->frame;
if (!f->width || !f->height) {
blog(LOG_ERROR, "MP: media frame width or height are zero ('%s': %" PRIu32 "x%" PRIu32 ")", m->path,
f->width, f->height);
return;
}
if (!preload) {
if (!mp_media_can_play_frame(m, d))
return;