mirror/obs-studio
1
0
Fork 0
mirror of https://github.com/obsproject/obs-studio.git synced 2026-03-27 19:02:02 -04:00
Code Issues Packages Projects Releases Wiki Activity

updater: Improve exception handling

Browse Source 
Logs exceptions and changes QuickWriteFile to throw a catchable
exception instead of a DWORD.
This commit is contained in:
Richard Stanway
2026-02-09 02:07:02 +01:00
committed by Ryan Foster
parent e715df130b
commit 95bfb81f69
1 changed files with 19 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
frontend/updater/updater.cpp
View File

@@ -14,21 +14,22 @@
* OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*/
#include "updater.hpp"
#include "manifest.hpp"
#include "updater.hpp"
#include <psapi.h>
#include <WinTrust.h>
#include <SoftPub.h>
#include <WinTrust.h>
#include <util/windows/CoTaskMemPtr.hpp>
#include <exception>
#include <future>
#include <mutex>
#include <queue>
#include <string>
#include <string_view>
#include <mutex>
#include <unordered_set>
#include <queue>
using namespace std;
using namespace updater;
@@ -219,11 +220,11 @@ try {
WinHandle handle = CreateFile(file, GENERIC_WRITE, 0, nullptr, CREATE_ALWAYS, FILE_FLAG_WRITE_THROUGH, nullptr);
if (handle == INVALID_HANDLE_VALUE)
throw GetLastError();
throw LastError();
DWORD written;
if (!WriteFile(handle, data, (DWORD)size, &written, nullptr))
throw GetLastError();
throw LastError();
return true;
@@ -491,7 +492,11 @@ try {
return true;
} catch (const exception &e) {
Status(L"Exception: %S", e.what());
return false;
} catch (...) {
Status(L"Unknown exception occurred in RunDownloadWorkers");
return false;
}
@@ -634,7 +639,11 @@ try {
for (auto &result : futures) {
result.wait();
}
} catch (const exception &e) {
Status(L"Exception: %S", e.what());
} catch (...) {
Status(L"Unknown exception occurred in RunHasherWorkers");
}
/* ----------------------------------------------------------------------- */
@@ -1075,7 +1084,11 @@ try {
return true;
} catch (const exception &e) {
Status(L"Exception: %S", e.what());
return false;
} catch (...) {
Status(L"Unknown exception occurred in RunUpdateWorkers");
return false;
}