mirror/obs-studio
1
0
Fork 0
mirror of https://github.com/obsproject/obs-studio.git synced 2026-05-11 16:59:43 -04:00
Code Issues Packages Projects Releases Wiki Activity

obs-vst: Use v2 of obs_properties_add_button

Browse Source 
v1 of obs_properties_add_button will be deprecated soon.
Also fixes UNUSED_PARAMETER calls in the callbacks for parameters that
are not actually unused, and moves the other ones to the top (as in most
of the rest of the project).
This commit is contained in:
Sebastian Beckmann
2025-08-23 13:59:10 +02:00
committed by Ryan Foster
parent a759fa5aae
commit cb75098a93
1 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
plugins/obs-vst/obs-vst.cpp
View File

@@ -37,6 +37,8 @@ MODULE_EXPORT const char *obs_module_description(void)
static bool open_editor_button_clicked(obs_properties_t *props, obs_property_t *property, void *data)
{
UNUSED_PARAMETER(property);
VSTPlugin *vstPlugin = (VSTPlugin *)data;
if (vstPlugin && vstPlugin->vstLoaded()) {
@@ -47,15 +49,13 @@ static bool open_editor_button_clicked(obs_properties_t *props, obs_property_t *
obs_property_set_visible(obs_properties_get(props, CLOSE_VST_SETTINGS), true);
}
UNUSED_PARAMETER(props);
UNUSED_PARAMETER(property);
UNUSED_PARAMETER(data);
return true;
}
static bool close_editor_button_clicked(obs_properties_t *props, obs_property_t *property, void *data)
{
UNUSED_PARAMETER(property);
VSTPlugin *vstPlugin = (VSTPlugin *)data;
if (vstPlugin && vstPlugin->vstLoaded() && vstPlugin->isEditorOpen()) {
@@ -66,8 +66,6 @@ static bool close_editor_button_clicked(obs_properties_t *props, obs_property_t
obs_property_set_visible(obs_properties_get(props, CLOSE_VST_SETTINGS), false);
}
UNUSED_PARAMETER(property);
return true;
}
@@ -302,8 +300,8 @@ static obs_properties_t *vst_properties(void *data)
fill_out_plugins(list);
obs_properties_add_button(props, OPEN_VST_SETTINGS, OPEN_VST_TEXT, open_editor_button_clicked);
obs_properties_add_button(props, CLOSE_VST_SETTINGS, CLOSE_VST_TEXT, close_editor_button_clicked);
obs_properties_add_button2(props, OPEN_VST_SETTINGS, OPEN_VST_TEXT, open_editor_button_clicked, data);
obs_properties_add_button2(props, CLOSE_VST_SETTINGS, CLOSE_VST_TEXT, close_editor_button_clicked, data);
bool open_settings_vis = true;
bool close_settings_vis = false;