mirror of
https://github.com/obsproject/obs-studio.git
synced 2026-01-22 13:18:34 -05:00
cececf4e55
A bug which was technically introduced indf446c3f6e: the author assigned video mixes to the virtual camera and did not realize you have to wait for full capture stop with the "deactivate" signal rather than the "stop" signal. This situation is understandable because these signals are likely confusing and need more documentation. The way an output works when it stops is it has three stages: - "stopping", which is the moment the user themselves stop the output - "stop", when the output's implementation has stopped and returns success or an error code - "deactivate", when the output inself (not the implementation) has fully stopped capturing encoded or raw frame data after the implementation has stopped. This is done in a separate thread, end_data_capture_thread(), for performance and data race reasons, and is when it's "actually fully stopped for real this time" (Lain note: I sincerely apologize for this confusing signal design) The author ofdf446c3f6ewas likely confused as to why they could not destroy the video mix in the "stop" signal without triggering a race condition in end_data_capture_thread(), and instead decided to make a workaround to clear the video mix set to the output before destroying the video mix. Unsetting the video mix I'm guessing *seemed* to fix the problem for them at the time, and destroying the video mix separately after that automatically stops capture, so it *technically* worked because the deactivate thread cannot be called until the implementation's stop signal has executed. However, it was still the incorrect way to handle the problem, because it circumvents the output's mechanism for deactivating the frame data capture by destroying the view instead. The reason this was the incorrect way to handle the problem became exposed in7cd7ca80f8, when tytan made it so it uses the main video mix under certain circumstances. The main view is special and cannot be destroyed, so the mechanism to stop frame data capture that the virtualcam was using before failed, and raw frame data capture continued perpetually until the end of the program erroneously. This fix solves the bug by using the "deactivate" signal rather than the "stop" signal, thus allowing the output to fully end its data capture and *then* destroy the video mix. Fixes obsproject/obs-studio#9153
OBS Studio <https://obsproject.com> =================================== .. image:: https://github.com/obsproject/obs-studio/actions/workflows/main.yml/badge.svg?branch=master&event=push :alt: OBS Studio Build Status - GitHub Actions :target: https://github.com/obsproject/obs-studio/actions/workflows/main.yml?query=event%3Apush+branch%3Amaster .. image:: https://badges.crowdin.net/obs-studio/localized.svg :alt: OBS Studio Translation Project Progress :target: https://crowdin.com/project/obs-studio .. image:: https://img.shields.io/discord/348973006581923840.svg?label=&logo=discord&logoColor=ffffff&color=7389D8&labelColor=6A7EC2 :alt: OBS Studio Discord Server :target: https://obsproject.com/discord What is OBS Studio? ------------------- OBS Studio is software designed for capturing, compositing, encoding, recording, and streaming video content, efficiently. It's distributed under the GNU General Public License v2 (or any later version) - see the accompanying COPYING file for more details. Quick Links ----------- - Website: https://obsproject.com - Help/Documentation/Guides: https://github.com/obsproject/obs-studio/wiki - Forums: https://obsproject.com/forum/ - Build Instructions: https://github.com/obsproject/obs-studio/wiki/Install-Instructions - Developer/API Documentation: https://obsproject.com/docs - Donating/backing/sponsoring: https://obsproject.com/contribute - Bug Tracker: https://github.com/obsproject/obs-studio/issues Contributing ------------ - If you would like to help fund or sponsor the project, you can do so via `Patreon <https://www.patreon.com/obsproject>`_, `OpenCollective <https://opencollective.com/obsproject>`_, or `PayPal <https://www.paypal.me/obsproject>`_. See our `contribute page <https://obsproject.com/contribute>`_ for more information. - If you wish to contribute code to the project, please make sure to read the coding and commit guidelines: https://github.com/obsproject/obs-studio/blob/master/CONTRIBUTING.rst - Developer/API documentation can be found here: https://obsproject.com/docs - If you wish to contribute translations, do not submit pull requests. Instead, please use Crowdin. For more information read this page: https://obsproject.com/wiki/How-To-Contribute-Translations-For-OBS - Other ways to contribute are by helping people out with support on our forums or in our community chat. Please limit support to topics you fully understand -- bad advice is worse than no advice. When it comes to something that you don't fully know or understand, please defer to the official help or official channels.