bring back the settings ui (#4691)

changelog/unreleased/fix-bring-back-settings-ui.md

@@ -0,0 +1,5 @@
+Bugfix: Bring back the settings UI in Web
+
+We've fixed the oC Web configuration in oCIS so that the settings UI will be shown again in Web.
+
+https://github.com/owncloud/ocis/pull/4691

services/web/pkg/config/defaults/defaultconfig.go

@@ -49,6 +49,10 @@ func DefaultConfig() *config.Config {
 				},
 				Apps: []string{"files", "search", "text-editor", "pdf-viewer", "external", "user-management"},
 				ExternalApps: []config.ExternalApp{
+					{
+						ID:   "settings",
+						Path: "/settings.js",
+					},
 					{
 						ID:   "preview",
 						Path: "web-app-preview",

services/web/pkg/service/v0/service.go

@@ -73,15 +73,6 @@ func (p Web) getPayload() (payload []byte, err error) {
 			p.config.Web.Config.Theme = p.config.Web.ThemePath
 		}
 
-		if p.config.Web.Config.ExternalApps == nil {
-			p.config.Web.Config.ExternalApps = []config.ExternalApp{
-				{
-					ID:   "settings",
-					Path: "/settings.js",
-				},
-			}
-		}
-
 		// make apps render as empty array if it is empty
 		// TODO remove once https://github.com/golang/go/issues/27589 is fixed
 		if len(p.config.Web.Config.Apps) == 0 {