fix preview tests

2026-03-04 07:17:16 -05:00 · 2020-08-12 14:21:37 +05:45
parent 4ae20f8c7f
commit 340f92f687
3 changed files with 67 additions and 113 deletions
--- a/.drone.star
+++ b/.drone.star
@@ -278,7 +278,7 @@ def coreApiTests(ctx, coreBranch = 'master', coreCommit = '', part_number = 1, n
          'OCIS_REVA_DATA_ROOT': '/srv/app/tmp/reva/',
          'SKELETON_DIR': '/srv/app/tmp/testing/data/apiSkeleton',
          'TEST_OCIS':'true',
-          'BEHAT_FILTER_TAGS': '~@notToImplementOnOCIS&&~@toImplementOnOCIS&&~@preview-extension-required',
+          'BEHAT_FILTER_TAGS': '~@notToImplementOnOCIS&&~@toImplementOnOCIS',
          'DIVIDE_INTO_NUM_PARTS': number_of_parts,
          'RUN_PART': part_number,
          'EXPECTED_FAILURES_FILE': '/drone/src/tests/acceptance/expected-failures.txt'
--- a/tests/acceptance/expected-failures.txt
+++ b/tests/acceptance/expected-failures.txt
@@ -924,3 +924,69 @@ apiWebdavUpload2/uploadFileUsingOldChunking.feature:98
 apiWebdavUpload2/uploadFileUsingOldChunking.feature:99
 apiWebdavUpload2/uploadFileUsingOldChunking.feature:100
 apiWebdavUpload2/uploadFileUsingOldChunking.feature:101
+#
+# https://github.com/owncloud/ocis/issues/187 Previews via webDAV API tests fails on OCIS
+apiWebdavPreviews/previews.feature:15
+apiWebdavPreviews/previews.feature:16
+apiWebdavPreviews/previews.feature:17
+apiWebdavPreviews/previews.feature:18
+apiWebdavPreviews/previews.feature:19
+apiWebdavPreviews/previews.feature:29
+apiWebdavPreviews/previews.feature:30
+apiWebdavPreviews/previews.feature:31
+apiWebdavPreviews/previews.feature:32
+apiWebdavPreviews/previews.feature:33
+apiWebdavPreviews/previews.feature:34
+apiWebdavPreviews/previews.feature:35
+apiWebdavPreviews/previews.feature:45
+apiWebdavPreviews/previews.feature:46
+apiWebdavPreviews/previews.feature:47
+apiWebdavPreviews/previews.feature:48
+apiWebdavPreviews/previews.feature:49
+apiWebdavPreviews/previews.feature:50
+apiWebdavPreviews/previews.feature:51
+apiWebdavPreviews/previews.feature:62
+apiWebdavPreviews/previews.feature:63
+apiWebdavPreviews/previews.feature:64
+apiWebdavPreviews/previews.feature:65
+apiWebdavPreviews/previews.feature:66
+apiWebdavPreviews/previews.feature:67
+apiWebdavPreviews/previews.feature:68
+apiWebdavPreviews/previews.feature:78
+apiWebdavPreviews/previews.feature:79
+apiWebdavPreviews/previews.feature:80
+apiWebdavPreviews/previews.feature:81
+apiWebdavPreviews/previews.feature:82
+apiWebdavPreviews/previews.feature:83
+apiWebdavPreviews/previews.feature:84
+apiWebdavPreviews/previews.feature:87
+apiWebdavPreviews/previews.feature:102
+apiWebdavPreviews/previews.feature:103
+apiWebdavPreviews/previews.feature:104
+apiWebdavPreviews/previews.feature:114
+apiWebdavPreviews/previews.feature:115
+apiWebdavPreviews/previews.feature:116
+apiWebdavPreviews/previews.feature:126
+apiWebdavPreviews/previews.feature:127
+apiWebdavPreviews/previews.feature:138
+apiWebdavPreviews/previews.feature:139
+apiWebdavPreviews/previews.feature:142
+apiWebdavPreviews/previews.feature:151
+apiWebdavPreviews/previews.feature:159
+apiWebdavPreviews/previews.feature:168
+apiWebdavPreviews/previews.feature:178
+apiWebdavPreviews/previews.feature:185
+apiWebdavPreviews/previews.feature:194
+apiWebdavPreviews/previews.feature:199
+apiWebdavPreviews/previews.feature:206
+apiWebdavPreviews/previews.feature:215
+apiWebdavPreviews/previews.feature:222
+apiWebdavPreviews/previews.feature:232
+apiWebdavPreviews/previews.feature:240
+apiWebdavPreviews/previews.feature:251
+apiWebdavPreviews/previews.feature:269
+apiWebdavPreviews/previews.feature:270
+apiWebdavPreviews/previews.feature:271
+apiWebdavPreviews/previews.feature:272
+apiWebdavPreviews/previews.feature:284
+apiWebdavPreviews/previews.feature:285
--- a/tests/acceptance/features/apiOcisSpecific/apiWebdavPreviews-previews.feature
+++ b/tests/acceptance/features/apiOcisSpecific/apiWebdavPreviews-previews.feature
@@ -1,112 +0,0 @@
-@api @issue-ocis-187
-Feature: previews of files downloaded through the webdav API
-
-  Background:
-    Given user "Alice" has been created with default attributes and without skeleton files
-
-  @issue-ocis-188
-  # after fixing all issues delete this Scenario and use the one from oC10 core
-  Scenario Outline: download previews with invalid width
-    Given user "Alice" has uploaded file "filesForUpload/lorem.txt" to "/parent.txt"
-    When user "Alice" downloads the preview of "/parent.txt" with width "<width>" and height "32" using the WebDAV API
-    Then the HTTP status code should be "200"
-    Examples:
-      | width |
-      | 0     |
-      | 0.5   |
-      | -1    |
-      | false |
-      | true  |
-      | A     |
-      | %2F   |
-
-  @issue-ocis-188
-  # after fixing all issues delete this Scenario and use the one from oC10 core
-  Scenario Outline: download previews with invalid height
-    Given user "Alice" has uploaded file "filesForUpload/lorem.txt" to "/parent.txt"
-    When user "Alice" downloads the preview of "/parent.txt" with width "32" and height "<height>" using the WebDAV API
-    Then the HTTP status code should be "200"
-    Examples:
-      | height |
-      | 0      |
-      | 0.5    |
-      | -1     |
-      | false  |
-      | true   |
-      | A      |
-      | %2F    |
-
-  @issue-ocis-189
-  # after fixing all issues delete this Scenario and use the one from oC10 core
-  Scenario Outline: download previews of file types that don't support preview
-    Given user "Alice" has uploaded file "filesForUpload/<filename>" to "/<newfilename>"
-    When user "Alice" downloads the preview of "/<newfilename>" with width "32" and height "32" using the WebDAV API
-    Then the HTTP status code should be "200"
-    Examples:
-      | filename     | newfilename |
-      | simple.pdf   | test.pdf    |
-      | simple.odt   | test.odt    |
-      | new-data.zip | test.zip    |
-
-  @issue-ocis-187
-  # after fixing all issues delete this Scenario and use the one from oC10 core
-  Scenario Outline: download previews of different image file types
-    Given user "Alice" has uploaded file "filesForUpload/<imageName>" to "/<newImageName>"
-    When user "Alice" downloads the preview of "/<newImageName>" with width "32" and height "32" using the WebDAV API
-    Then the HTTP status code should be "200"
-    And the downloaded image should be "1240" pixels wide and "648" pixels high
-    Examples:
-      | imageName      | newImageName  |
-      | testavatar.jpg | testimage.jpg |
-      | testavatar.png | testimage.png |
-
-  @issue-ocis-187
-  # after fixing all issues delete this Scenario and use the one from oC10 core
-  Scenario: download previews of image after renaming it
-    Given user "Alice" has uploaded file "filesForUpload/testavatar.jpg" to "/testimage.jpg"
-    When user "Alice" moves file "/testimage.jpg" to "/testimage.txt" using the WebDAV API
-    And user "Alice" downloads the preview of "/testimage.txt" with width "32" and height "32" using the WebDAV API
-    Then the HTTP status code should be "200"
-    And the downloaded image should be "1240" pixels wide and "648" pixels high
-
-  @issue-ocis-thumbnails-191 @skipOnOcis-EOS-Storage @issue-ocis-reva-308
-  # after fixing all issues delete this Scenario and use the one from oC10 core
-  Scenario: download previews of other users files
-    Given user "Brian" has been created with default attributes and without skeleton files
-    And user "Alice" has uploaded file "filesForUpload/lorem.txt" to "/parent.txt"
-    When user "Brian" downloads the preview of "/parent.txt" of "Alice" with width "32" and height "32" using the WebDAV API
-    Then the HTTP status code should be "200"
-
-  @issue-ocis-190
-  # after fixing all issues delete this Scenario and use the one from oC10 core
-  Scenario: download previews of folders
-    Given user "Alice" has created folder "subfolder"
-    When user "Alice" downloads the preview of "/subfolder/" with width "32" and height "32" using the WebDAV API
-    Then the HTTP status code should be "501"
-
-  @issue-ocis-192
-  # after fixing all issues delete this Scenario and use the one from oC10 core
-  Scenario: Download file previews when it is disabled by the administrator
-    Given the administrator has updated system config key "enable_previews" with value "false" and type "boolean"
-    And user "Alice" has uploaded file "filesForUpload/lorem.txt" to "/parent.txt"
-    When user "Alice" downloads the preview of "/parent.txt" with width "32" and height "32" using the WebDAV API
-    Then the HTTP status code should be "200"
-
-  @issue-ocis-193
-  # after fixing all issues delete this Scenario and use the one from oC10 core
-  Scenario: unset maximum size of previews
-    Given user "Alice" has uploaded file "filesForUpload/lorem.txt" to "/parent.txt"
-    And the administrator has updated system config key "preview_max_x" with value "null"
-    And the administrator has updated system config key "preview_max_y" with value "null"
-    When user "Alice" downloads the preview of "/parent.txt" with width "32" and height "32" using the WebDAV API
-    Then the HTTP status code should be "200"
-
-  @issue-ocis-193
-  # after fixing all issues delete this Scenario and use the one from oC10 core
-  Scenario: set maximum size of previews
-    Given user "Alice" has uploaded file "filesForUpload/lorem.txt" to "/parent.txt"
-    When the administrator updates system config key "preview_max_x" with value "null" using the occ command
-    And the administrator updates system config key "preview_max_y" with value "null" using the occ command
-    Then the HTTP status code should be "201"
-    When user "Alice" downloads the preview of "/parent.txt" with width "null" and height "null" using the WebDAV API
-    Then the HTTP status code should be "200"