mirror/opencloud
1
0
Fork 0
mirror of https://github.com/opencloud-eu/opencloud.git synced 2026-01-27 23:47:33 -05:00
Code Issues Packages Projects Releases Wiki Activity

Rollback account creation on error

Browse Source
This commit is contained in:
Benedikt Kulmann
2020-10-14 15:50:19 +02:00
committed by A.Unger
parent ec84d7886a
commit 37dc6c7db9
1 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
accounts/pkg/service/v0/accounts.go
View File

@@ -321,7 +321,7 @@ func (s Service) CreateAccount(ctx context.Context, in *proto.CreateAccountReque
}
indexResults, err := s.index.Add(acc)
if err != nil {
// TODO: delete account when failed to add to indices
s.rollbackCreateAccount(ctx, acc)
return merrors.InternalServerError(s.id, "could not index new account: %v", err.Error())
}
s.log.Debug().Interface("account", acc).Msg("account after indexing")
@@ -367,6 +367,18 @@ func (s Service) CreateAccount(ctx context.Context, in *proto.CreateAccountReque
return
}
// rollbackCreateAccount tries to rollback changes made by `CreateAccount` if parts of it failed.
func (s Service) rollbackCreateAccount(ctx context.Context, acc *proto.Account) {
err := s.index.Delete(acc)
if err != nil {
s.log.Err(err).Msg("failed to rollback account from indices")
}
err = s.repo.DeleteAccount(ctx, acc.Id)
if err != nil {
s.log.Err(err).Msg("failed to rollback account from repo")
}
}
// UpdateAccount implements the AccountsServiceHandler interface
// read only fields are ignored
// TODO how can we unset specific values? using the update mask