mirror/opencloud
1
0
Fork 0
mirror of https://github.com/opencloud-eu/opencloud.git synced 2026-04-14 12:27:50 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor: simplify getting the app url for collabora

Browse Source
This commit is contained in:
Juan Pablo Villafáñez
2024-08-16 11:01:51 +02:00
parent 5ddd51ea84
commit 3d287da5ce
1 changed files with 20 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
services/collaboration/pkg/service/grpc/v0/service.go
View File

@@ -157,20 +157,28 @@ func (s *Service) getAppUrlFor(action, fileExt string) string {
// "edit" urls will be prioritized. Note that "view" url might be returned for
// "read/write" view mode if no "edit" url is found.
func (s *Service) getAppUrl(fileExt string, viewMode appproviderv1beta1.ViewMode) string {
// check view_comment action first (for collabora)
appURL := s.getAppUrlFor("view_comment", fileExt)
// prioritize view action if possible
if viewAppURL := s.getAppUrlFor("view", fileExt); viewAppURL != "" {
appURL = viewAppURL
}
appURL := s.getAppUrlFor("view", fileExt)
// If read/write mode has been requested, prioritize edit action.
// Special case for collabora because it only provides one action per
// extension,
if viewMode == appproviderv1beta1.ViewMode_VIEW_MODE_READ_WRITE || strings.ToLower(s.config.App.Name) == "collabora" {
if editAppURL := s.getAppUrlFor("edit", fileExt); editAppURL != "" {
appURL = editAppURL
if strings.ToLower(s.config.App.Name) == "collabora" {
// collabora provides only one action per extension. usual options
// are "view" (checked above), "edit" or "view_comment" (this last one
// is exclusive of collabora)
if appURL == "" {
if editURL := s.getAppUrlFor("edit", fileExt); editURL != "" {
return editURL
}
if commentURL := s.getAppUrlFor("view_comment", fileExt); commentURL != "" {
return commentURL
}
}
} else {
// If not collabora, there might be an edit action for the extension.
// If read/write mode has been requested, prioritize edit action.
if viewMode == appproviderv1beta1.ViewMode_VIEW_MODE_READ_WRITE {
if editAppURL := s.getAppUrlFor("edit", fileExt); editAppURL != "" {
appURL = editAppURL
}
}
}