mirror/opencloud
1
0
Fork 0
mirror of https://github.com/opencloud-eu/opencloud.git synced 2026-07-13 00:52:01 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(debug): drop duplicate service field from probe fallback log

Browse Source 
The base logger created by log.Configure already attaches a "service"
field via its context. handleProbe added it a second time, producing
JSON log entries with two "service" keys. Remove the redundant
Str("service", name) and the now-unused name parameter.
This commit is contained in:
Dominik Schmidt
2026-05-19 10:29:07 +02:00
parent 66fae3061d
commit 46a8dee126
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
pkg/service/debug/service.go
View File

@@ -18,11 +18,10 @@ import (
graphMiddleware "github.com/opencloud-eu/opencloud/services/graph/pkg/middleware"
)
var handleProbe = func(mux *http.ServeMux, pattern string, h http.Handler, name string, logger log.Logger) {
var handleProbe = func(mux *http.ServeMux, pattern string, h http.Handler, logger log.Logger) {
if h == nil {
h = handlers.NewCheckHandler(handlers.NewCheckHandlerConfiguration())
logger.Info().
Str("service", name).
Str("endpoint", pattern).
Msg("no probe provided, reverting to default (OK)")
}
@@ -45,8 +44,8 @@ func NewService(opts ...Option) *http.Server {
promhttp.Handler(),
))
handleProbe(mux, "/healthz", dopts.Health, dopts.Name, dopts.Logger) // healthiness check
handleProbe(mux, "/readyz", dopts.Ready, dopts.Name, dopts.Logger) // readiness check
handleProbe(mux, "/healthz", dopts.Health, dopts.Logger) // healthiness check
handleProbe(mux, "/readyz", dopts.Ready, dopts.Logger) // readiness check
if dopts.ConfigDump != nil {
mux.Handle("/config", dopts.ConfigDump)