mirror/opencloud
1
0 Fork 0
mirror of https://github.com/opencloud-eu/opencloud.git synced 2026-10-30 01:58:27 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: allow guest link auth for app open and new endpoints

Browse Source
This commit is contained in:
Jannik Stehle committed 2026-10-16 09:54:27 +02:00
1 parent 40095460a1
commit 68cad133a4
2 files changed
+7 -2
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

services/proxy/pkg/middleware/guest_link_auth.go
+2
View File
@@ -38,6 +38,8 @@ var (
"/webdav/",
"/remote.php/webdav/",
"/ocs/v2.php/apps/notifications/api/v1/notifications/sse",
"/app/open",
"/app/new",
}
// unixEpoch is the zero time used for cookie expiration.
services/proxy/pkg/middleware/guest_link_auth_test.go
+5 -2
View File
@@ -44,6 +44,9 @@ func TestGuestLinkAuthenticator_Applicability(t *testing.T) {
{"supported path - dav", true, "some-jwt", "/dav/files/user", AuthenticationFailed},
{"supported path - webdav", true, "some-jwt", "/webdav/files/user", AuthenticationFailed},
{"supported path - remote.php", true, "some-jwt", "/remote.php/dav/files/user", AuthenticationFailed},
{"supported path - app open", true, "some-jwt", "/app/open", AuthenticationFailed},
{"supported path - app new", true, "some-jwt", "/app/new", AuthenticationFailed},
{"unsupported path - app list", true, "some-jwt", "/app/list", AuthenticationNotApplicable},
}
for _, tt := range tests {
@@ -82,7 +85,7 @@ func TestGuestLinkAuthenticator_Applicability(t *testing.T) {
}
func TestGuestLinkAuthenticator_SupportsPathPrefixes(t *testing.T) {
supportedPrefixes := []string{"/graph/v1beta1/me/drive/sharedWithMe", "/graph/v1beta1/roleManagement/permissions/roleDefinitions", "/dav/", "/webdav/", "/remote.php/dav/", "/remote.php/webdav/", "/ocs/v2.php/apps/notifications/api/v1/notifications/sse"}
supportedPrefixes := []string{"/graph/v1beta1/me/drive/sharedWithMe", "/graph/v1beta1/roleManagement/permissions/roleDefinitions", "/dav/", "/webdav/", "/remote.php/dav/", "/remote.php/webdav/", "/ocs/v2.php/apps/notifications/api/v1/notifications/sse", "/app/open", "/app/new"}
for _, prefix := range supportedPrefixes {
t.Run("path prefix "+prefix, func(t *testing.T) {
if !isGuestLinkPath(prefix + "test") {
@@ -91,7 +94,7 @@ func TestGuestLinkAuthenticator_SupportsPathPrefixes(t *testing.T) {
})
}
unsupportedPaths := []string{"/archiver", "/", "/graph/v1beta1/me/drives", "/ocs/", "/ocs/v2.php/apps/notifications/api/v1/notifications", "/konnect/", "/apps/"}
unsupportedPaths := []string{"/archiver", "/", "/graph/v1beta1/me/drives", "/ocs/", "/ocs/v2.php/apps/notifications/api/v1/notifications", "/konnect/", "/apps/", "/app/", "/app/list"}
for _, path := range unsupportedPaths {
t.Run("unsupported "+path, func(t *testing.T) {
if isGuestLinkPath(path) {