use golangci linters

.drone.star

@@ -73,10 +73,10 @@ def testing(ctx):
       },
       {
         'name': 'staticcheck',
-        'image': 'webhippie/golang:1.13',
+        'image': image: golangci/golangci-lint:latest',
         'pull': 'always',
         'commands': [
-          'make staticcheck',
+          golangci-lint run,
         ],
         'volumes': [
           {

.golangci.yml

@@ -0,0 +1,34 @@
+issues:
+  exclude-rules:
+    - path: pkg/proto/v0/settings.pb.go
+      text: "SA1019:"
+      linters:
+        - staticcheck
+    - path: pkg/store/filesystem/io.go
+      text: "SA1019:"
+      linters:
+        - staticcheck
+linters:
+  enable:
+    - bodyclose
+    - deadcode
+    - errcheck
+    - gosimple
+    - govet
+    - ineffassign
+    - staticcheck
+    - structcheck
+    - typecheck
+    - unused
+    - varcheck
+    - depguard
+    - golint
+    - goimports
+    - unconvert
+    - scopelint
+    - maligned
+    - misspell
+    - gocritic
+    - prealloc
+    #- gosec
+

Makefile

@@ -71,9 +71,9 @@ fmt:
 vet:
 	go vet $(PACKAGES)
 
-.PHONY: staticcheck
-staticcheck:
-	go run honnef.co/go/tools/cmd/staticcheck -tags '$(TAGS)' $(PACKAGES)
+# .PHONY: staticcheck
+# staticcheck:
+# 	go run honnef.co/go/tools/cmd/staticcheck -tags '$(TAGS)' $(PACKAGES)
 
 .PHONY: lint
 lint:

tools.go

@@ -7,5 +7,5 @@ import (
 	_ "github.com/mitchellh/gox"
 	_ "github.com/restic/calens"
 	_ "golang.org/x/lint/golint"
-	_ "honnef.co/go/tools/cmd/staticcheck"
+	// _ "honnef.co/go/tools/cmd/staticcheck"
 )