mirror/opencloud
1
0
Fork 0
mirror of https://github.com/opencloud-eu/opencloud.git synced 2026-04-13 11:57:33 -04:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Benedikt Kulmann <benedikt@kulmann.biz>
This commit is contained in:
Jörn Friedrich Dreyer
2020-12-10 08:41:53 +01:00
committed by GitHub
parent da525aeb50
commit f6ac7b7863
2 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
docs/adr/0001-introduce-accounts-service.md
View File

@@ -1,7 +1,7 @@
# 1. Introduce an accounts service
* Status: superseded by [ADR-0003](0003-outsource-user-management.md) <!-- optional -->
* Deciders: @butonic, @felixboehm, @mbarz, @pmaier1 <!-- optional -->
* Deciders: @butonic, @felixboehm, @micbar, @pmaier1 <!-- optional -->
* Date: [2020-06-15](https://github.com/owncloud/ocis-accounts/pull/34/commits/2fd05e2b6fe2a47c687bd0c0bc5e1b5c48a585b2) <!-- optional -->
Technical Story: [persist accounts](https://github.com/owncloud/ocis-accounts/pull/34) <!-- optional -->
@@ -21,16 +21,16 @@ To attach metadata like shares to users ownCloud relies on persistent, non-reass
## Considered Options
* Accounts service wraps LDAP
* GLauth wraps accounts service
* [GLAuth](https://github.com/glauth/glauth) wraps accounts service
## Decision Outcome
Chosen option: "GLauth wraps accounts service", because we need write access to provision guest accounts and [GLauth](https://github.com/glauth/glauth) currently has no write support.
Chosen option: "GLAuth wraps accounts service", because we need write access to provision guest accounts and GLAuth currently has no write support.
### Positive Consequences <!-- optional -->
* We can build a self contained user management in the accounts service and can adjust it to our requirements.
* We do not rely on an LDAP server which would only be possible by implementing write support in the LDAP libraries used by GLauth which (hard to estimate effort, when will that be merged upstream).
* We do not rely on an LDAP server which would only be possible by implementing write support in the LDAP libraries used by GLAuth (hard to estimate effort, when will that be merged upstream).
### Negative Consequences <!-- optional -->

14
docs/adr/0003-outsource-user-management.md
View File

@@ -18,19 +18,19 @@ To attach metadata like shares to users ownCloud relies on persistent, non-reass
## Considered Options
* Accounts service wraps LDAP
* GLauth wraps accounts service
* [GLauth](https://github.com/glauth/glauth) wraps accounts service
## Decision Outcome
Chosen option: "Move accounts functionality to GLauth and name it accounts", by moving the existing accounts service file based persistence to glauth and use it as a drop in replacement for an LDAP server. The reverse index and web ui existing in the accounts service will move as well in order to make glauth a standalone, small scale user management with write capabilities.
Chosen option: "Move accounts functionality to GLAuth and name it accounts", by moving the existing accounts service file based persistence to GLAuth and use it as a drop in replacement for an LDAP server. The reverse index and web ui existing in the accounts service will move as well in order to make GLAuth a standalone, small scale user management with write capabilities.
### Product summary
- GLauth is a drop in user management for small scale deployments.
- OCIS admins can either use the web ui to manage users in glauth or use existing tools in their IDM.
- We hide the complexity by embedding OpenID Provider, an LDAP server and a user management web ui.
- GLAuth is a drop in user management for small scale deployments that don't rely on an actual LDAP.
- OCIS admins can either use the web ui to manage users in GLAuth or use existing tools in their IDM.
- We hide the complexity by embedding an OpenID Provider, an LDAP server and a user management web ui.
### Resulting deployment options
- Single binary: admin can manage users, groups and roles using the built in web ui (glauth)
- Single binary: admin can manage users, groups and roles using the built in web ui (GLAuth)
- External LDAP: OCIS admin needs to use existing tool to manage users
- Separate OCIS and LDAP admin: OCIS admin relies on the LDAP admin to manage users
@@ -51,7 +51,7 @@ Chosen option: "Move accounts functionality to GLauth and name it accounts", by
## Pros and Cons of the Options <!-- optional -->
### GLauth wraps accounts service
### GLAuth wraps accounts service
Currently, the accounts service is the source of truth and we use it to implement user management. <!-- optional -->