mirror/opencloud
1
0
Fork 0
mirror of https://github.com/opencloud-eu/opencloud.git synced 2026-01-21 04:18:21 -05:00
Code Issues Packages Projects Releases Wiki Activity

[full-ci] [tests-only] Added tests for enabling share sync with empty resource id (#8963)

Browse Source 
* Added tests for enabling share sync with empty resource id

* Addressed reviews
This commit is contained in:
Prarup Gurung
2024-04-26 14:20:59 +05:45
committed by GitHub
parent b7d9ae89ee
commit f7fb0bc591
2 changed files with 48 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
tests/acceptance/features/apiSharingNg/enableDisableShareSync.feature
View File

@@ -300,7 +300,8 @@ Feature: enable or disable sync of incoming shares
@issue-8724
Scenario: try to enable share sync of a non-existent resource
When user "Brian" tries to enable share sync of a non-existent resource using the Graph API
Given user "Brian" has disabled the auto-sync share
When user "Brian" tries to enable share sync of a resource "nonexistent" using the Graph API
Then the HTTP status code should be "400"
And the JSON data of the response should match
"""
@@ -334,3 +335,41 @@ Feature: enable or disable sync of incoming shares
}
}
"""
Scenario: try to enable share sync with empty resource id
Given user "Brian" has disabled the auto-sync share
When user "Brian" tries to enable share sync of a resource "" using the Graph API
Then the HTTP status code should be "400"
And the JSON data of the response should match
"""
{
"type": "object",
"required": ["error"],
"properties": {
"error": {
"type": "object",
"required": [
"code",
"innererror",
"message"
],
"properties": {
"code" : {
"const": "invalidRequest"
},
"innererror" : {
"type": "object",
"required": [
"date",
"request-id"
]
},
"message" : {
"const": "invalid id"
}
}
}
}
}
"""

12
tests/acceptance/features/bootstrap/SharingNgContext.php
View File

@@ -165,7 +165,7 @@ class SharingNgContext implements Context {
public function userTriesToListThePermissionsOfSpaceUsingPermissionsEndpointOfTheGraphApi(string $user, string $space, string $spaceOwner):void {
$spaceId = ($this->spacesContext->getSpaceByName($spaceOwner, $space))["id"];
$itemId = $this->spacesContext->getResourceId($spaceOwner, $space, '');
$this->featureContext->setResponse(
GraphHelper::getPermissionsList(
$this->featureContext->getBaseUrl(),
@@ -741,20 +741,24 @@ class SharingNgContext implements Context {
}
/**
* @When user :user tries to enable share sync of a non-existent resource using the Graph API
* @When user :user tries to enable share sync of a resource :resource using the Graph API
*
* @param string $user
* @param string $resource
*
* @return void
* @throws Exception|GuzzleException
*/
public function userTriesToEnablsShareSyncOfNonExistentResourceUsingTheGraphApi(string $user):void {
public function userTriesToEnableShareSyncOfResourceUsingTheGraphApi(string $user, string $resource):void {
$shareSpaceId = FeatureContext::SHARES_SPACE_ID;
$itemId = ($resource === 'nonexistent') ? WebDavHelper::generateUUIDv4() : '';
$response = GraphHelper::enableShareSync(
$this->featureContext->getBaseUrl(),
$this->featureContext->getStepLineRef(),
$this->featureContext->getActualUsername($user),
$this->featureContext->getPasswordForUser($user),
WebDavHelper::generateUUIDv4(),
$itemId,
$shareSpaceId
);
$this->featureContext->setResponse($response);