Commit Graph

22800 Commits

Author SHA1 Message Date
Pascal Bleser
1bf3b7d502 fix(groupware): fix JMAP error handling
* the JMAP error handling was not working properly, fixed it and added
   error definitions accordingly

 * add operations to retrieve mailbox roles and mailboxes by role for
   all accounts
2026-02-23 09:37:28 +01:00
Pascal Bleser
c858c77ed1 refactor(groupware): rename "Messages" to "Email" everywhere
There was really no reason to go with "Messages" as far as the
vocabulary of the Groupware API goes, since the objects those APIs serve
are "Emails", to stick with the wording of the JMAP specification.
2026-02-23 09:37:28 +01:00
Pascal Bleser
0b09f226c0 refactor(groupware): use a function for multi-account method call IDs
* introduce a function 'mcid' to assemble method call IDs per account
   instead of doing that inline in each function, in case the rules for
   doing so change in the future
2026-02-23 09:37:28 +01:00
Pascal Bleser
63ff697041 docs(groupware): add services/groupware/DEVELOPER.md 2026-02-23 09:37:28 +01:00
Pascal Bleser
04fb3ab2cd refactor(groupware): add max requests check
* move jmap.request() to jmap.Client.request() and pass the Session
   and a Logger to introduce checking the number of methodCalls within a
   request not exceeding the limit of the Session, as well as error
   handling and logging there instead of in each caller

 * a few bugfixes:
   - add a few missing Send() calls in logs
   - correct the response tag matching for
     GetMailboxChangesForMultipleAccounts
   - fix typo in Identity.ReplyTo json serialization rune
   - fix response tag in pkg/jmap/testdata/mailboxes1.json after
     changing them to be prefixed by the accountId
2026-02-23 09:37:28 +01:00
Pascal Bleser
5b1bab01dc groupware: minor typo fixes 2026-02-23 09:37:28 +01:00
Pascal Bleser
3e5337be6d chore(groupware): add launcher for OC + containers for services
* add a launcher for running OpenCloud from within VSCode, but using
   third-party services that are running within the docker compose
   'full' example setup
2026-02-23 09:37:28 +01:00
Pascal Bleser
5a5e02fd19 feat(groupware): add fetching all mailboxes for all accounts
* add URL to retrieve all the mailboxes for all the accounts of a user,
   as a first use-case for an all-accounts operation, as
   /accounts/all/mailboxes

 * add URL to retrieve mailbox changes for all the mailboxes of all the
   accounts of a user, as a first use-case for an all-accounts
   operation, as /accounts/all/mailboxes/changes

 * change the defaultAccountId from '*' to '_', as '*' rather indicates
   "all" than "default", and we might want to use that for "all
   accounts" operations in the future

 * refactor(groupware): remove the accountId parameter from the logger()
   function, as it is not used anyways, but also confusing for
   operations that support multiple account ids
2026-02-23 09:37:28 +01:00
Pascal Bleser
02be7b3a9a docs(groupware): OpenAPI improvements
* refactor some pkg/jmap and groupware methods to make more sense from
   an API point-of-view

 * add path parameter documentation, but automate it by injecting their
   definition into the OpenAPI YAML tree that is extracted from the
   source code using go-swagger as it is too cumbersome, repetitive and
   error-prine to document them in the source code; wrote a TypeScript
   file apidoc-process.ts to do so

 * add generating an offline HTML file for the OpenAPI documentation
   using redocly, and injecting a favicon into the resulting HTML; wrote
   a TypeScript file apidoc-postprocess-html.ts to do so
2026-02-23 09:37:28 +01:00
Pascal Bleser
598dbca6a3 test(groupware): add testcontainers based jmap test
* adds pkg/jmap/jmap_integration_test.go

 * uses ghcr.io/stalwartlabs/stalwart:v0.13.2-alpine

 * can be disabled by setting one of the following environment
   variables, in the same fashion as ca0493b28
   - CI=woodpecker
   - CI_SYSTEM_NAME=woodpecker
   - USE_TESTCONTAINERS=false

 * dependencies:
   - bump github.com/go-test/deep from 1.1.0 to 1.1.1
   - add github.com/cention-sany/utf7
   - add github.com/dustinkirkland/golang-petname
   - add github.com/emersion/go-imap/v2
   - add github.com/emersion/go-message
   - add github.com/emersion/go-sasl
   - add github.com/go-crypt/crypt
   - add github.com/go-crypt/x
   - add github.com/gogs/chardet
   - add github.com/inbucket/html2text
   - add github.com/jhilleryerd/enmime/v2
   - add github.com/ssor/bom
   - add gopkg.in/loremipsum.v1
2026-02-23 09:37:26 +01:00
Pascal Bleser
a3566e0ff7 refactor(groupware): session cache and DNS autodiscovery
* move the logging of the username and session state away from pkg/jmap
   and into services/groupware

 * introduce more decoupling for the session cache, as well as moving
   the implementation into groupware_session.go
2026-02-23 09:34:45 +01:00
Pascal Bleser
5f9cea766b groupware: add DNS auto-discovery (currently disabled, needs testing) 2026-02-23 09:34:45 +01:00
Pascal Bleser
5a29901f3b add a .gitignore entry for debug binaries built by VSCode when running OpenCloud 2026-02-23 09:34:45 +01:00
Pascal Bleser
56831fd973 groupware: session handling improvements
* remove the baseurl from the JMAP client configuration, and pass it to
   the session retrieval functions instead, as that is really the only
   place where it is relevant, and we gain flexibility to discover that
   session URL differently in the future without having to touch the
   JMAP client

 * move the default account identifier handling from the JMAP package to
   the Groupware one, as it really has nothing to do with JMAP itself,
   and is an opinionated feature of the Groupware REST API instead

 * add an event listener interface for JMAP events to be more flexible
   and universal, typically for metrics that are defined on the API
   level that uses the JMAP client

 * add errors for when default accounts cannot be determined

 * split groupware_framework.go into groupware_framework.go,
   groupware_request.go and groupware_response.go

 * move the accountId logging into the Groupware level instead of JMAP
   since it can also be relevant to other operations that might be
   worthy of logging before the JMAP client is even invoked
2026-02-23 09:34:45 +01:00
Pascal Bleser
462a0b40df groupware: fix debug server, was missing a lot of configuration options and was binding to :80 2026-02-23 09:34:45 +01:00
Pascal Bleser
f4b0866958 docs(groupware): add Groupware related ADRs 2026-02-23 09:34:45 +01:00
Pascal Bleser
f739d05f40 refactor(groupware): logging and metrics improvements
* some minor code refactorings to improve logging and metrics

 * more code documentation
2026-02-23 09:34:45 +01:00
Pascal Bleser
cedf5b9df0 jmap: minor logging improvements 2026-02-23 09:34:45 +01:00
Pascal Bleser
a2917dea90 groupware: improve metrics
* implement more metrics, in a more streamlined fashion

 * use concurrent-map to store SSE streams instead of a regular map with
   one big lock that will not scale when it grows, causing too much
   contention on that one lock

 * while testing error metrics, noticed a few bugs with error handling
   when Stalwart is down: fixed
2026-02-23 09:34:45 +01:00
Pascal Bleser
bf7b8d7868 groupware: jmap: add metrics 2026-02-23 09:34:45 +01:00
Pascal Bleser
8b5d8aedfd groupware: implement metrics
* implement a framework for metrics, with a few exemplary ones
2026-02-23 09:34:45 +01:00
Pascal Bleser
d86de66a15 groupware: Etag handling
* implement correct Etag and If-None-Match handling, responding with
   304 Not Modified if they match

 * introduce SessionState and State string type aliases to ensure we are
   using the correct fields for those, respectively

 * extract the SessionState from the JMAP response bodies in the
   groupware framework instead of having to do that in every single
   groupware API

 * use uint instead of int in some places to clarify that the values are
   >= 0

 * trace-log how long a Session was held in cache before being evicted

 * add Trace-Id header handling: add to response when specified in
   request, and implement a custom request logger to include it as a
   field

 * implement a more compact trace-logging of all the methods and URIs
   that are served, to put them into a single log entry instead of
   creating one log entry for every URI
2026-02-23 09:34:45 +01:00
Pascal Bleser
f2b1d11ace groupware: initial related emails implementation with SSE 2026-02-23 09:34:45 +01:00
Pascal Bleser
00d189cb04 groupware: add /bootstrap
* add a GET /accounts/{a}/boostrap URI that delivers the same as GET /
   but also mailboxes for a given account, in case the UI remembers the
   last used account identifier, to avoid an additional roundtrip

 * streamline the use of simpleError()

 * add logging of errors at the calling site

 * add logging of evictions of Sessions from the cache

 * change default Session cache TTL to 5min instead of 30sec
2026-02-23 09:34:45 +01:00
Pascal Bleser
ab0a24c46d groupware: swagger API documentation improvements
* add more documentation for properties

 * fixes after a bit of trial-and-error with go-swagger

 * fix email filter marshalling when there are no search criteria

 * introduce an apidoc.yml that contains Swagger data and is merged when
   generating the swagger.yml from sources
2026-02-23 09:34:45 +01:00
Pascal Bleser
9dbb1082d3 Groupware improvements
* ensure that all the jmap responses contain the SessionState

 * implement missing errors that were marked as TODO

 * moved common functions from pkg/jmap and pkg/services/groupware to
   pkg/log and pkg/structs to commonalize them across both source trees

 * implement error handling for SetError occurences

 * Email: replace anonymous map[string]bool for mailbox rights with a
   MailboxRights struct, as the keys are well-defined, which allows for
   properly documenting them

 * introduce ObjectType as an "enum"

 * fix JSON marshalling and unmarshalling of EmailBodyStructure

 * move the swagger documentation structs from groupware_api.go to
   groupware_docs.go

 * fix: change verb for /groupware/accounts/*/vacation from POST to PUT
2026-02-23 09:34:45 +01:00
Pascal Bleser
8659dfa571 groupware: minor email searching response improvements + started implementing vacation response setting API 2026-02-23 09:34:45 +01:00
Pascal Bleser
7e5c0945fe groupware: add identities of all accounts to the index resource 2026-02-23 09:34:45 +01:00
Pascal Bleser
756f2ac388 groupware: fix email search, add variant that includes the full emails 2026-02-23 09:34:45 +01:00
Pascal Bleser
ad4ca849de groupware: fix email search, add variant that includes the full emails 2026-02-23 09:34:45 +01:00
Pascal Bleser
aa6eb09630 Groupware: refactor jmap package, implement Email/set, EmailSubmission
* refactor the jmap package to split it into several files as the
   jmap.api.go file was becoming too unwieldy

 * refactor the Groupware handler function response to be a Response
   object, to be more future-proof and avoid adding more and more
   return parameters while handling "no content" response as well

 * more godoc for the JMAP model

 * add Email creation, updating, deleting (Email/set,
   EmailSubmission/set)

 * add endpoints
   - POST /accounts/{accountid}/messages
   - PATCH|PUT /accounts/{accountid}/messages/{messageid}
   - DELETE /accounts/{accountid}/messages/{messageid}
2026-02-23 09:34:45 +01:00
Pascal Bleser
b7a7c9526b groupware: implement message search with snippets 2026-02-23 09:34:45 +01:00
Pascal Bleser
9342db5efb groupware: blob streaming (upload and download) 2026-02-23 09:34:45 +01:00
Pascal Bleser
bf459ba2b2 groupware: more JMAP operations implementation 2026-02-23 09:34:45 +01:00
Pascal Bleser
ee72727410 groupware: further implementation and improvements 2026-02-23 09:34:45 +01:00
Pascal Bleser
2102975228 upgrade Stalwart to 0.13.2 2026-02-23 09:34:45 +01:00
Pascal Bleser
d392718d5f refactored the Session object, refactored the services/groupware directory, and started Swagger documentation implementation 2026-02-23 09:34:45 +01:00
Pascal Bleser
967ad602a9 groupware: refactoring the API mechanisms 2026-02-23 09:34:45 +01:00
Pascal Bleser
892fe602d5 groupware: implement JSON:API's error response format, with a revamped error handling in jmap and services/groupware 2026-02-23 09:34:45 +01:00
Pascal Bleser
bc333500cd Refactor groupware service after ADR decision on the Groupware API
* after having decided that the Groupware API should be a standalone
   independent custom REST API that is using JMAP data models as much as
   possible,
 * removed Groupware APIs from the Graph service
 * moved Groupware implementation to the Groupware service, and
   refactored a few things accordingly
2026-02-23 09:34:45 +01:00
Pascal Bleser
eba724249c Groupware and jmap: cleanup and API documentation 2026-02-23 09:34:45 +01:00
Pascal Bleser
5ad99311f7 groupware: remove unneeded messages.go that was a remainder from an earlier implementation attempt, which also fixes compilation issues due to changes in main 2026-02-23 09:34:45 +01:00
Pascal Bleser
f14e60d47e opencloud_full: upgrade Stalwart to 0.12.5, and use the ghcr.io container repository to avoid Hub limits 2026-02-23 09:34:45 +01:00
Pascal Bleser
a29108f37e Groupware improvements: refactoring, k6 tests
* refactored the models to be strongly typed with structs and mapstruct
   to decompose the dynamic parts of the JMAP payloads

 * externalized large JSON strings for tests into .json files under
   testdata/

 * added a couple of fantasy Graph groupware APIs to explore further
   options

 * added k6 scripts to test those graph/me/messages APIs, with a setup
   program to set up users in LDAP, fill their IMAP inbox, activate them
   in Stalwart, cleaning things up, etc...
2026-02-23 09:34:45 +01:00
Pascal Bleser
ba747bfcf8 fix Stalwart LDAP configuration 2026-02-23 09:34:45 +01:00
Pascal Bleser
bb3b82420a Use password policy overlay in LDAP and configure Stalwart to use it 2026-02-23 09:34:45 +01:00
Pascal Bleser
b2af600d42 upgrade Stalwart to 0.12.4 2026-02-23 09:34:45 +01:00
Pascal Bleser
7b2a227d91 groupware: removed debugging logs 2026-02-23 09:34:45 +01:00
Pascal Bleser
4afba6c21f jwkset: remove debugging printlns 2026-02-23 09:34:45 +01:00
Pascal Bleser
fa836f5a98 auth-api: fix: was missing newly introduced metrics 2026-02-23 09:34:45 +01:00