Commit Graph

23551 Commits

Author SHA1 Message Date
Pascal Bleser
7ed065ddfe groupware: fix query objects in a container with multiple suppliers
* by adding a predicate that can analyze a filter and inform the
   template methods whether the filter is applicable for that supplier
   or not

 * this fixed /groupware/accounts/.../addressbooks/.../contacts
2026-07-01 14:57:32 +02:00
Pascal Bleser
0e71922282 groupware: fix NPE when flattening durations in slist() 2026-07-01 14:57:32 +02:00
Pascal Bleser
d460b42a68 groupware: upgrade traefik in opencloud_full from 3.3.1 to 3.7.5 2026-07-01 14:57:32 +02:00
Pascal Bleser
faa1b9cca7 stalwart.yml: remove image tag for stalwart-import, which makes a 'docker compose pull' fail needlessly 2026-07-01 14:57:32 +02:00
Pascal Bleser
7fd1fa22cd stalwart-snapshot-passwords: fix for Node, and beautify 2026-07-01 14:57:32 +02:00
Pascal Bleser
02e53fe110 groupware: introduce temporary configuration property GROUPWARE_ENABLE_MOCK_DATA that controls whether the mock addressbook and mock contacts should be injected or not; default is false/disabled since it is not fully functional yet 2026-07-01 14:57:32 +02:00
Pascal Bleser
845026d3f0 groupware: upgrade Stalwart to 0.16.9 in opencloud_full 2026-07-01 14:57:32 +02:00
Pascal Bleser
ea2fee0cad groupware: upgrade Stalwart to 0.16.9 for integration tests 2026-07-01 14:57:32 +02:00
Pascal Bleser
15cedb747a groupware: remove middleware.RealIP, as it has been deprecated and we currently do not have a use for it 2026-07-01 14:57:31 +02:00
Pascal Bleser
3e4325e408 groupware: downgrade to Go 1.25 since our building images are only available for 1.25 at the moment
* retrofit from using self-referencing generics parameters that were
   introduced with Go 1.26, will re-enable when we upgrade to 1.26

 * re-introduce a 'ptr' func since we don't have the new 'new' func yet
   that comes with 1.26
2026-07-01 14:57:31 +02:00
Pascal Bleser
276edc2fca opencloud_full: add healthchecks for traefik, opencloud and stalwart to the docker compose project 2026-07-01 14:57:31 +02:00
Pascal Bleser
6364dda354 groupware: fix GROUPWARE_JMAP_MASTER_USERNAME to Stalwart 0.16 requirements for using the primary email instead of the username 2026-07-01 14:57:31 +02:00
Pascal Bleser
ce40fe3584 groupware: fix building the stalwart:cli container
* fix the inline dockerfile for building the stalwart:cli container,
   cannot be based on scratch since we need a shell and wget, and it
   should thus retain the alpine container as its base

 * remove stdin_open and tty from the container attributes, not needed
2026-07-01 14:57:31 +02:00
Pascal Bleser
c12dcd5741 groupware: fix the 'opencloud-certs' container to set necessary permissions on the files or the opencloud container can't access them 2026-07-01 14:57:31 +02:00
Pascal Bleser
acb8a00929 groupware: update developer guide
* add instructions and container to create a key and certificate pair
   for the built-in IDM LDAP as we need it to listen on LDAPS for
   Stalwart, which has been disabled by default with
   https://github.com/opencloud-eu/opencloud/pull/2880

 * add environment variables to point to the certificates

 * update services/groupware/DEVELOPERS.md with up-to-date instructions,
   using Stalwart 0.16
2026-07-01 14:57:31 +02:00
Pascal Bleser
c545d362e9 groupware: minor fix for the mock addressbook supplier 2026-07-01 14:57:31 +02:00
Pascal Bleser
cbd09869a3 groupware: VSCode launcher: change GROUPWARE_JMAP_MASTER_USERNAME from 'master' to 'admin@example.org' to make it work with Stalwart >= 0.16 2026-07-01 14:57:31 +02:00
Pascal Bleser
9d59074f93 groupware: move prefixed writer into export_integration_test.go + upgrade integration tests to Stalwart 0.16.8 + update Stalwart configuration to include necessary default roles 2026-07-01 14:57:31 +02:00
Pascal Bleser
45664cb3c4 groupware: upgrade opencloud_full to Stalwart 0.16.8 and fix configuration by adding default roles as well as adding the 'impersonate' permission on the admin@example.org user 2026-07-01 14:57:31 +02:00
Pascal Bleser
7849ed0c71 groupware: jmap: add a test for Invocation seriaization 2026-07-01 14:57:31 +02:00
Pascal Bleser
6eda879e6a groupware: port opencloud_full to Stalwart 0.16 (only the built-in IDM LDAP option for now) 2026-07-01 14:57:31 +02:00
Pascal Bleser
fe000d08e9 groupware: simplify JMAP integration tests with Stalwart 0.16
* don't run the Stalwart container in recovery mode first, just run it
   in "proper" mode, import the configuration and use it like that,
   which only requires skipping the "destroy" steps

 * add code documentation and logging

 * replace the text templating of the Stalwart snapshot by doing the
   same as the formatting script was doing, but directly in Go, removing
   an additional step to perform when modifying a Stalwart
   configuration to use in the integration tests
2026-07-01 14:57:31 +02:00
Pascal Bleser
fbede45a34 groupware: port tests to Stalwart 0.16.7 2026-07-01 14:57:31 +02:00
Pascal Bleser
d1afd75370 groupware: fix unit tests 2026-07-01 14:57:31 +02:00
Pascal Bleser
5fd6f96ad6 groupware: add tracking of backend call durations
* add new configuration setting GROUPWARE_SEND_DURATIONS_RESPONSE
   (defaults to false)

 * keep track of lists of durations of backend calls

 * when enabled, report them as response headers Durations (human
   readable) and Durations-Nanos (as raw nanosecond values for machine
   consumption)
2026-07-01 14:57:31 +02:00
Pascal Bleser
55424b6317 groupware: add strongly typed aliases for AccountId, PrincipalId and SupplierId
Purpose is to make APIs and parameters easier to understand, since plain
strings are used all over the place for all sorts of identifiers.
2026-07-01 14:57:31 +02:00
Pascal Bleser
8be9c5f807 groupware: remove unneeded jmap.QueryCommand methods
* remove the following methods on the jmap.QueryCommand interface, as
   they ended up not being needed:
   - GetPosition()
   - GetAnchor()
   - GetAnchorOffset()
   - GetLimit()
2026-07-01 14:57:31 +02:00
Pascal Bleser
15d708fa37 groupware: refactoring for pagination and support for multiple query suppliers
* refactor APIs in JMAP and Groupware in order to implement pagination
   across multiple accountIds and multiple suppliers (currently
   implemented using a mock supplier for contacts)

 * requires go 1.26 due to use of self-reflecting generics type
   constraints

 * still missing: query criteria and sorting parameters

 * still missing: multi-accountId support for emails

 * errors are now all just 'error' in the APIs, instead of the
   specialized implementations, and are interpreted dynamically where
   necessary in order to transform them into HTTP responses

 * remove position, anchor, anchorOffset as individual query parameters
   as we now only support a 'next=...' token for subsequent pages
   (except in emails for now), and use jmap.QueryParams instead; those
   tokens have a header character for the format, followed by a JSON
   encoded QueryParams map, all wrapped into base62 to make it clearer
   that it is meant to be an opaque token, and not a parameter clients
   should tinker with or construct themselves

 * introduce QueryParamsSupplier as an interface to provide QueryParams
   for various scenarios (single supplier, multiple supplier, ...) per
   accountId

 * implement multi-supplier template methods slist and squery
2026-07-01 14:57:31 +02:00
Pascal Bleser
e3febe95f7 groupware: API documentation updates 2026-07-01 14:57:31 +02:00
Pascal Bleser
dfd8677b93 groupware: refactor responses to a jmap.Response object
* in the JMAP API as well as in several places in the Groupware
   framework, use a single jmap.Response[T] object to return the
   payload, the language, the session state and the etag/state instead
   of individual multi-valued return values
2026-07-01 14:57:31 +02:00
Pascal Bleser
673e337729 groupware: fix test logic error in the JMAP ws integration test 2026-07-01 14:57:31 +02:00
Pascal Bleser
65b050200f groupware: omit "position" when "anchor" is specified in queries
* the "position" attribute is always set to 0 when using an anchor for
   pagination, but it does not accurately reflect the position and thus
   we decided to remove the attribute from the resulting object for
   clarity

 * omit "canCalculateChanges" attribute when its value is "true", which
   is going to be the case in 100% of calls against Stalwart
2026-07-01 14:57:31 +02:00
Pascal Bleser
b0341139e1 groupware: add support for anchor and anchor offset pagination
* add query parameters 'anchor' and 'offset':
   - anchor is an object identifier
   - offset is a numeric offset relative to the anchor
2026-07-01 14:57:31 +02:00
Pascal Bleser
c8a02f5c9b groupware: fix use of ?limit=0
* JMAP query limit of 0 is synonymous with "no limit", but we actually
   want to be able to perform queries without any results, for cases
   where we only want to count the total number of objects, and also
   because it makes more sense semantically

 * introduce query parameter validation checks, in order to only allow
   query parameters that are actually supported, which is going to be
   useful during development of clients
2026-07-01 14:57:31 +02:00
Pascal Bleser
4c789391ed groupware: add documentation for SearchResultsTemplate + update pnpm 2026-07-01 14:57:31 +02:00
Pascal Bleser
9d428ca27e groupware: rename 'offset' to 'position' to be consistent with the JMAP specification 2026-07-01 14:57:31 +02:00
Pascal Bleser
2863d7f474 groupware: fix getall template result type: []T instead of RESP 2026-07-01 14:57:31 +02:00
Pascal Bleser
4f9e0cf70a groupware: fixes after rebasing and Docker library API changes 2026-07-01 14:57:31 +02:00
Pascal Bleser
a50e1ab891 groupware: documentation changes after API generator updates for the use of template functions 2026-07-01 14:57:31 +02:00
Pascal Bleser
ec1049cd89 groupware: refactoring using function templates
* adds creating addressbooks, calendars, mailboxes

 * adds deleting mailbox, event, identity

 * adds modifying an email

 * introduce template functions for the Groupware API in templates.go,
   and use those in route function implementations whenever possible

 * add capability checking for mail, quota, blobs

 * adds Changes interface

 * adds JmapResponse interface
2026-07-01 14:57:31 +02:00
Pascal Bleser
911ab62d72 structs: add tests and documentation 2026-07-01 14:57:31 +02:00
Pascal Bleser
c5239d7410 groupware: add endpoints to patch addressbooks, contacts, calendars, events 2026-07-01 14:57:31 +02:00
Pascal Bleser
d330d47898 groupware: improve tests
* jmap: add UpdateContactCard and UpdateCalendarEvent funcs
 * use JSON marshalling and unmarshalling into a map for toPatch()
   implementations
 * add updating ContactCards and CalendarEvents to tests
 * add deleting ContactCards and CalendarEvents to tests
 * make query response totals work when the value is 0
 * tests: use CreateContactCard and CreateCalendarEvent funcs to create
   objects in tests instead of using a different JMAP stack that works
   with untyped maps
2026-07-01 14:57:31 +02:00
Pascal Bleser
b40f878630 groupware: refactoring: pass object type instead of namespaces
* make the JMAP internal API a bit more future-proof by passing
   ObjectType objects instead of the JMAP namespaces

 * remove the new attempt to contain operations even further using the
   Factory objects

 * move CalendarEvent operations to its own file, like everything else

 * fix email tests

 * ignore WS error when closing an already closed connection
2026-07-01 14:57:31 +02:00
Pascal Bleser
ff51e34254 groupware: refactor for conciseness
* introduce jmap.Context to hold multiple parameters and shorten
   function calls

 * introduce SearchResultsTemplate
2026-07-01 14:57:31 +02:00
Pascal Bleser
d1d88a5f9e groupware: model refactoring, introducing typed interfaces and Foo
* move ContactCard from jscontact to jmap, as it is actually a JMAP
   specification item, but also was causing too many issues with
   circular references from jscontact -> jmap

 * introduce Foo, Idable, GetRequest, GetResponse, etc... types and
   generics

 * first attempt at a Foo factory type for Mailboxes, needs to be
   expanded to further minimize repetition

 * add more specialized template functions to avoid repetition

 * introduce ChangesTemplate[T] for *Changes structs
2026-07-01 14:57:31 +02:00
Pascal Bleser
7a161bcd0f groupware: significant refactorings of the JMAP framework, adding methods and more intelligence to the various request and response types to improve the use of template functions, reducing the risks of typos and copy/paste mistakes 2026-07-01 14:57:31 +02:00
Pascal Bleser
d0cba2efd1 groupware: add addressbook and calendar creation APIs
* add Groupware APIs for creating and deleting addressbooks

 * add Groupware APIs for creating and deleting calendars

 * add JMAP APIs for creating and deleting addressbooks, calendars

 * add JMAP APIs to retrieve Principals

 * fix API tagging

 * move addressbook JMAP APIs into its own file

 * move addressbook Groupware APIs into its own file
2026-07-01 14:57:31 +02:00
Pascal Bleser
9991e07d97 groupware: add GetIdentityChanges 2026-07-01 14:57:31 +02:00
Pascal Bleser
69ea093ac7 groupware: bump @redocly/cli 2.24.0 -> 2.25.2 2026-07-01 14:57:31 +02:00