Commit Graph

23063 Commits

Author SHA1 Message Date
Pascal Bleser
eaa4cd9ac1 (chore) groupware: tests/groupware: upgrade dependencies 2026-04-03 15:43:06 +02:00
Pascal Bleser
cf824b5447 groupware: fix typos and minor issues
- fix a bunch of minor issues and typos that were found using GoLand
   and gosec

 - add a gosec Makefile target for Groupware related files, in
   services/groupware/Makefile

 - enable checking JMAP session capabilities for events and contacts,
   and only enable skipping that check for tasks until those are
   implemented in Stalwart as well

 - fix a CWE-190 (integer overflow or wraparound) found by gosec

 - consistently use struct references for methods of Groupware and
   Request, instead of mixing up references and copies

 - always log errors when unable to register a Prometheus metric
2026-04-03 15:43:06 +02:00
Pascal Bleser
e141a7c8e0 groupware: devtools: add email encryption settings to idmldap.toml 2026-04-03 15:43:06 +02:00
Pascal Bleser
76b1f1d251 groupware: upgrade redocly/cli 2.15.1 -> 2.20.2 2026-04-03 15:43:06 +02:00
Pascal Bleser
3b9df9260d groupware: use master auth in launcher 2026-04-03 15:43:06 +02:00
Pascal Bleser
499fc0fe42 groupware: upgrade Stalwart image in integration tests from 0.15.0 to 0.15.5 2026-04-03 15:43:06 +02:00
Pascal Bleser
493e3c1636 groupware: upgrade Stalwart image in opencloud_full from 0.15.0 to 0.15.5 2026-04-03 15:43:06 +02:00
Pascal Bleser
57d2a74215 groupware: add UI example of a ContactCard to the documented examples 2026-04-03 15:43:06 +02:00
Pascal Bleser
3c7c902aae groupware: minor logging improvements to the session cache 2026-04-03 15:43:06 +02:00
Pascal Bleser
e2294a5e82 groupware: add OIDC authentication support between Groupware backend and Stalwart
* re-implement the auth-api service to authenticate Reva tokens
   following the OIDC Userinfo endpoint specification

 * pass the context where necessary and add an authenticator interface
   to the JMAP HTTP driver, in order to select between master
   authentication (which is used when GROUPWARE_JMAP_MASTER_USERNAME and
   GROUPWARE_JMAP_MASTER_PASSWORD are both set) and OIDC token
   forwarding through bearer auth

 * add Stalwart directory configuration "idmoidc" which uses the
   OpenCloud auth-api service API (/auth/) to validate the token it
   received as bearer auth from the Groupware backend's JMAP client,
   using it as an OIDC Userinfo endpoint

 * implement optional additional shared secret to secure the Userinfo
   service, as an additional path parameter
2026-04-03 15:43:06 +02:00
Pascal Bleser
322ba160cc groupware: remove remnants of go-swagger documentation, since we are switching to using our own tool instead 2026-04-03 15:43:06 +02:00
Pascal Bleser
b19380cf70 groupware: add jscontact examples, and move them to jmap/model_examples.go to avoid dependency recursion 2026-04-03 15:43:06 +02:00
Pascal Bleser
84f8aa51c8 groupware: use the OIDC client ID 'web' instead of 'groupware' 2026-04-03 15:43:05 +02:00
Pascal Bleser
521d220a25 groupware: add STALWART_AUTH_DIRECTORY variable to .env 2026-04-03 15:43:05 +02:00
Pascal Bleser
1d4edaffaf groupware: as suggested in the review PR 1994, remove all filename prefixes that match the package (groupware_xyz.go -> xyz.go), for groupware, jmap, jscontact, jscalendar 2026-04-03 15:43:05 +02:00
Pascal Bleser
657ccf21cc groupware: update DEVELOPERS.md based on Jörn's feedback 2026-04-03 15:43:05 +02:00
Pascal Bleser
57439db71b auth-api: deal with errors properly in NewService 2026-04-03 15:43:05 +02:00
Pascal Bleser
7843a4a583 groupware: set GROUPWARE_JMAP_BASE_URL to use the variable STALWART_DOMAIN, in order to make things work correctly when using the non-default value for STALWART_DOMAIN 2026-04-03 15:43:05 +02:00
Pascal Bleser
b283731020 groupware: convert documentation to proper markdown 2026-04-03 15:43:05 +02:00
Pascal Bleser
f294e86f5b groupware: bump redocly/cli from 2.14.6 to 2.15.1 2026-04-03 15:43:05 +02:00
Pascal Bleser
81596d5242 groupware: also update DEVELOPER.md with new OpenAPI documentation generation tooling 2026-04-03 15:43:05 +02:00
Pascal Bleser
cefc065c6d groupware: update README to new API documentation generation process, and remove defunct files 2026-04-03 15:43:05 +02:00
Pascal Bleser
d43ae6e6e2 groupware: more API examples 2026-04-03 15:43:05 +02:00
Pascal Bleser
06e147fec6 groupware: change Makefile to use groupware-apidocs instead of go-swagger 2026-04-03 15:43:05 +02:00
Pascal Bleser
2735ca1065 update redocly 2.14.5 -> 2.14.6 2026-04-03 15:43:05 +02:00
Pascal Bleser
f7ec9a43f7 groupware: migrate to cobra instead of urfave 2026-04-03 15:43:05 +02:00
Pascal Bleser
791ee451b9 groupware: update pnpm 10.28.0 -> 10.28.1 2026-04-03 15:43:05 +02:00
Pascal Bleser
56f4f49e4f fix go.mod by tidying after a significant rebase 2026-04-03 15:43:04 +02:00
Pascal Bleser
cef1cb1e5b API documentation changes for groupware-apidocs
* add example generator infrastructure, with some examples for pkg/jmap
   and pkg/groupware, with more needing to be done

 * alter the apidoc Makefile to stop using go-swagger but, instead, use
   the openapi.yml file that must be dropped into that directory using
   groupware-apidocs (will improve the integration there later)

 * add Makefile target to generate examples

 * bump redocly from 2.4.0 to 2.14.5

 * introduce Request.PathParam() and .PathParamDoc() to improve API
   documentation, as well as future-proofing

 * improve X-Request-ID and Trace-Id header handling in the middleware
   by logging it safely when an error occurs in the middleware
2026-04-03 15:40:10 +02:00
Pascal Bleser
0b9c9da8ff groupware: update to Stalwart 0.15.0 2026-04-03 15:40:10 +02:00
Pascal Bleser
b53d903229 groupware: shift some attributes of the Groupware object around, in defaults and config sub-structures 2026-04-03 15:40:10 +02:00
Pascal Bleser
ef683eed86 groupware: fix failing pkg/jscontact unit tests 2026-04-03 15:40:10 +02:00
Pascal Bleser
12e3038381 groupware: fix failing pkg/jscalendar unit tests 2026-04-03 15:40:10 +02:00
Pascal Bleser
dae691e3dc groupware: add description and version annotations for env configuration properties 2026-04-03 15:40:10 +02:00
Pascal Bleser
1ad1da8271 groupware: improve email submission and testing
* jmap/EmailCreate: add more attributes that were omitted: Headers,
   InReplyTo, References, Sender

 * add jmap GetEmailSubmissionStatus

 * improve email integration tests by adding a thorough test for email
   submission

 * jmap integration tests: provision principals and domains using the
   Stalwart Management API, switching from an in-memory to an internal
   directory
2026-04-03 15:40:10 +02:00
Pascal Bleser
5518d9357f groupware: add retrieving and adding mailboxIds for drafts and sent if they are missing 2026-04-03 15:40:10 +02:00
Pascal Bleser
ed271851e2 groupware: refactor response objects to take a list of accountIds 2026-04-03 15:40:10 +02:00
Pascal Bleser
41d57d375f groupware: minor: remove network declaration in stalwart.yml 2026-04-03 15:40:10 +02:00
Pascal Bleser
22fbb7bb2d groupware: fix missing casting to jmap.State after changes in pkg/jmap 2026-04-03 15:40:10 +02:00
Pascal Bleser
5a4cfe5390 groupware, auth-api: remove tracing and tracing configuration 2026-04-03 15:40:10 +02:00
Pascal Bleser
df43bb2d1f groupware: upgrade the Stalwart image in devtools from 0.14.0 to 0.14.1 2026-04-03 15:40:10 +02:00
Pascal Bleser
de694b6e47 groupware: WS push improvements, add getting email changes to WS integration test 2026-04-03 15:40:10 +02:00
Pascal Bleser
9604475640 groupware: JMAP WS push notifications support 2026-04-03 15:40:10 +02:00
Pascal Bleser
b606fe5715 groupware: fix email summaries and allow negative offsets
* fix a bug in how email summaries are flattened across multiple
   accounts, which was previous resulting in empty email objects

 * allow negative offset in email pagination

 * make all /emails endpoints return emails without bodies
2026-04-03 15:40:10 +02:00
Pascal Bleser
590e9c4e95 groupware: response payload /groupware/accounts/{id}/emails should be without email bodies 2026-04-03 15:40:10 +02:00
Pascal Bleser
f3179a826a groupware: add Object-Type and Account-Id response headers
* implement Request.AllAccountIds() to generalize the fetching (and
   uniqifying) of all account IDs, which will allow us to implement
   things such as "subscribed" accounts, or limiting the number of
   accounts in one request

 * add Account-Id response header

 * add Object-Type response header
2026-04-03 15:40:10 +02:00
Pascal Bleser
f637490249 groupware: feature test improvements and upgrade to Stalwart 0.14.1
* upgrade Stalwart image for devtools/full to 0.14.1

 * re-assert which features are implemented or not in 0.14.1

 * refactor the integration tests yet again to make it clearer and
   easier to see those "features-or-not"

 * get rid of old tests that are now better covered by integration tests

 * rewrite how we compare expected and actual objects in integration
   tests, finally having found a way to ignore the @type attribute
   properly instead of having to mutate all objects to remove it
2026-04-03 15:40:10 +02:00
Pascal Bleser
4890db445d groupware: finalize JMAP events integration test, with multiple changes to the model to conform with draft-ietf-calext-jscalendarbis-10 and fields that are currently not implemented in Stalwart 2026-04-03 15:40:09 +02:00
Pascal Bleser
5bfd67dd78 groupware: refactor the JMAP integration tests 2026-04-03 15:40:09 +02:00
Pascal Bleser
40a9c5aec9 groupware: improve JMAP ContactCard integration tests 2026-04-03 15:40:09 +02:00