mirror/opensourcepos
1
0
Fork 0
mirror of https://github.com/opensourcepos/opensourcepos.git synced 2026-04-01 22:04:15 -04:00
Code Issues Packages Projects Releases Wiki Activity

Apply PSR-12 camelCase naming to new variables

Browse Source 
Response to PR review comments:
- Rename  to
- Rename  to
- Rename  to
This commit is contained in:
Ollama
2026-03-13 18:27:54 +00:00
committed by jekkos
parent 6d0fbb9860
commit 36394c646a
2 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
app/Controllers/Reports.php
View File

@@ -1790,11 +1790,11 @@ class Reports extends Secure_Controller
$columns = $this->detailed_sales->getDataColumns();
// Extract just names for column headers
$definition_headers = [];
foreach ($definition_names as $definition_id => $definition_info) {
$definition_headers[$definition_id] = $definition_info['name'];
$definitionHeaders = [];
foreach ($definition_names as $definition_id => $definitionInfo) {
$definitionHeaders[$definition_id] = $definitionInfo['name'];
}
$columns['details'] = array_merge($columns['details'], $definition_headers);
$columns['details'] = array_merge($columns['details'], $definitionHeaders);
$headers = $columns;
@@ -1943,11 +1943,11 @@ class Reports extends Secure_Controller
$columns = $this->detailed_receivings->getDataColumns();
// Extract just names for column headers
$definition_headers = [];
foreach ($definition_names as $definition_id => $definition_info) {
$definition_headers[$definition_id] = $definition_info['name'];
$definitionHeaders = [];
foreach ($definition_names as $definition_id => $definitionInfo) {
$definitionHeaders[$definition_id] = $definitionInfo['name'];
}
$columns['details'] = array_merge($columns['details'], $definition_headers);
$columns['details'] = array_merge($columns['details'], $definitionHeaders);
$headers = $columns;
$report_data = $this->detailed_receivings->getData($inputs);

10
app/Helpers/tabular_helper.php
View File

@@ -408,7 +408,7 @@ function get_items_manage_table_headers(): string
{
$attribute = model(Attribute::class);
$config = config(OSPOS::class)->settings;
$definitions_with_types = $attribute->get_definitions_by_flags($attribute::SHOW_IN_ITEMS, true);
$definitionsWithTypes = $attribute->get_definitions_by_flags($attribute::SHOW_IN_ITEMS, true);
$headers = item_headers();
@@ -420,8 +420,8 @@ function get_items_manage_table_headers(): string
$headers[] = ['item_pic' => lang('Items.image'), 'sortable' => false];
foreach ($definitions_with_types as $definition_id => $definition_info) {
$headers[] = [$definition_id => $definition_info['name'], 'sortable' => false];
foreach ($definitionsWithTypes as $definition_id => $definitionInfo) {
$headers[] = [$definition_id => $definitionInfo['name'], 'sortable' => false];
}
$headers[] = ['inventory' => '', 'escape' => false];
@@ -651,12 +651,12 @@ function expand_attribute_values(array $definition_names, array $row): array
}
$attribute_values = [];
foreach ($definition_names as $definition_id => $definition_info) {
foreach ($definition_names as $definition_id => $definitionInfo) {
if (isset($indexed_values[$definition_id])) {
$raw_value = $indexed_values[$definition_id];
// Format DECIMAL attributes according to locale
if (is_array($definition_info) && isset($definition_info['type']) && $definition_info['type'] === DECIMAL) {
if (is_array($definitionInfo) && isset($definitionInfo['type']) && $definitionInfo['type'] === DECIMAL) {
$attribute_values["$definition_id"] = to_decimals($raw_value);
} else {
$attribute_values["$definition_id"] = $raw_value;