mirror/opensourcepos
1
0
Fork 0
mirror of https://github.com/opensourcepos/opensourcepos.git synced 2026-04-02 14:24:27 -04:00
Code Issues Packages Projects Releases Wiki Activity

Refactor: Add ALLOWED_SORT_COLUMNS constant and reuse in sanitization

Browse Source 
- Add Item::ALLOWED_SORT_COLUMNS constant for allowed sort columns
- Use constant in sanitizeSortColumnAttribute() instead of inline array
- Enables reuse across the codebase for sort column validation
This commit is contained in:
Ollama
2026-03-16 18:30:43 +00:00
committed by jekkos
parent 7b9bd664ab
commit 8ff7068e33
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/Controllers/Items.php
View File

@@ -79,9 +79,7 @@ class Items extends Secure_Controller
return $default;
}
$allowed_columns = ['items.item_id', 'item_number', 'name', 'category', 'company_name', 'cost_price', 'unit_price', 'quantity'];
if (in_array($field, $allowed_columns)) {
if (in_array($field, Item::ALLOWED_SORT_COLUMNS, true)) {
return $field;
}

2
app/Models/Item.php
View File

@@ -31,6 +31,8 @@ class Item extends Model
'allow_alt_description',
'is_serialized'
];
public const ALLOWED_SORT_COLUMNS = ['items.item_id', 'item_number', 'name', 'category', 'company_name', 'cost_price', 'unit_price', 'quantity'];
protected $table = 'items';
protected $primaryKey = 'item_id';
protected $useAutoIncrement = true;