mirror/opensourcepos
1
0
Fork 0
mirror of https://github.com/opensourcepos/opensourcepos.git synced 2026-04-04 15:13:40 -04:00
Code Issues Packages Projects Releases Wiki Activity

Refactored Stock Locations validation inside general validation

Browse Source 
Signed-off-by: objec <objecttothis@gmail.com>
This commit is contained in:
objec
2026-03-06 18:03:33 +04:00
parent 2b162d6aaa
commit 92f7d0bf29
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/Controllers/Items.php
View File

@@ -1093,12 +1093,12 @@ class Items extends Secure_Controller
*
* @param array $row
* @param array $itemData
* @param array $allowedLocations
* @param array $allowedStockLocations
* @param array $definitionNames
* @param array $attributeData
* @return bool Returns false if all data checks out and true when there is an error in the data
*/
private function validateCSVData(array $row, array $itemData, array $allowedLocations, array $definitionNames, array $attributeData): bool // TODO: Long function and large number of parameters in the declaration... perhaps refactoring is needed
private function validateCSVData(array $row, array $itemData, array $allowedStockLocations, array $definitionNames, array $attributeData): bool // TODO: Long function and large number of parameters in the declaration... perhaps refactoring is needed
{
$itemId = $row['Id'];
$isUpdate = (bool)$itemId;
@@ -1136,7 +1136,7 @@ class Items extends Secure_Controller
'Tax 2 Percent' => $row['Tax 2 Percent']
];
foreach ($allowedLocations as $location_name) {
foreach ($allowedStockLocations as $location_name) {
$valuesToCheckForNumeric[] = $row["location_$location_name"];
}