mirror/opensourcepos
1
0
Fork 0
mirror of https://github.com/opensourcepos/opensourcepos.git synced 2026-05-25 00:44:03 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: Use explicit transBegin/transCommit/transRollback for atomicity

Browse Source 
- Replace transStart/transComplete with transBegin/transCommit/transRollback
- Check all success conditions before committing
- Explicit rollback on failure

Address CodeRabbit review feedback
This commit is contained in:
Ollama
2026-04-15 15:29:39 +00:00
parent ad06700aea
commit 9e07f5050a
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/Controllers/Items.php
View File

@@ -664,7 +664,7 @@ class Items extends Secure_Controller
$employee_id = $this->employee->get_logged_in_employee_info()->person_id;
// Wrap the entire save sequence in a single transaction for atomicity
$this->db->transStart();
$this->db->transBegin();
$success = $this->item->save_value($item_data, $item_id);
$new_item = false;
@@ -731,14 +731,16 @@ class Items extends Secure_Controller
$success = $success && $this->saveItemAttributes($item_id);
}
$this->db->transComplete();
if ($this->db->transStatus() && $success && $upload_success) {
// Check all success conditions before committing
if ($success && $upload_success) {
$this->db->transCommit();
$message = lang('Items.successful_' . ($new_item ? 'adding' : 'updating')) . ' ' . $item_data['name'];
return $this->response->setJSON(['success' => true, 'message' => $message, 'id' => $item_id]);
}
// Rollback on failure
$this->db->transRollback();
$message = $upload_success ? lang('Items.error_adding_updating') . ' ' . $item_data['name'] : strip_tags($upload_data['error']);
return $this->response->setJSON(['success' => false, 'message' => $message, 'id' => $item_id]);