mirror/opensourcepos
1
0
Fork 0
mirror of https://github.com/opensourcepos/opensourcepos.git synced 2026-01-20 23:37:58 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2420 from opensourcepos/fix-sales-tax-migration

Browse Source 
Fix Sales Tax Migration
This commit is contained in:
Steve Ireland
2019-04-14 10:13:33 -04:00
committed by GitHub
parent a1cba7fc6a ae1fb3cac1
commit ca3b56c760
1 changed files with 192 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

224
application/migrations/20170502221506_sales_tax_data.php
View File

@@ -1,79 +1,79 @@
<?php if (!defined('BASEPATH')) exit('No direct script access allowed');
class Migration_Sales_Tax_Data extends CI_Migration
{
const ROUND_UP = 5;
const ROUND_DOWN = 6;
const HALF_FIVE = 7;
const YES = '1';
const VAT_TAX = '0';
const SALES_TAX = '1';
public function __construct()
{
parent::__construct();
$this->load->library('sale_lib');
$this->load->library('tax_lib');
}
public function up()
{
$number_of_unmigrated = $this->get_count_of_unmigrated();
error_log('Migrating sales tax history. The number of sales that will be migrated is '.$number_of_unmigrated);
if($number_of_unmigrated > 0)
{
$unmigrated_invoices = $this->get_unmigrated($number_of_unmigrated)->result_array();
foreach($unmigrated_invoices as $key=>$unmigrated_invoice)
{
$this->upgrade_tax_history_for_sale($unmigrated_invoice['sale_id']);
}
}
error_log('Migrating sales tax history. The number of sales that will be migrated is finished.');
}
public function down()
{
}
private function upgrade_tax_history_for_sale($sale_id)
{
$CI =& get_instance();
$tax_decimals = $CI->Appconfig->get('tax_decimals', 2);
$tax_included = $CI->Appconfig->get('tax_included', 0);
$customer_sales_tax_support = $CI->Appconfig->get('customer_sales_tax_support', 0);
$tax_type = $tax_included ? Tax_lib::TAX_TYPE_INCLUDED : Tax_lib::TAX_TYPE_EXCLUDED;
$tax_included = $CI->Appconfig->get('tax_included', Migration_Sales_Tax_Data::YES) == Migration_Sales_Tax_Data::YES;
$customer_sales_tax_support = FALSE;
if($tax_included)
{
$tax_type = Migration_Sales_Tax_Data::VAT_TAX;
}
else
{
$tax_type = Migration_Sales_Tax_Data::SALES_TAX;
}
$sales_taxes = array();
$tax_group_sequence = 0;
$items = $this->get_sale_items_for_migration($sale_id)->result_array();
foreach($items as $item)
{
// This computes tax for each line item and adds it to the tax type total
$tax_group = (float)$item['percent'] . '% ' . $item['name'];
$tax_basis = $this->sale_lib->get_item_total($item['quantity_purchased'], $item['item_unit_price'], $item['discount_percent'], PERCENT, TRUE);
$tax_basis = $this->get_item_total($item['quantity_purchased'], $item['item_unit_price'], $item['discount_percent'], TRUE);
$item_tax_amount = 0;
if($tax_included)
{
$item_tax_amount = $this->sale_lib->get_item_tax($item['quantity_purchased'], $item['item_unit_price'], $item['discount_percent'], PERCENT, $item['percent']);
$item_tax_amount = $this->get_item_tax($item['quantity_purchased'], $item['item_unit_price'], $item['discount_percent'], $item['percent']);
}
else
{
$item_tax_amount = $this->tax_lib->get_sales_tax_for_amount($tax_basis, $item['percent'], PHP_ROUND_HALF_UP, $tax_decimals);
$item_tax_amount = $this->get_sales_tax_for_amount($tax_basis, $item['percent'], PHP_ROUND_HALF_UP, $tax_decimals);
}
$this->update_sales_items_taxes_amount($sale_id, $item['line'], $item['name'], $item['percent'], $tax_type, $item_tax_amount);
$this->tax_lib->update_sales_taxes($sales_taxes, $tax_type, $tax_group, $item['percent'], $tax_basis, $item_tax_amount, $tax_group_sequence, PHP_ROUND_HALF_UP, $sale_id, $item['name']);
$this->update_sales_taxes($sales_taxes, $tax_type, $tax_group, $item['percent'], $tax_basis, $item_tax_amount, $tax_group_sequence, PHP_ROUND_HALF_UP, $sale_id, $item['name']);
$tax_group_sequence += 1;
}
// Not sure when this would ever kick in, but this is technically the correct logic.
if($customer_sales_tax_support)
{
$this->tax_lib->apply_invoice_taxing($sales_taxes);
$this->apply_invoice_taxing($sales_taxes);
}
$this->tax_lib->round_taxes($sales_taxes);
$this->round_sales_taxes($sales_taxes);
$this->save_sales_tax($sales_taxes);
}
private function get_unmigrated($block_count)
{
$this->db->select('SIT.sale_id');
@@ -85,10 +85,8 @@ class Migration_Sales_Tax_Data extends CI_Migration
$this->db->group_by('ST.sale_id');
$this->db->order_by('SIT.sale_id');
$this->db->limit($block_count);
return $this->db->get();
}
private function get_sale_items_for_migration($sale_id)
{
$this->db->select('sales_items.sale_id as sale_id');
@@ -101,10 +99,8 @@ class Migration_Sales_Tax_Data extends CI_Migration
$this->db->from('sales_items as sales_items');
$this->db->join('sales_items_taxes as sales_items_taxes', 'sales_items.sale_id = sales_items_taxes.sale_id and sales_items.line = sales_items_taxes.line');
$this->db->where('sales_items.sale_id', $sale_id);
return $this->db->get();
}
private function get_count_of_unmigrated()
{
$result = $this->db->query('SELECT COUNT(*) FROM(SELECT SIT.sale_id, ST.sale_id as sales_taxes_sale_id FROM '
@@ -113,10 +109,8 @@ class Migration_Sales_Tax_Data extends CI_Migration
. $this->db->dbprefix('sales_taxes')
. ' as ST ON SIT.sale_id = ST.sale_id WHERE ST.sale_id is null GROUP BY SIT.sale_id, ST.sale_id'
. ' ORDER BY SIT.sale_id) as US')->result_array();
return $result[0]['COUNT(*)'];
}
private function update_sales_items_taxes_amount($sale_id, $line, $name, $percent, $tax_type, $item_tax_amount)
{
$this->db->where('sale_id', $sale_id);
@@ -125,7 +119,6 @@ class Migration_Sales_Tax_Data extends CI_Migration
$this->db->where('percent', $percent);
$this->db->update('sales_items_taxes', array('tax_type' => $tax_type, 'item_tax_amount' => $item_tax_amount));
}
private function save_sales_tax(&$sales_taxes)
{
foreach($sales_taxes as $line=>$sales_tax)
@@ -133,5 +126,172 @@ class Migration_Sales_Tax_Data extends CI_Migration
$this->db->insert('sales_taxes', $sales_tax);
}
}
public function get_item_total($quantity, $price, $discount_percentage, $include_discount = FALSE)
{
$total = bcmul($quantity, $price);
if($include_discount)
{
$discount_amount = $this->get_item_discount($quantity, $price, $discount_percentage);
return bcsub($total, $discount_amount);
}
return $total;
}
public function get_item_discount($quantity, $price, $discount)
{
$total = bcmul($quantity, $price);
$discount_fraction = bcdiv($discount, 100);
$discount=bcmul($total,$discount_fraction);
return round($discount, totals_decimals(), PHP_ROUND_HALF_UP);
}
public function get_item_tax($quantity, $price, $discount_percentage, $tax_percentage)
{
$CI =& get_instance();
$tax_included = $CI->Appconfig->get('tax_included', Migration_Sales_Tax_Data::YES) == Migration_Sales_Tax_Data::YES;
$price = $this->get_item_total($quantity, $price, $discount_percentage, TRUE);
if($tax_included)
{
$tax_fraction = bcadd(100, $tax_percentage);
$tax_fraction = bcdiv($tax_fraction, 100);
$price_tax_excl = bcdiv($price, $tax_fraction);
return bcsub($price, $price_tax_excl);
}
$tax_fraction = bcdiv($tax_percentage, 100);
return bcmul($price, $tax_fraction);
}
public function get_sales_tax_for_amount($tax_basis, $tax_percentage, $rounding_mode, $decimals)
{
$tax_fraction = bcdiv($tax_percentage, 100);
$tax_amount = bcmul($tax_basis, $tax_fraction);
return $this->round_number($rounding_mode, $tax_amount, $decimals);
}
public function round_number($rounding_mode, $amount, $decimals)
{
if($rounding_mode == Migration_Sales_Tax_Data::ROUND_UP)
{
$fig = pow(10,$decimals);
$rounded_total = (ceil($fig*$amount) + ceil($fig*$amount - ceil($fig*$amount)))/$fig;
}
elseif($rounding_mode == Migration_Sales_Tax_Data::ROUND_DOWN)
{
$fig = pow(10,$decimals);
$rounded_total = (floor($fig*$amount) + floor($fig*$amount - floor($fig*$amount)))/$fig;
}
elseif($rounding_mode == Migration_Sales_Tax_Data::HALF_FIVE)
{
$rounded_total = round($amount / 5) * 5;
}
else
{
$rounded_total = round ( $amount, $decimals, $rounding_mode);
}
return $rounded_total;
}
public function update_sales_taxes(&$sales_taxes, $tax_type, $tax_group, $tax_rate, $tax_basis, $item_tax_amount, $tax_group_sequence, $rounding_code, $sale_id, $name='', $tax_code='')
{
$tax_group_index = $this->clean('X'.$tax_group);
if(!array_key_exists($tax_group_index, $sales_taxes))
{
$insertkey = $tax_group_index;
$sales_tax = array($insertkey => array(
'sale_id' => $sale_id,
'tax_type' => $tax_type,
'tax_group' => $tax_group,
'sale_tax_basis' => $tax_basis,
'sale_tax_amount' => $item_tax_amount,
'print_sequence' => $tax_group_sequence,
'name' => $name,
'tax_rate' => $tax_rate,
'sales_tax_code' => $tax_code,
'rounding_code' => $rounding_code
));
//add to existing array
$sales_taxes += $sales_tax;
}
else
{
// Important ... the sales amounts are accumulated for the group at the maximum configurable scale value of 4
// but the scale will in reality be the scale specified by the tax_decimal configuration value used for sales_items_taxes
$sales_taxes[$tax_group_index]['sale_tax_basis'] = bcadd($sales_taxes[$tax_group_index]['sale_tax_basis'], $tax_basis, 4);
$sales_taxes[$tax_group_index]['sale_tax_amount'] = bcadd($sales_taxes[$tax_group_index]['sale_tax_amount'], $item_tax_amount, 4);
}
}
public function clean($string)
{
$string = str_replace(' ', '-', $string); // Replaces all spaces with hyphens.
return preg_replace('/[^A-Za-z0-9\-]/', '', $string); // Removes special chars.
}
public function apply_invoice_taxing(&$sales_taxes)
{
if(!empty($sales_taxes))
{
$sort = array();
foreach($sales_taxes as $k => $v)
{
$sort['print_sequence'][$k] = $v['print_sequence'];
}
array_multisort($sort['print_sequence'], SORT_ASC, $sales_taxes);
}
$decimals = totals_decimals();
foreach($sales_taxes as $row_number => $sales_tax)
{
$sales_taxes[$row_number]['sale_tax_amount'] = $this->get_sales_tax_for_amount($sales_tax['sale_tax_basis'], $sales_tax['tax_rate'], $sales_tax['rounding_code'], $decimals);
}
}
public function round_sales_taxes(&$sales_taxes)
{
if(!empty($sales_taxes))
{
$sort = array();
foreach($sales_taxes as $k=>$v)
{
$sort['print_sequence'][$k] = $v['print_sequence'];
}
array_multisort($sort['print_sequence'], SORT_ASC, $sales_taxes);
}
$decimals = totals_decimals();
foreach($sales_taxes as $row_number => $sales_tax)
{
$sale_tax_amount = $sales_tax['sale_tax_amount'];
$rounding_code = $sales_tax['rounding_code'];
$rounded_sale_tax_amount = $sale_tax_amount;
if ($rounding_code == PHP_ROUND_HALF_UP
|| $rounding_code == PHP_ROUND_HALF_DOWN
|| $rounding_code == PHP_ROUND_HALF_EVEN
|| $rounding_code == PHP_ROUND_HALF_ODD)
{
$rounded_sale_tax_amount = round($sale_tax_amount, $decimals, $rounding_code);
}
elseif($rounding_code == Migration_Sales_Tax_Data::ROUND_UP)
{
$fig = (int) str_pad('1', $decimals, '0');
$rounded_sale_tax_amount = (ceil($sale_tax_amount * $fig) / $fig);
}
elseif($rounding_code == Migration_Sales_Tax_Data::ROUND_DOWN)
{
$fig = (int) str_pad('1', $decimals, '0');
$rounded_sale_tax_amount = (floor($sale_tax_amount * $fig) / $fig);
}
elseif($rounding_code == Migration_Sales_Tax_Data::HALF_FIVE)
{
$rounded_sale_tax_amount = round($sale_tax_amount / 5) * 5;
}
$sales_taxes[$row_number]['sale_tax_amount'] = $rounded_sale_tax_amount;
}
}
}
?>
?>