mirror/opensourcepos
1
0
Fork 0
mirror of https://github.com/opensourcepos/opensourcepos.git synced 2026-04-03 23:01:50 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix remaining CodeRabbit review comments

Browse Source 
- Add translation key for 'Add Table' in dinner_tables.php
- Cast dinner_table_id to int in label and span for consistency
- Remove debug <br> tags from register.php
- Fix duplicate cart_contents ID in register.php (use cart_contents_card for card section)
- Fix textarea value attribute in message_config.php
This commit is contained in:
opencode
2026-04-03 10:42:31 +00:00
parent 987c1904f7
commit fb37ed9905
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/Language/en/Config.php
View File

@@ -103,6 +103,7 @@ return [
"derive_sale_quantity" => "Allow Derived Sale Quantity",
"derive_sale_quantity_tooltip" => "If checked then a new item type will be provided for items ordered by extended amount",
"dinner_table" => "Table",
"dinner_table_add" => "Add Table",
"dinner_table_duplicate" => "Table must be unique.",
"dinner_table_enable" => "Enable Dinner Tables",
"dinner_table_invalid_chars" => "Table Name can not contain '_'.",

6
app/Views/partial/dinner_tables.php
View File

@@ -5,7 +5,7 @@
?>
<span class="d-flex justify-content-start add_dinner_table">
<button class="btn btn-outline-success mb-3" type="button"><i class="bi bi-plus-lg"></i>&nbsp;Add table</button> <!-- TODO-BS5 translate -->
<button class="btn btn-outline-success mb-3" type="button"><i class="bi bi-plus-lg"></i>&nbsp;<?= lang('Config.dinner_table_add') ?></button>
</span>
<?php
@@ -18,9 +18,9 @@ foreach ($dinner_tables as $table_key => $table) {
?>
<div class="col-12 col-lg-6 <?= $table['deleted'] ? 'd-none' : '' ?>">
<label for="dinner_table_<?= $dinner_table_id ?>" class="form-label"><?= lang('Config.dinner_table') . " $i"; ?></label>
<label for="dinner_table_<?= (int) $dinner_table_id ?>" class="form-label"><?= lang('Config.dinner_table') . " $i"; ?></label>
<div class="input-group mb-3">
<span class="input-group-text"><?= $dinner_table_id ?>.</span>
<span class="input-group-text"><?= (int) $dinner_table_id ?>.</span>
<input type="text" class="form-control dinner_table valid_chars" name="dinner_table_<?= (int) $dinner_table_id ?>" id="dinner_table_<?= (int) $dinner_table_id ?>" value="<?= esc($dinner_table_name) ?>" required <?= $table['deleted'] ? 'disabled' : '' ?>>
<button class="btn btn-outline-danger remove_dinner_table" type="button"><i class="bi bi-x-lg"></i></button>
</div>

3
app/Views/sales/register.php
View File

@@ -140,7 +140,7 @@ helper('url');
</tr>
</thead>
<tbody id="cart_contents">
<tbody id="cart_contents_card">
<?php if (count($cart) == 0) { ?>
<tr>
<td colspan="8">
@@ -201,7 +201,6 @@ helper('url');
<div id="register_wrapper">
<br><br><br><br><br>
<!-- Sale Items List -->
<table class="sales_table_100" id="register">