mirror of
https://github.com/opensourcepos/opensourcepos.git
synced 2026-09-13 22:08:16 -04:00
jekkos
28755dfd50
* fix(tests): resolve all phpunit failures (#4626) Bring the phpunit suite from 153 failures to 0 (281 tests passing): - Employee: decouple grants block from save_value success; restructure save_employee new-employee + disallowed-grants early return - Sale: unify sales_payments_temp schema (add sale_cash_refund, reference_code) so both creators produce an identical superset table - Employees controller: provide placeholder password/hash in testing env so new-employee insert succeeds and grant logic is testable - TestDatabaseBootstrapSeeder: reset shared connection table-name cache after bootstrap reset to avoid stale listTables()/tableExists() results - Config: fix postSaveLocale validation rule syntax - Test data: use unique employee usernames to avoid UNIQUE constraint collisions latching strict-mode transStatus=false on the shared conn - Various test-file and language-string corrections * test: consolidate employee fixtures in shared trait Route test employee creation through a single EmployeeFixtureTrait that delegates to Employee::save_employee(), so fixtures exercise the same production code path instead of raw DB inserts. Removes six near-duplicate helpers across EmployeeTest, SalesControllerTest, and EmployeesControllerTest while preserving each test's specific grant set. Closes a piece of the fixture-scattering flagged in #4626. Closes #4626 * test: add global DROP/CREATE grant and commit theme fixtures * fix(ci): remove redundant symlink step, set working encryption key * fix(ci): run phpunit with --no-coverage to avoid no-driver warning * fix: address code review findings - Config: restore strict locale validation (min required|integer|>0) and fix max cross-field check with a new gte_field rule (CI4's greater_than_equal_to[field] does not resolve the field value) - Tests: assert rejection for non-numeric/zero/negative/min>max limits - .env.example: remove shared hard-coded encryption.key (auto-generates); document Docker env-var usage - phpunit.yml: scope CREATE/DROP grant to ospos_test.* and provision a per-run encryption key as an env var * feat: support ENCRYPTION_KEY env var for encryption key Read ENCRYPTION_KEY as a fallback for the encryption key when the config value is empty. This is a supported, reliable path for Docker / container deploys and CI, avoiding reliance on the raw dotted encryption.key env var. * fix: align Summary_report temp tables with Sale temp table schema Summary_report created sales_items_taxes_temp and sales_payments_temp with fewer columns than the canonical create_temp_table() in Sale.php. A later reader expecting those columns hit a schema-mismatch SQL error on the shared temp tables. Add internal_tax/sales_tax (sales_items_taxes_temp) and reference_code (sales_payments_temp) so all creators emit the identical column set.
69 lines
2.5 KiB
PHP
69 lines
2.5 KiB
PHP
<?php
|
|
|
|
namespace App\Database\Migrations;
|
|
|
|
use CodeIgniter\Database\Migration;
|
|
|
|
class Migration_Initial_Schema extends Migration
|
|
{
|
|
public function __construct()
|
|
{
|
|
parent::__construct();
|
|
}
|
|
|
|
/**
|
|
* Perform a migration step.
|
|
*
|
|
* Deterministically (re)applies the base 3.0.2 schema. Down() is
|
|
* responsible for clearing the application tables first, so this method
|
|
* always runs the initial schema script. We intentionally do NOT skip on
|
|
* "tables already exist": CodeIgniter's listTables() result is cached on
|
|
* the connection, so a prior down()/regress() cycle in the same process
|
|
* can leave a stale table list and a naive "skip if present" check would
|
|
* refuse to rebuild tables that were just dropped.
|
|
*/
|
|
public function up(): void
|
|
{
|
|
helper('migration');
|
|
executeScript(APPPATH . 'Database/Migrations/sqlscripts/initial_schema.sql');
|
|
}
|
|
|
|
/**
|
|
* Revert a migration step.
|
|
*
|
|
* Drops the base application tables (and the migrations tracking table)
|
|
* so the next up() re-creates a clean 3.0.2 baseline. Disables FK checks
|
|
* so drop order doesn't matter.
|
|
*/
|
|
public function down(): void
|
|
{
|
|
// Query the table list straight from the database. We must NOT use
|
|
// $this->db->listTables(): CI4 caches the result in dataCache and, in a
|
|
// long-lived test process, that cached list is stale (populated by a
|
|
// prior test class's connection), so drops would be skipped and the
|
|
// next up() would hit "Table ... already exists".
|
|
$db = $this->db;
|
|
$result = $db->query('SELECT TABLE_NAME FROM information_schema.TABLES WHERE TABLE_SCHEMA = ?', [$db->database]);
|
|
|
|
$tables = $result ? array_column($result->getResultArray(), 'TABLE_NAME') : [];
|
|
|
|
// Preserve the migrations tracking table: MigrationRunner::regress()
|
|
// calls removeHistory() AFTER down(), so dropping it here would raise
|
|
// "Table '...ospos_migrations' doesn't exist".
|
|
$migrationsTable = $db->getPrefix() . 'migrations';
|
|
|
|
$db->query('SET FOREIGN_KEY_CHECKS = 0');
|
|
foreach ($tables as $table) {
|
|
if ($table === $migrationsTable) {
|
|
continue;
|
|
}
|
|
$db->query('DROP TABLE IF EXISTS `' . $table . '`');
|
|
}
|
|
$db->query('SET FOREIGN_KEY_CHECKS = 1');
|
|
|
|
// Invalidate the stale in-connection table-name cache so a subsequent
|
|
// listTables() in the same process sees the fresh state.
|
|
$db->dataCache['table_names'] = [];
|
|
}
|
|
}
|