mirror of
https://github.com/opensourcepos/opensourcepos.git
synced 2026-10-29 03:28:53 -04:00
objecttothisandClaude Sonnet 4.6
74e825ba6f
Refactor Stock_location model to camelCase naming and introduce
is_default and sort_order fields with full migration, UI, and
item-sync support. Multiple follow-up fixes consolidated.
Database
- Add is_default (TINYINT, backfilled to oldest non-deleted row) and
sort_order (nullable unsigned TINYINT unique, dense 0..N-1) columns
via new migration; MySQL 5.7-compatible backfill using user variables
instead of ROW_NUMBER(); down() drops both columns
Model
- Rename show_locations → showLocations (camelCase convention)
- Add getDefaultLocationId(), setDefaultLocation(), saveSortOrder();
validate location existence before setting as default
- delete() compacts sort_order via two-pass CASE update to avoid
collisions after prior reorders
- Atomic sort_order assignment via explicit SQL COUNT query
Controller / Config
- Modularize save logic into sanitizeSubmittedLocations(),
deleteRemovedLocations(), saveSubmittedLocations(),
saveLocationOrderAndDefault(); wrap in single transaction
- Support stock_location_new inputs for new-row creation
- Resolve new-* ID placeholders to real IDs post-save
- Abort loop on save failure; default missing POST arrays to []
- Validate that at least one location array is non-empty
Views
- Add Default column with center-aligned radio buttons; disable for
unsaved rows; use attr() instead of data() for location IDs
- Escape dynamic location IDs against XSS in all affected partials
- form_count_details.php: fall back to default location when current
is undefined; guard quantity input similarly
- Add aria-label to default radio inputs
Libraries / Items
- Widen Item_lib::get_item_location() and get_stock_destination() to
nullable return types
- Guard null location_id in Items::getRow() and getGenerateBarcodes()
- Item::get_multiple_info(): accept ?int $location_id; short-circuit
with where('item_id', -1) instead of always-false where('1','0')
i18n
- Add stock_location_default, stock_location_default_header,
stock_location_name_header across all locale files
Tests
- Stock_locationTest: getDefaultLocationId, setDefaultLocation,
saveSortOrder, delete compaction, saveValue; rename to
testMethod_Scenario convention
- Add ConfigControllerTest / StockLocationsControllerTest with
AdminAuthTrait covering CRUD, reorder, default assignment, and
malformed/empty/blank payload validation
- DatabaseBootstrapTrait-based setup for ItemTest and Stock_locationTest
Signed-off-by: objecttothis <17935339+objecttothis@users.noreply.github.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
58 lines
1.2 KiB
PHP
58 lines
1.2 KiB
PHP
<?php
|
|
|
|
namespace app\Libraries;
|
|
|
|
use CodeIgniter\Model;
|
|
use CodeIgniter\Session\Session;
|
|
use App\Models\Stock_location;
|
|
|
|
/**
|
|
* Item library
|
|
*
|
|
* Library with utilities to manage items
|
|
*/
|
|
|
|
class Item_lib
|
|
{
|
|
private Session $session;
|
|
private Stock_location $stock_location;
|
|
|
|
public function __construct()
|
|
{
|
|
$this->session = Session();
|
|
$this->stock_location = model(Stock_location::class);
|
|
}
|
|
|
|
/**
|
|
* @return string|null
|
|
*/
|
|
public function get_item_location(): ?string
|
|
{
|
|
if (!$this->session->get('item_location')) {
|
|
$location_id = $this->stock_location->getDefaultLocationId();
|
|
if ($location_id !== null) {
|
|
$this->set_item_location((string) $location_id);
|
|
}
|
|
}
|
|
|
|
return $this->session->get('item_location');
|
|
}
|
|
|
|
/**
|
|
* @param string|null $location
|
|
* @return void
|
|
*/
|
|
public function set_item_location(?string $location): void
|
|
{
|
|
$this->session->set('item_location', $location);
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
*/
|
|
public function clear_item_location(): void // TODO: This isn't called from anywhere in the code.
|
|
{
|
|
$this->session->remove('item_location');
|
|
}
|
|
}
|